Bug 149708 - DOCX Track Changes: Writer does not export change tracking of the paragraph mark of an inserted list item (see Comment 2)
Summary: DOCX Track Changes: Writer does not export change tracking of the paragraph m...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2
Keywords:
Depends on:
Blocks: Track-Changes-Lists
  Show dependency treegraph
 
Reported: 2022-06-24 07:22 UTC by NISZ LibreOffice Team
Modified: 2022-07-26 07:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-06-24 07:22:08 UTC
Description:
Writer does not show the change in serial numbers in numbered lists when an item is inserted.

Steps to Reproduce:
1. Create a numbered list in LibreOffice Writer.
2. Record Track Changes. (Ctrl - Shift - E)
3. Create a new element in the list.

Actual Results:
Writer does not show that the last item was the 3. previously.

Expected Results:
Show that the last item was the third list item previously.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: cb22629eb251de97084ab11f80cb54687483996f
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 1 Xisco Faulí 2022-06-24 08:37:41 UTC

*** This bug has been marked as a duplicate of bug 149709 ***
Comment 2 László Németh 2022-07-05 16:59:13 UTC
I.e. a new list item is exported only as an old empty list item with new tracked text content. It's rejection leaves an empty list item in the list.
Comment 3 Commit Notification 2022-07-06 10:39:14 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d5bf3d8dfe51aa6791fd88e62fc542d888aa05c7

tdf#149708 sw_redlinenum DOCX export: track inserted list items

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 László Németh 2022-07-06 10:39:39 UTC
Commit description:

tdf#149708 sw_redlinenum DOCX export: track inserted list items

Change tracking of the paragraph mark of an inserted list item
wasn't exported. I.e. a new list item was exported as an old
empty list item with new tracked text content. It was loaded
with bad actual/original numbering, and rejection of the
incomplete insertion left an empty list item in the list instead
of removing that list item completely.

Note: the problem was inherited from OOo.

See also commit 508ed558948353a3eb8be9adf3588368e440f4cf
"tdf#115524 sw_redlinenum: show original numbering of insertions"
and commit 4e5f89d2d3511b6421b388ecaba2f61ada14d084
"tdf#119848 DOCX export: keep tracked deleted empty line".
Comment 5 Commit Notification 2022-07-06 11:20:35 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/80694a8fcfeb86ed69425ab6954b353b9a0ae854

tdf#149708 sw_redlinenum DOCX export: track inserted list items

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 NISZ LibreOffice Team 2022-07-26 07:48:13 UTC
Verified in:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5df1bb4b1b222be00d25097660c4ee33542896ea
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL