It's great to see sparklines feature added in 7.4. As a translator I've found the following two small problems with the UI strings for sparklines: 1. The standard UI menu: "Insert > Insert Sparkline...". All the other entries under "Insert" don't have the starting "Insert". It's probably better to make it "Insert > Sparkline...". 2. In the "Sparkline Properties" dialog, "Axes" section at the bottom, the "Vertical maximum" label is missing a colon (:) in the end, should be "Vertical maximum:". I don't think it matters, but this is seen with 7.4.0 beta1 on Windows 11.
One more thing that I don't think necessarily a bug, but worth discussion: As the help documentation [1] says, the "Stacked" type is also known as win/loss type. I don't know how it's named in MS Excel, but we already use "stacked" type for regular column charts, and there it's quite different from this "stacked" sparkline. 1. https://help.libreoffice.org/7.4/en-US/text/scalc/01/sparklines.html?DbPAR=CALC
On pc Debian x86-64 with master sources updated today, I could reproduce this. I submitted a patch here to fix typos indicated in initial description: https://gerrit.libreoffice.org/c/core/+/136955 It seems it won't be possible to cherry-pick on 7.4 branch since hard English string & UI freeze is over (see https://wiki.documentfoundation.org/ReleasePlan/7.4) Sophie/Adolfo: don't hesitate to tell if I'm wrong or if exceptions can be made.
(In reply to Julien Nabet from comment #2) > On pc Debian x86-64 with master sources updated today, I could reproduce > this. > > I submitted a patch here to fix typos indicated in initial description: > https://gerrit.libreoffice.org/c/core/+/136955 > > It seems it won't be possible to cherry-pick on 7.4 branch since hard > English string & UI freeze is over (see > https://wiki.documentfoundation.org/ReleasePlan/7.4) > > Sophie/Adolfo: don't hesitate to tell if I'm wrong or if exceptions can be > made. Thanks for your patch :) String freeze can only be broken for very serious reasons such as security fixes or major inconsistency in the UI. As this issue is of minor importance, I don't see the need to break string freeze.
(In reply to sophie from comment #3) > ... > Thanks for your patch :) String freeze can only be broken for very serious > reasons such as security fixes or major inconsistency in the UI. > As this issue is of minor importance, I don't see the need to break string > freeze. Ok no pb, it was just to be sure :-)
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f8a84ef8f085251d545597a83d71b5b5b2f547d6 tdf#149738: Minor inconsistencies in sparkline related UI strings It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
About stack part, let's wait for the result of the discussion if there's one.
Thanks for fixing this, Julien! (In reply to Julien Nabet from comment #6) > About stack part, let's wait for the result of the discussion if there's one. Sure, and I can always open a new bug if necessary.
*** Bug 150519 has been marked as a duplicate of this bug. ***
*** Bug 150699 has been marked as a duplicate of this bug. ***
*** Bug 151409 has been marked as a duplicate of this bug. ***