Bug 149783 - FILESAVE: ODT: xml:id attribute missing from numbered lists
Summary: FILESAVE: ODT: xml:id attribute missing from numbered lists
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-30 08:33 UTC by Michelle
Modified: 2023-07-20 05:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Original Example File (9.66 KB, application/vnd.oasis.opendocument.text)
2022-06-30 08:34 UTC, Michelle 		Details
Example File after Export (9.78 KB, application/vnd.oasis.opendocument.text)
2022-06-30 08:35 UTC, Michelle 		Details
Diff results (82.03 KB, image/png)
2022-06-30 08:38 UTC, Michelle 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michelle 2022-06-30 08:33:47 UTC 
Description:
Save As ODT loses the xml:id attribute of text:list elements in the content.xml.

The issue occurs with ODT and DOCX files.

This issue does not occur in LO7.3.4.2 and below.

Steps to Reproduce:
1. Create a new odt with at least 2 lists (example attached)
2. Save and Close
3. Reopen File and Save As odt with a new name
4. View/Diff the content.xml to see the missing xml:id attribute

Actual Results:
xml:id attribute is missing in exported file.

Expected Results:
Files should be identical.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 7.4.0.0.beta1 (x64) / LibreOffice Community
Build ID: cec1fe9b57a55c032f9f118c907f34e22a63d040
CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-AU (en_AU); UI: en-GB
Calc: CL
Comment 1 Michelle 2022-06-30 08:34:35 UTC 
Created attachment 181026 [details]
Original Example File
Comment 2 Michelle 2022-06-30 08:35:36 UTC 
Created attachment 181027 [details]
Example File after Export
Comment 3 Michelle 2022-06-30 08:38:19 UTC 
Created attachment 181028 [details]
Diff results
Comment 4 Miklos Vajna 2022-06-30 08:55:04 UTC 
This is somewhat intentional: if the list has an xml:id="..." but nobody refers to that ID, then we omit it, so the output is easier to check into expected test results or into e.g. git.

If there is a later continue-list="..." that refers to an ID and we don't emit the xml:id="..." for that, that's a bug. Bug 149668 was for this.

Are you aware of any cases where that xml:id is referenced, but we don't write it?

Thanks.
Comment 5 Buovjaga 2023-01-20 08:21:54 UTC 
(In reply to Miklos Vajna from comment #4)
> This is somewhat intentional: if the list has an xml:id="..." but nobody
> refers to that ID, then we omit it, so the output is easier to check into
> expected test results or into e.g. git.
> 
> If there is a later continue-list="..." that refers to an ID and we don't
> emit the xml:id="..." for that, that's a bug. Bug 149668 was for this.
> 
> Are you aware of any cases where that xml:id is referenced, but we don't
> write it?

NEEDINFO while we wait for a reply.
Comment 6 QA Administrators 2023-07-20 03:17:48 UTC Comment hidden (obsolete)
Comment 7 Michelle 2023-07-20 03:25:39 UTC 
Apologies for the delay.

We ended up implementing a workaround for this behavior in our system to meet our requirements. Please feel free to close this one.
Comment 8 Buovjaga 2023-07-20 05:55:26 UTC 
Would have been nice to get a reply to

(In reply to Miklos Vajna from comment #4)
> Are you aware of any cases where that xml:id is referenced, but we don't
> write it?

But let's close as notabug.