Bug 149805 - kf5: Gap when expanding comboboxes in toolbar
Summary: kf5: Gap when expanding comboboxes in toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All Linux (All)
: medium minor
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisected, bisected, regression
: 150774 153147 (view as bug list)
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2022-07-01 11:31 UTC by Michael Weghorn
Modified: 2023-04-07 16:41 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the issue (90.32 KB, image/png)
2022-07-01 11:31 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2022-07-01 11:31:09 UTC
Created attachment 181065 [details]
Screenshot of the issue

When using the kf5 VCL plugin on Linux, expanding a combobox in the toolbar by clicking into it now opens the popup slightly below the place where the combobox itself is, s. attached screenshot.

Steps to reproduce

0) use kf5 VCL plugin
1) start Writer
2) click into some combobox in the toolbar, e.g. the font combobox
3) look where the popup opens

Actual result:
There is a "gap" between the combobox and the popup menu showing the choices.

Expected result:
There should be no gap.

Note: The fact that the combobox isn't isn't correctly styled (which can also be seen in the screenshot) is a different issue, and handled in tdf#149804.
Comment 1 Michael Weghorn 2022-07-01 11:32:49 UTC
This is a regression from

    commit afc828b9833b7a612369e95606ba56d41ef2c369
    Author: Jan-Marek Glogowski
    Date:   Sat May 28 23:47:21 2022 +0200

        VCL expect correct frame size for native menubars

Adding CC: to Jan-Marek Glogowski
Comment 2 Timur 2022-09-09 09:32:14 UTC
I see this with 7.5+ only 1st time after I start kf5 after gtk3.
Comment 3 Michael Weghorn 2022-09-14 07:40:04 UTC
(In reply to Timur from comment #2)
> I see this with 7.5+ only 1st time after I start kf5 after gtk3.

For me, this also happens with a fresh profile.

Turns out this is reliably reproducible when LO starts maximized (i.e. was maximized when closed in the last run) or after I maximize the window.

It's not reproducible when when I close a non-maximized LO and start again (in which case the window opens in non-maximized state).
Comment 4 Gabor Kelemen (allotropia) 2022-09-15 11:56:37 UTC
*** Bug 150774 has been marked as a duplicate of this bug. ***
Comment 5 Buovjaga 2022-12-07 12:22:04 UTC
I noticed this also with a maximised print dialog and bisected to the commit mentioned.
Comment 6 Stéphane Guillou (stragu) 2023-01-22 15:15:48 UTC
*** Bug 153147 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2023-03-29 10:46:15 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f51b220b953ec71fb742f799fbe645a93cf3d944

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Michael Weghorn 2023-03-29 10:51:08 UTC
Fixed now by reverting the commit that caused the regression, s. more details in the commit message.
Comment 9 Commit Notification 2023-04-07 16:41:41 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0d2e22e1700aca42246924c2083c2271a9ad0d79

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.