Bug 149890 - SVG: pattern is displayed with black fill
Summary: SVG: pattern is displayed with black fill
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0.2 target:7....
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-07-07 09:09 UTC by Xisco Faulí
Modified: 2023-11-09 23:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (361 bytes, image/svg+xml)
2022-07-07 09:09 UTC, Xisco Faulí
Details
Comparison Firefox and LibreOffice 7.5 Master (42.19 KB, image/png)
2022-07-07 09:11 UTC, Xisco Faulí
Details
How it looks in LibreOffice 7.2 (33.96 KB, image/png)
2022-07-08 11:53 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-07-07 09:09:55 UTC
Created attachment 181148 [details]
sample file

Steps to reproduce:
1. Open attached SVG.

-> Rectangles are blue and black. They should be blue and white. See Firefox - LibreOffice comparison

Reproduced in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: e4066a41406b1ddd454901b4fa718cf9be2746c4
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2022-07-07 09:11:06 UTC
Created attachment 181149 [details]
Comparison Firefox and LibreOffice 7.5 Master
Comment 2 Xisco Faulí 2022-07-07 09:12:03 UTC
Regression introduced by:

author	Noel Grandin <noel.grandin@collabora.co.uk>	2021-06-14 15:05:59 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2021-08-27 08:48:19 +0200
commit 3cbe3a0259bea4dec70e72191ec3c03441926a07 (patch)
tree 27427224390a9d529e983f459ab0a30d4b531701
parent cab2f3790517c6f2c77686869b305d66a1e04fb9 (diff)
tdf#101083 speed up SVG rendering with pattern fill

Bisected with: bibisect-linux64-7.3

Adding Cc: to Noel Grandin
Comment 3 Noel Grandin 2022-07-07 18:32:45 UTC
No, the SVG actually just says to create blue blocks. It doesn't say anything about what color the background is meant to be.
So either interpretation is valid.
Comment 4 Xisco Faulí 2022-07-07 19:40:16 UTC
(In reply to Noel Grandin from comment #3)
> No, the SVG actually just says to create blue blocks. It doesn't say
> anything about what color the background is meant to be.
> So either interpretation is valid.

so I guess if it doesn't say anything, then it should be transparent or white, not black
Comment 5 Xisco Faulí 2022-07-08 11:53:41 UTC
Created attachment 181174 [details]
How it looks in LibreOffice 7.2
Comment 6 Commit Notification 2022-07-09 10:21:07 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/77ead3d8c01b3663b0ff701a934f10b602252412

tdf#149890 SVG: pattern is displayed with black fill

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2022-07-11 08:25:07 UTC
Verified in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a93d7e7df6804cd6f1f2fa1ef0e6e95ce6c3752a
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!
Comment 8 Commit Notification 2022-07-11 10:08:30 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/958225b7a48824a86c7af1ba8c8c132dc2b2fd9c

tdf#149890 SVG: pattern is displayed with black fill

It will be available in 7.4.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-07-11 10:16:42 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/fb7b2a9742280d1894c6fecb13cae89e006de358

tdf#149890 SVG: pattern is displayed with black fill

It will be available in 7.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2022-07-11 10:34:32 UTC
I tried to create a unittest for this issue but I don't know how to test it atm
Comment 11 Commit Notification 2022-07-15 18:20:09 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-5":

https://git.libreoffice.org/core/commit/80fdbbfe0b985aa91180eaaa554e4369c993b59b

tdf#149890 SVG: pattern is displayed with black fill

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Xisco Faulí 2023-11-09 23:46:39 UTC
Verified in

Version: 7.4.7.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: de-DE (es_ES.UTF-8); UI: es-ES
Debian package version: 4:7.4.7-1
Calc: threaded