Bug 149971 - FILEOPEN PPTX: video is "blown" up, distorting proportions
Summary: FILEOPEN PPTX: video is "blown" up, distorting proportions
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:7.5.0 target:7.4.2
Keywords:
Depends on:
Blocks: Media PPTX
  Show dependency treegraph
 
Reported: 2022-07-13 05:58 UTC by Gerald Pfeifer
Modified: 2022-11-03 18:38 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Visual comparision Impress (left) vs PowerPoint (right) (729.57 KB, image/png)
2022-07-13 05:58 UTC, Gerald Pfeifer
Details
PowerPoint 2021 output. (262.89 KB, image/png)
2022-08-23 13:12 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2022-07-13 05:58:43 UTC
Created attachment 181243 [details]
Visual comparision Impress (left) vs PowerPoint (right)

Using attachment #181242 [details] from bug #181242 
( https://bugs.documentfoundation.org/attachment.cgi?id=181242 )

Unlike PowerPoint, Impress blows up the video in the sample slide
to the size of the bounding rectangle and distorts proportions.
Comment 1 Aron Budea 2022-07-19 22:44:51 UTC
Confirmed using LO 7.5.0.0.alpha0+ (28daee8a3252e03a67484dc8d3dd26fd73af4826), 4.0.0.3 / Ubuntu.
Comment 2 Miklos Vajna 2022-08-23 13:12:49 UTC
Created attachment 181978 [details]
PowerPoint 2021 output.

I can also confirm the Impress vs PowerPoint difference, but interestingly PowerPoint 2021 renders the video a bit differently for me, when compared to attachment 181243 [details]'s PowerPoint output.

Instead of extending the bitmap with black pixels to turn the video's aspect ratio into the shape's aspect ratio, information from the file is used to decide how to crop it.

Nevertheless, the difference between the two PowerPoint outputs is rather small, while the current Impress output different is rather large.
Comment 3 Commit Notification 2022-08-24 13:46:50 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8fa1d453c94cdbb03dac646fb8db2ebd1a0e84bd

Related: tdf#149971 svx: support explicitly provided snapshots for media shapes

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Aron Budea 2022-08-24 16:36:04 UTC
(In reply to Miklos Vajna from comment #2)
> I can also confirm the Impress vs PowerPoint difference, but interestingly
> PowerPoint 2021 renders the video a bit differently for me, when compared to
> attachment 181243 [details]'s PowerPoint output.
> 
> Instead of extending the bitmap with black pixels to turn the video's aspect
> ratio into the shape's aspect ratio, information from the file is used to
> decide how to crop it.
Actually, same here with PP 2013, I only checked what it looked like in Impress originally.
Comment 5 Commit Notification 2022-08-25 13:42:41 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6f0fd6a2f459ead2268e07bfd86db7e303b323f

Related: tdf#149971 avmedia: add doc model and render for crop of media objects

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-08-26 09:49:39 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/916848d877a788d02e2e7c980872314839101798

tdf#149971 avmedia: implement video crop support in the gsteamer backend

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Miklos Vajna 2022-08-26 09:52:13 UTC
I think this is now fixed on master.
Comment 8 Commit Notification 2022-08-29 20:17:53 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/4daac4a6b18be593550e87f97e304d5475d7e6d7

Related: tdf#149971 svx: support explicitly provided snapshots for media shapes

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-08-31 07:57:04 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/c7577330e806858f99b8c78f63e734fdb2c06b6e

Related: tdf#149971 avmedia: add doc model and render for crop of media objects

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-08-31 08:00:15 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/99ee5b4a9e6516ca47789150eb92b780e917cddd

tdf#149971 avmedia: implement video crop support in the gsteamer backend

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Gerald Pfeifer 2022-09-27 15:45:10 UTC
(In reply to Miklos Vajna from comment #2)
> Created attachment 181978 [details]
> PowerPoint 2021 output.
> 
> I can also confirm the Impress vs PowerPoint difference, but interestingly
> PowerPoint 2021 renders the video a bit differently for me, when compared to
> attachment 181243 [details]'s PowerPoint output...

I forgot to mention in the original description that my findings (and
reference to) PowerPoint where with the web version of Office 365.

Just for reference in case of someone wondering in the future.


(In reply to Commit Notification from comment #6)
> Miklos Vajna committed a patch related to this issue.
:
> Affected users are encouraged to test the fix and report feedback.

Thank you, Miklos. I believe this can be closed. :-)
Comment 12 JohnRouel3 2022-11-03 16:17:20 UTC Comment hidden (spam)