Bug 150052 - FORMATTING - Formatting not restored calc undo
Summary: FORMATTING - Formatting not restored calc undo
Status: RESOLVED DUPLICATE of bug 153437
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Undo-Redo Calc-Cells
  Show dependency tree / graph
 
Reported: 2022-07-18 22:35 UTC by flywire
Modified: 2023-06-23 08:43 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description flywire 2022-07-18 22:35:45 UTC 
1. Start Calc
2. select row, Format cell, Background, Color, Yellow, OK
3. select column, say C, Sheet, Insert Column, Columns Before
4. Undo - Note background color is lost

This is a simple demonstration, I've seen cells revert to formulas instead of values. Problem does not occur in V7.3.4.2

Version: 7.4.0.1 (x64) / LibreOffice Community
Build ID: 43e5fcfbbadd18fccee5a6f42ddd533e40151bcf
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-AU (en_AU); UI: en-GB
Calc: threaded
Comment 1 flywire 2022-07-18 22:40:22 UTC 
(In reply to flywire from comment #0)
> I've seen cells revert to formulas instead of values.

That could have been with an insert column. Anyway, it was unexpected.
Comment 2 Timur 2022-07-26 09:59:56 UTC 
Repro in Linux and Win with 7.5+. New.
https://gerrit.libreoffice.org/gitweb?p=core.git;a=log;h=28daee8a3252e03a67484dc8d3dd26fd73af4826
Comment 3 Timur 2022-07-26 10:40:55 UTC 
commit 2e86718626a07e1656661df3ad69a64848bf4614	[log]
author	Luboš Luňák <l.lunak@collabora.com>	Wed May 18 2022
don't allocate unnecessary columns when inserting a row

CC 	Luboš please see
Comment 4 ady 2023-06-02 16:28:47 UTC 
Repro in LO 7.4 but no longer repro in:

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 389a8d52d9961f89c0b2847b30ee1ca59a8fdc80
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded
Built: 2023-05-02

Possibly related to patch as in bug 153437 comment 7 (but I haven't checked this specific relation).

I have not checked in LO 7.5.
Comment 5 ady 2023-06-02 17:37:09 UTC 
(In reply to ady from comment #4)
> Repro in LO 7.4 but no longer repro in:
> 
> Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
> Built: 2023-05-02
Typo: 7.6.alpha as of 2023-06-02
Comment 6 Stéphane Guillou (stragu) 2023-06-23 08:43:12 UTC 
(In reply to ady from comment #4)
> Possibly related to patch as in bug 153437 comment 7 (but I haven't checked
> this specific relation).

Confirmed that it is now fixed in 7.6 and 24.2
I bibisected the fix with the linux-64-7.6 repo to this range:
https://git.libreoffice.org/core/+log/cf4a1c42d6a90ec73ab1504d4bfaf3004bad33da..5e68d6cfade45f40b1ad46025a81afe4cb8dd337
... which contains the commit 7be7e1ff95af485a9cb00748800d3d084f96387c in question.

I'll go ahead and mark this as a duplicate.
Thanks everyone!

*** This bug has been marked as a duplicate of bug 153437 ***