Bug 150333 - Text labels in About dialog became to have different size
Summary: Text labels in About dialog became to have different size
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: About-Dialog
  Show dependency treegraph
 
Reported: 2022-08-10 17:19 UTC by Roman Kuznetsov
Modified: 2023-05-18 06:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Scrrenshot with the problem (126.27 KB, image/png)
2022-08-10 17:20 UTC, Roman Kuznetsov
Details
How should About dialog looks (164.04 KB, image/png)
2022-08-10 17:27 UTC, Roman Kuznetsov
Details
Help -> About dialog with new font size changes, seem to have some padding issues (140.04 KB, image/png)
2022-08-10 23:09 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2022-08-10 17:19:36 UTC
Description:
Text labels in About dialog became to have different size

Steps to Reproduce:
1. Open About dialog
2. Look at the text there (look at the screenshot in attach also)


Actual Results:
Text labels in About dialog have different size

Expected Results:
Text labels in About dialog have the same size


Reproducible: Always


User Profile Reset: No



Additional Info:
I found it in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: d75c5c1f61a174b3b333e9db6536ab15cc37d00b
CPU threads: 4; OS: Mac OS X 12.5; UI render: Skia/Metal; VCL: osx
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded Jumbo

but in earlier 7.5 version I didn't see it => regression and I bisected it using mac64-7.5 bisect repo

I got SHA - 1bdd72e2d7f4cd5d438646a1ac1aeade9432ec96

https://gerrit.libreoffice.org/c/core/+/137618

Added to CC: Adolfo Jayme Barrientos
Comment 1 Roman Kuznetsov 2022-08-10 17:20:49 UTC
Created attachment 181690 [details]
Scrrenshot with the problem
Comment 2 Roman Kuznetsov 2022-08-10 17:27:22 UTC
Created attachment 181691 [details]
How should About dialog looks
Comment 3 V Stuart Foote 2022-08-10 18:00:17 UTC
Looks intentional, per see also?  => NAB ?  

Although the difference in font sizes seems a bit too much--IIUC in the commit [1] the larger is 110% the smaller are set 90%

Maybe tweak to a 105% and 95% split?

=-ref-=
https://gerrit.libreoffice.org/c/core/+/137618
Comment 4 Roman Kuznetsov 2022-08-10 18:07:54 UTC
(In reply to V Stuart Foote from comment #3)
> Looks intentional, per see also?  => NAB ?  

Looks ugly, if it was made intentional then please change it to back
Comment 5 V Stuart Foote 2022-08-10 18:17:51 UTC
(In reply to Roman Kuznetsov from comment #4)
> (In reply to V Stuart Foote from comment #3)
> > Looks intentional, per see also?  => NAB ?  
> 
> Looks ugly, if it was made intentional then please change it to back

Why, premise of the see also is valid. Just the delta between the primary and secondary/explanative labeling is a bit too large for the about dialog's aboutdialog.ui

I didn't look at the other labeling affected, but maybe elsewhere will need a tweak as well?
Comment 6 V Stuart Foote 2022-08-10 23:09:39 UTC
Created attachment 181695 [details]
Help -> About dialog with new font size changes, seem to have some padding issues

@Adolfo, the size 110% / 90% seems fine in this Windows build. But the total About dialog size and the padding seem a bit off.  Clip of recent master, 7.4.02 and a 7.3.5.2 install on the same system.
Comment 7 Adolfo Jayme Barrientos 2022-08-11 16:54:48 UTC
> Looks ugly

Roman, that was how others designed that dialog since version 4.0.x, IIRC, and I just restored that, so I don’t understand the knee-jerk reaction.

> Maybe tweak to a 105% and 95% split?

This won’t work; I had already tested that. I’ll just drop the 1.1 size increase.
Comment 8 Adolfo Jayme Barrientos 2022-08-11 17:08:57 UTC
… and will properly align the labels at the bottom; thanks for noticing Stuart!
Comment 9 Mike Kaganski 2023-05-18 06:55:46 UTC
(In reply to Adolfo Jayme Barrientos from comment #7)
> that was how others designed that dialog since version 4.0.x, IIRC,
> and I just restored that

This is not quite correct.
If you take a screenshot of About dialog from v.6.4, the last version that used the older layout, with the different font sizes, and a screenshot of the About dialog from, say, v.7.4, the last one using the fonts changed in the discussed patch, then you can compare the fonts by pixel. You can, e.g., copy a region with "This release was supplied by The Document Foundation.", used in the both, and put atop of the corresponding text on the other screenshot, and compare by pixel, to see that they are identical (completely identical) in size. So the *smaller* text prior to the 7.0 change was the same size as the whole text in 7.0+.

Now if you do the same comparison to 7.5, you see that the text decreases the size. This size had never been used, including 4.0, and so it is definitely not a restoration of a pre-existing design.

Also: I do not see a single complaint from any user about unsatisfactorily large font size in dialogs. I see complaints started arriving about the About dialog, the Function Wizard dialog, etc. The change, even if motivated by "let's restore an old design", needs at least "it does not make UX worse" justification.

If wanted, the restoration of the pre-7.0 design can only use numbers *larger* than 100%, and never smaller.