Bug 150385 - Track Changes: RTL becomes LTR when undoing deletion with track changes record enabled
Summary: Track Changes: RTL becomes LTR when undoing deletion with track changes recor...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTL-CTL Track-Changes
  Show dependency tree / graph
 
Reported: 2022-08-12 12:57 UTC by Telesto
Modified: 2023-01-18 05:46 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (19.13 KB, application/vnd.oasis.opendocument.text)
2022-08-12 12:58 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-08-12 12:57:57 UTC 
Description:
Track Changes: RTL becomes LTR when undoing deletion with track changes record enabled

Steps to Reproduce:
1. Open the attached file
2. CTRL+SHIFT + ARROW DOWN (5x)
3. Backspace
4. CTRL+Z

Actual Results:
Bullets start left

Expected Results:
Bullet right


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 86b2bfd34a4f07c54f03c8c8dfe48e0810834628
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2022-08-12 12:58:21 UTC 
Created attachment 181741 [details]
Example file
Comment 2 Telesto 2022-08-12 13:02:34 UTC 
Also in
Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Wrong bullet, but at the proper side with
Version: 6.3.7.0.0+ (x86)
Build ID: 726535ec30f12697ceccd2f0640d9371a64dc5bd
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 3 Telesto 2022-08-12 13:10:54 UTC 
See also bug 150386 for stuff for the large font size.
Comment 4 Telesto 2022-08-13 22:09:33 UTC 
@Eyal
FYI: I used a snipped of your document here.
Comment 5 Eyal Rozenberg 2022-08-13 22:21:48 UTC 
(In reply to Telesto from comment #4)
> @Eyal
> FYI: I used a snipped of your document here.

I'm not surprised. I've already gotten a lot of mileage out of that file - well over a dozen separate bugs (but I avoided posting the entire file so far and used reduced testcases).
Comment 6 Eyal Rozenberg 2022-08-13 22:24:58 UTC 
Can't reproduce using:

Version: 7.3.5.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Debian package version: 1:7.3.5~rc2-1
Comment 7 Eyal Rozenberg 2022-08-13 22:27:14 UTC 
Also, can't reproduce using:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 5c68399e6bea3aa18477487400f8bb143d6ed84e
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

finally, when you open a bug involving RTL, please have it block one of RTL-CTL, RTL-Hebrew, RTL-Arabic or RTL-UI (or other relevant named meta bug).
Comment 8 Telesto 2022-08-14 02:39:27 UTC 
1. Open the attached file
3. Place the cursor after the question mark in the heading
4. CTRL+SHIFT + ARROW DOWN (5x)
5. Backspace
6. CTRL+Z
Comment 9 Eyal Rozenberg 2022-08-14 07:06:16 UTC 
Reproduced with:

Version: 7.3.5.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Debian package version: 1:7.3.5~rc2-1

It's important that the cursor be placed after the question mark, not anywhere in the document.

Notes:

* Reproduction happens also when font-substituting Aharoni CLM for Aharoni.
* When deleting the backspace, the deleted text's font changes, on my system, to Choco 20pt rather than Aharoni 12pt like before the deletion. I often experience weird font fallback issues, this is another one of them, not sure if it's related to the direction change. When undoing the deletion, the font is again Aharoni, and just the direction is messed up.
Comment 10 Eyal Rozenberg 2022-08-14 07:06:46 UTC 
(In reply to Eyal Rozenberg from comment #9)
Also reproduced with:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 5c68399e6bea3aa18477487400f8bb143d6ed84e
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Calc: threaded
Comment 11 raal 2022-08-14 08:01:10 UTC 
At this commit is one of the bullets left aligned after the Undo c858d737ee8c13d155e115423b6f13f495c62a4c is the first bad commit
commit c858d737ee8c13d155e115423b6f13f495c62a4c
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Jun 24 13:32:29 2019 -0700

    source 705b728d26b4480ec6b51d9fe1362a0154ea9bf9
Comment 12 raal 2022-08-14 08:01:30 UTC Comment hidden (obsolete)