Bug 150431 - Word Completion: Delete button enabled with no selection
Summary: Word Completion: Delete button enabled with no selection
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: topicUI
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2022-08-16 06:17 UTC by Mike Kaganski
Modified: 2023-08-17 04:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-08-16 06:17:00 UTC
1. In a Writer document, make sure that Word Completion is enabled in Tools->AutoCorrect->AutoCorrect Options
2. Type some lengthy words (>= 8 characters by default, like "reasonable") to get them collected by Word Completion feature
3. Open Tools->AutoCorrect->AutoCorrect Options on Word Completion tab, see that there are collected words in the list, none of them selected, but the Delete button is enabled. Pressing on that button does not remove anything unless you select a word in the list.

The Delete button should be disabled whenever there's no selection.
Comment 1 BogdanB 2022-08-16 09:50:27 UTC
Confirmed with
Version: 7.5.0.0.alpha0+ (x86) / LibreOffice Community
Build ID: 550392aeb849b326aa0d5d84a0ec1d28d3d42503
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded
Comment 2 Mike Kaganski 2022-08-16 12:15:27 UTC
Code pointer: OfaAutoCompleteTabPage in cui/source/tabpages/autocdlg.cxx; it calls m_xPBEntries->set_sensitive only when the list is empty - the solution would be to implement a selection event handler for the list, and set sensitivity in it.
Comment 3 Telesto 2022-08-16 13:50:19 UTC
In my opinion the first entry should be preselected, instead of disabling the button and enabling it after some selection..

At the point you have selected some entry the collected word list, you can't leave without having something selected anyhow (except you delete every collected word)

---
Side-note: delete from list doesn't mean it being instantly applied. The word completion keeps suggesting the word deleted, until you quite LibreOffice and restart (see bug 67826)
Comment 4 Mike Kaganski 2022-08-17 07:31:16 UTC
(In reply to Telesto from comment #3)

Or that - would be even easier to implement :)