Bug 150433 - Add Thai thesaurus
Summary: Add Thai thesaurus
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: patch
Depends on: 148876
Blocks: Thesaurus
  Show dependency treegraph
 
Reported: 2022-08-16 08:41 UTC by Theppitak Karoonboonyanan
Modified: 2024-10-09 00:25 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Adding the Thai thesaurus data (40.68 KB, patch)
2022-08-16 08:44 UTC, Theppitak Karoonboonyanan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Theppitak Karoonboonyanan 2022-08-16 08:41:06 UTC
Description:
I would like to add Thai mythes thesaurus for LibreOffice, based on my contribution to the PyThaiNLP thai-synonym project [1], where the raw dataset is maintained and then generated for mythes with a script.

[1] https://github.com/PyThaiNLP/thai-synonym

The license is CC0 1.0.

Steps to Reproduce:
None.

Actual Results:
None.

Expected Results:
None.


Reproducible: Always


User Profile Reset: No



Additional Info:
None.
Comment 1 Theppitak Karoonboonyanan 2022-08-16 08:44:02 UTC
Created attachment 181801 [details]
Adding the Thai thesaurus data

The patch is diffed on top of my proposed patch in #148876.
Comment 2 Michael Warner 2022-08-31 21:41:12 UTC
Sounds good to me, marking as NEW.

However, since you already have the code downloaded, rather than attaching the patch files here, why not just push the patch to gerrit and create a review? It would get merged quicker that way.
Comment 3 Eike Rathke 2022-09-09 14:52:20 UTC
Apparently we don't have your license statement on file, could you
please send us a blanket statement that you contribute all your past and
future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev
mailing list libreoffice@lists.freedesktop.org so we can link to it from
https://wiki.documentfoundation.org/Development/Developers

Something like this does nicely:

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

Best use Subject: <your full name> license statement

Sorry for the inconvenience and thank you for cooperating :-)
Comment 4 Theppitak Karoonboonyanan 2022-10-27 03:22:07 UTC
(In reply to Michael Warner from comment #2)
> Sounds good to me, marking as NEW.
> 
> However, since you already have the code downloaded, rather than attaching
> the patch files here, why not just push the patch to gerrit and create a
> review? It would get merged quicker that way.

Thanks for the advice. I've just set up my gerrit account after a brief
learning. I'll make my first push soon.
Comment 5 Theppitak Karoonboonyanan 2022-10-27 03:40:19 UTC
(In reply to Eike Rathke from comment #3)
> Apparently we don't have your license statement on file, could you
> please send us a blanket statement that you contribute all your past and
> future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev
> mailing list libreoffice@lists.freedesktop.org so we can link to it from
> https://wiki.documentfoundation.org/Development/Developers
> 
> Something like this does nicely:
> 
> All of my past & future contributions to LibreOffice may be
> licensed under the MPLv2/LGPLv3+ dual license.
> 
> Best use Subject: <your full name> license statement
> 
> Sorry for the inconvenience and thank you for cooperating :-)

The license of this patch is specified in th_TH/README_thes_th_TH.txt
as CC-0 1.0, based on the data source it was converted from.

Of course, it could either be CC-0 as before to maintain its permissiveness,
or be relicensed to MPLv2/LGPLv3+ if required by the project.

In case it could be CC-0, would it conflict with my license statement
to always have my contributions be under MPLv2/LGPLv3+ dual license?
Or would it simply be overridden by the license statement in the patch?

In general, I prefer my future code contributions to be under MPLv2/LGPLv3+,
BTW, but the source of this one is such permissive.
Comment 6 Theppitak Karoonboonyanan 2023-03-20 09:30:38 UTC
The change has been pushed to gerrit for review:
https://gerrit.libreoffice.org/c/dictionaries/+/149147
Comment 7 Buovjaga 2024-06-24 17:22:44 UTC
(In reply to Theppitak Karoonboonyanan from comment #5)
> The license of this patch is specified in th_TH/README_thes_th_TH.txt
> as CC-0 1.0, based on the data source it was converted from.
> 
> Of course, it could either be CC-0 as before to maintain its permissiveness,
> or be relicensed to MPLv2/LGPLv3+ if required by the project.
> 
> In case it could be CC-0, would it conflict with my license statement
> to always have my contributions be under MPLv2/LGPLv3+ dual license?
> Or would it simply be overridden by the license statement in the patch?
> 
> In general, I prefer my future code contributions to be under MPLv2/LGPLv3+,
> BTW, but the source of this one is such permissive.

Grepping in the dictionaries repo I see others with CC-0 as well, so I will go ahead and merge the patch. You can then close this as fixed.
Comment 8 Commit Notification 2024-06-24 17:23:47 UTC
Theppitak Karoonboonyanan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/dictionaries/commit/fc2dc383a40e56c0118866c9110954bebc6ea41d

tdf#150433 Add Thai thesaurus
Comment 9 Theppitak Karoonboonyanan 2024-10-09 00:25:51 UTC
Closing the bug.