Bug 150435 - Track changes: reject changes after undo doesn't restore font formatting change
Summary: Track changes: reject changes after undo doesn't restore font formatting change
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency tree / graph
 
Reported: 2022-08-16 09:21 UTC by Telesto
Modified: 2024-08-23 19:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-08-16 09:21:54 UTC 
Description:
Track changes: reject changes doesn't restore font formatting change

Steps to Reproduce:
1. Open attachment 166349 [details]
2. Edit -> Track Changes -> Record (show ON)
3. Place the cursor after 3, in "Überschrift 3"
4. Press Delete (paragraph below getting the heading formatting)
5. Edit -> Track Changes -> Reject all

I suspect this to be caused by https://cgit.freedesktop.org/libreoffice/core/commit/?id=705b728d26b4480ec6b51d9fe1362a0154ea9bf9 (as in bug 150385)



Actual Results:
Formatting not undone

Expected Results:
Should be the case


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 86b2bfd34a4f07c54f03c8c8dfe48e0810834628
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
7.0.8
Comment 1 Dieter 2022-08-31 05:59:56 UTC 
Can't confirm with

Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 2 Telesto 2022-08-31 19:17:55 UTC 
(In reply to Dieter from comment #1)
> Can't confirm with

Hmm, you're right.. odd.. However, I do reproduce a similar issue with a different set of steps

1. Open attachment 166349 [details]
2. Toggle Track Changes Record ON: Edit -> Track Changes -> Record (Show also ON)
3. Place the cursor after 3, in "Überschrift 3"
4. Press Delete (paragraph below getting the heading formatting)
5. Edit -> Track Changes -> Reject all -> Fine
6. CTRL+Z
7. Edit -> Track Changes -> Reject all -> Wrong

Alternative
1. Open attachment 166349 [details]
2. Toggle Track Changes Record ON: Edit -> Track Changes -> Record (Show also ON)
3. Place the cursor after 3, in "Überschrift 3"
4. Press Delete (paragraph below getting the heading formatting)
5. Save the document
6. File -> Reload
7. Edit -> Track Changes -> Reject all
Comment 3 Dieter 2022-09-02 07:52:11 UTC 
(In reply to Telesto from comment #2)
> 1. Open attachment 166349 [details]
> 2. Toggle Track Changes Record ON: Edit -> Track Changes -> Record (Show
> also ON)
> 3. Place the cursor after 3, in "Überschrift 3"
> 4. Press Delete (paragraph below getting the heading formatting)
> 5. Edit -> Track Changes -> Reject all -> Fine
> 6. CTRL+Z
> 7. Edit -> Track Changes -> Reject all -> Wrong

I confirm this with

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 4 Buovjaga 2024-08-23 17:48:36 UTC 
Did some digging.

Before commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49 (bibisected with linux-64-6.2), the Heading style was not transferred to the paragraph after delete.

There was at least one other state after that, which I did not bother bibisecting, but the current state started with commit 66b39ca79b36da8d5e151deab17a0fb7690eebe6 (found in linux-64-7.0)
tdf#131147 don't store redline ExtraData during Undo