Bug 150471 - Freeze XXX commands in tabbed interface appear twice
Summary: Freeze XXX commands in tabbed interface appear twice
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.5.2 release
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2022-08-18 14:03 UTC by Rafael Lima
Modified: 2023-03-30 13:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (25.89 KB, image/png)
2022-08-18 14:03 UTC, Rafael Lima
Details
Screenshot of the proposed fix (21.83 KB, image/png)
2023-03-28 15:01 UTC, Rafael Lima
Details
Command name changed to Freeze Panes (18.26 KB, image/png)
2023-03-29 13:11 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-08-18 14:03:35 UTC
Created attachment 181854 [details]
Screenshot showing the problem

See attached image showing the View tab of Calc (using the Tabbed UI).

Notice that the "Freeze Rows and Columns" button already has "Freeze First Column" and "Freeze First Row" inside it, but still these commands appear again outside "Freeze Rows and Columns" in the same tab.

In my opinion we should only keep "Freeze Rows and Columns" and remove the other 2 instances that are duplicated.

System info

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: b707cd41c6ab9ba2b646d5a9aa8e187c620a82f2
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 1 Ezinne 2022-08-19 07:19:35 UTC
Reproducible in:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a9d225df2f8772e21435523ca20df1ece37390e4
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: pt-BR (en_NG); UI: en-US
Calc: threaded
Comment 2 Heiko Tietze 2022-08-22 09:25:51 UTC
"Freeze Rows and Columns" (.uno:FreezePanes) makes the selection sticky while "Freeze First Column/Row" (.uno:FreezePanesColumn/.uno:FreezePanesRow) applies to the first column/row only. But I admit, it's a bit awkward to cramp every command into the UI. If we remove one of the options we have to provide some access to it, eg. via drop down menu.
Comment 3 Heiko Tietze 2022-08-26 07:38:16 UTC
The topic was on the agenda of the design meeting but didn't receive further opinions. My recommendation: Drop the "Freeze Rows and Columns" (.uno:FreezePanes), at least as first and most prominent control, and keep the two other. Whether toolbar or notebookbar, it should provide quick access to functions - and more options with secondary access methods.
Comment 4 Justin L 2022-08-26 11:43:49 UTC
(In reply to Heiko Tietze from comment #3)
>  My recommendation: Drop the "Freeze Rows and Columns"
My reaction was the opposite. Drop the very specific/limiting "freeze first" choices and keep the generic "Freeze Rows and Columns" that can accomplish everything desirable by the user.
Comment 5 Rafael Lima 2023-03-28 15:01:30 UTC
Created attachment 186262 [details]
Screenshot of the proposed fix

Proposed patch here:

https://gerrit.libreoffice.org/c/core/+/149650

I've attached a screenshot of how it looks like with the patch.
Comment 6 Heiko Tietze 2023-03-29 09:02:02 UTC
(In reply to Rafael Lima from comment #5)
> Created attachment 186262 [details]
> Screenshot of the proposed fix

Can you change the label so it wont occupy that much space?
Comment 7 Rafael Lima 2023-03-29 13:11:51 UTC
Created attachment 186286 [details]
Command name changed to Freeze Panes

How about this? I changed the command label to "Freeze Panes", which is also the name of the Uno command (".uno:FreezePanes")

I should disclose that this is also the label used in MSO.
Comment 8 Heiko Tietze 2023-03-29 13:16:46 UTC
(In reply to Rafael Lima from comment #7)
> How about this?

Much better. If you changed the UNO command please double-check how it is used in the UI.
Comment 9 Rafael Lima 2023-03-29 13:38:11 UTC
(In reply to Heiko Tietze from comment #8)
> If you changed the UNO command please double-check how it is used in the UI.

I did that. The only place where it looked odd was in the View menu (using the menubar).

To fix that, I set the command Label as "Freeze Panes" (which is what we see in the Tabbed UI), but set the command ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns".
Comment 10 Commit Notification 2023-03-30 13:28:47 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04ed7cbe53243a042ceeecc62212e73a910d7aef

tdf#150471 Remove duplicated Freeze commands from the Tabbed UI

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.