Bug 150690 - "Mac OS X Address Book" should be renamed
Summary: "Mac OS X Address Book" should be renamed
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: macOS-UI-polish
  Show dependency treegraph
 
Reported: 2022-08-30 16:50 UTC by Tuomas Hietala
Modified: 2023-10-23 13:24 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2022-08-30 16:50:42 UTC
Description:
In LO, there's a UI string "Mac OS X Address Book":
https://translations.documentfoundation.org/translate/libo_ui-master/connectivityregistrymacaborgopenofficeofficedataaccess/en/?checksum=57b42d1d36e83fbd

As mentioned in the comments in Weblate, this functionality might not work any more. However, if it's still relevant, the string should be renamed, because Apple operating systems old enough to be called "OS X" are not supported by LO any more.

Steps to Reproduce:
1. Go to https://translations.documentfoundation.org/translate/libo_ui-master/connectivityregistrymacaborgopenofficeofficedataaccess/en/?checksum=57b42d1d36e83fbd

Actual Results:
The string "Mac OS X Address Book" is used.

Expected Results:
The string is updated to the macOS era or the functionality is removed.


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a
Comment 1 Alex Thurgood 2022-08-31 12:50:33 UTC
The functionality works with:

Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Mac OS X 12.5.1; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

so it shouldn't be removed (it was non-functional for quite a while though, but this was fixed in the meanwhile).

Agree with renaming though.
Comment 2 Tuomas Hietala 2022-09-08 09:16:14 UTC
Good to know. Is the functionality still called "Address Book", or has the name changed?
Comment 3 Alex Thurgood 2022-09-09 07:43:46 UTC
AFAICT, the functionality is still called "Address Book", e.g., the following menus :


File > Wizards > Address Datasource > Address Book Type > "Mac OS X address book"

File > New > Database > Connect to an existing database > "Mac OS X address book"

(Writer) Tools > Address Book Source
Comment 4 ⁨خالد حسني⁩ 2023-03-25 21:45:47 UTC
The Address Book app of Mac OS X seems to be called contacts now, so the proper name now is probably macOS Contacts. Should I simply rename it or is there any other implications?
Comment 6 Alex Thurgood 2023-10-23 13:24:15 UTC
(In reply to Tuomas Hietala from comment #5)
> This seems to have been fixed in master:
> 
> https://translations.documentfoundation.org/translate/libo_ui-master/
> connectivityregistrymacaborgopenofficeofficedataaccess/en/
> ?checksum=141ca7d62053cbc1

Indeed it is, thanks for checking.