Bug 150823 - Track changes: list of > 20 registered changes; vanishing after rejecting one change
Summary: Track changes: list of > 20 registered changes; vanishing after rejecting one...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.6.0 target:7.5.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2022-09-06 12:40 UTC by Telesto
Modified: 2023-01-24 10:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (9.50 KB, application/msword)
2022-09-06 12:41 UTC, Telesto
Details
BUG 150823 (100.13 KB, application/vnd.oasis.opendocument.text)
2022-09-11 07:15 UTC, Jegatheesan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-09-06 12:40:29 UTC
Description:
Track changes: list of > 20 registered changes; vanishing after rejecting one change

Steps to Reproduce:
1. Open the attached file
2. Make sure track changes record being enabled
3. Place cursor at the end of the line
4. Press and hold backspace until everything being deleted
5. Edit -> track changes -> Manage 
6. Press reject change a single time

7. File > Reload
8. Make sure track changes record being enabled
9. Place cursor at the end of the line
10. Press and hold backspace until everything being deleted
11. CTRL+Z
12. CTRL+Y
13. Edit -> track changes -> Manage -> Single entry 

Actual Results:
List of maybe 20 entry's.

Expected Results:
I guess it should be one entry all the time


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc92a4d973086ce8a6a5f75ba0f4d4c9ca05537a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2022-09-06 12:41:01 UTC
Created attachment 182258 [details]
Example file
Comment 2 Telesto 2022-09-06 12:41:55 UTC
Still fine with
Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 3 Jegatheesan 2022-09-11 07:15:41 UTC
Created attachment 182370 [details]
BUG 150823

NOT REPRODUCED:

Description:
Track changes: list of > 20 registered changes; vanishing after rejecting one change

Steps to Reproduce:
1. Open the attached file
2. Make sure track changes record being enabled
3. Place cursor at the end of the line
4. Press and hold backspace until everything being deleted
5. Edit -> track changes -> Manage 
6. Press reject change a single time

7. File > Reload
8. Make sure track changes record being enabled
9. Place cursor at the end of the line
10. Press and hold backspace until everything being deleted
11. CTRL+Z
12. CTRL+Y
13. Edit -> track changes -> Manage -> Single entry 

I do the above steps and check the final result and its show the single entry instead of 20 registered changes and bug is solved and works fine.
Comment 4 Jegatheesan 2022-09-11 07:20:45 UTC
the above bug check with below version

ENVIRONMENT: Liber Office 7.4.0.0 alpha linux Mint 21.2
Comment 5 Stephen Reginold 2022-09-11 10:42:56 UTC
Created attachment 182370 [details]
BUG 150823

NOT REPRODUCED:

Description:
Track changes: list of > 20 registered changes; vanishing after rejecting one change

Steps to Reproduce:
1. Open the attached file
2. Make sure track changes record being enabled
3. Place cursor at the end of the line
4. Press and hold backspace until everything being deleted
5. Edit -> track changes -> Manage 
6. Press reject change a single time

7. File > Reload
8. Make sure track changes record being enabled
9. Place cursor at the end of the line
10. Press and hold backspace until everything being deleted
11. CTRL+Z
12. CTRL+Y
13. Edit -> track changes -> Manage -> Single entry 

I do the above steps and check the final result and its show the single entry instead of 20 registered changes and bug is solved and works fine.

the above bug check with below version

ENVIRONMENT: Liber Office 7.4.0.0 alpha linux Mint 21.2
Comment 6 raal 2022-09-17 20:44:18 UTC
Hello Telesto,
I suppose you provided two sets of steps of one bug: 1-6 and 7-13
1. Open the attached file
2. Make sure track changes record being enabled
3. Place cursor at the end of the line
4. Press and hold backspace until everything being deleted
5. Edit -> track changes -> Manage 
6. Press reject change a single time

--> now there is lots of entries in Manage changes dialog. Is this the bug you have at mind? I can confirm it.

The second steps 7-13 seems to be fixed in LO 7.5

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: e46f9cc4b506c325cbe1060777bbc81fd1630f49
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 7 raal 2022-09-17 20:57:07 UTC
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
Thanks
 3a18e777db90da2eae71753e96b24415239c7596 is the first bad commit
commit 3a18e777db90da2eae71753e96b24415239c7596
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Aug 17 14:17:40 2022 +0200

    source 7d730cd580e957ab06b0c7f020ac37dd0c337aa2

https://git.libreoffice.org/core/+/7d730cd580e957ab06b0c7f020ac37dd0c337aa2
Comment 8 Commit Notification 2022-12-20 16:54:43 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5cd8ea4d8a4fa8c5ac8e28be8fbc240caf070ff4

tdf#150823 sw: merge delete redlines in same paragraph

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Michael Stahl (allotropia) 2022-12-20 16:55:42 UTC
fixed on master
Comment 10 Commit Notification 2022-12-20 18:52:54 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0644c90edb4ccb1395c3b78668acc32d857b4d91

tdf#150823 sw: merge delete redlines in same paragraph

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-01-17 13:54:32 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/bdef7bbcd9e51f1272b006962c17ca0b2493205a

tdf#150823 sw: merge delete redlines in same paragraph

It will be available in 7.4.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Xisco Faulí 2023-01-24 10:36:21 UTC
7.4.5 was a hotfix release, updating target in status-whiteboard