Bug 150994 - Rename the "Quotations" paragraph style
Summary: Rename the "Quotations" paragraph style
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0
Keywords: difficultyMedium, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Writer-Styles-Page
  Show dependency treegraph
 
Reported: 2022-09-16 13:57 UTC by Tuomas Hietala
Modified: 2023-05-04 17:47 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (444.23 KB, image/png)
2023-05-04 16:12 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2022-09-16 13:57:49 UTC
Description:
The "Quotations" paragraph style in Writer should correctly be in singular (i.e. "Quotation") like the rest of the style names. (Quotation marks or "quotes" (plural) are the characters delimiting a quotation or "quote" (singular)). However, there is a already a character style called "Quotation" which could cause confusion.

I suggest the "Quotations" paragraph style be renamed to "Block Quotation", which would reduce the risk of confusion and explain better to the user what the style is intended for.

See https://en.wikipedia.org/wiki/Block_quotation


Steps to Reproduce:
1. See the Styles menu in Writer

Actual Results:
There are styles called "Quotations" and "Quotation".

Expected Results:
The styles have distinct and descriptive names.


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a
Comment 1 Eyal Rozenberg 2022-09-16 15:35:23 UTC
(In reply to Tuomas Hietala from comment #0)
> I suggest the "Quotations" paragraph style be renamed to "Block Quotation",
> which would reduce the risk of confusion and explain better to the user what
> the style is intended for.

I support this, but would like to bikeshed here a little:

* Block quotation
* Block quote
* Blockquote

are all decent choices. Personally I support "Blockquote".
Comment 2 Regina Henschel 2022-09-16 16:16:49 UTC
I support this. For wording I would follow Wikipedia, which uses "Block quotation"
https://en.wikipedia.org/wiki/Block_quotation
Comment 3 Heiko Tietze 2022-09-19 09:09:02 UTC
So let's go with "Block quotation".

Essentially "easy hackable", but the term is annoyingly spread over the code. So medium difficult without a code pointer ;-)
Comment 4 Rafael Lima 2023-04-25 14:11:42 UTC
Proposed patch here

https://gerrit.libreoffice.org/c/core/+/150973
Comment 5 Commit Notification 2023-05-04 06:34:54 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e265a6e016e3ec8818ba49351ca5a4dcb8b67d72

tdf#150994 Rename Quotations to Block Quotation

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 BogdanB 2023-05-04 16:12:03 UTC Comment hidden (obsolete)
Comment 7 BogdanB 2023-05-04 16:13:17 UTC
(In reply to BogdanB from comment #6)
> Created attachment 187085 [details]
> screenshot
> 
> Rafael, I have the latest master, your commit is in the list, but I can not
> see it applied. See screenshot.

Sorry, it's paragraph style.
It's ok, you can mark as Resolved.
Comment 8 Rafael Lima 2023-05-04 17:18:11 UTC
I've just checked it again and the paragraph style is indeed now named "Block Quotation".

Checked with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fa0c012d6c06e9a92093dacf997fe3151272648e
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

Setting as FIXED.
Comment 9 BogdanB 2023-05-04 17:47:17 UTC
Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fa0c012d6c06e9a92093dacf997fe3151272648e
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded