Bug 151066 - [SAVING][UI] Tabbed toolbar Data Loss after file Reload; icons don't work either
Summary: [SAVING][UI] Tabbed toolbar Data Loss after file Reload; icons don't work either
Status: RESOLVED DUPLICATE of bug 126006
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.6.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, dataLoss, regression
Depends on:
Blocks: Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2022-09-19 18:01 UTC by jebsolutions
Modified: 2023-06-29 16:14 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jebsolutions 2022-09-19 18:01:52 UTC
Description:
Summary: 

After file-> reload the Calc save icon no longer gets updated on document change.  I.e. it still looks like a disk instead of a disk with a red circle in the top right corner. 

Note: this is only broken in Calc, but works fine in Impress and Writer.

As a user, this gives the impression that Libreoffice may lose your important changes.

Steps to Reproduce:
Open an existing .ods document in Calc.
Click into any cell (e.g. A4).  
Type in anything randomly e.g. "abcd".  
Click in any another cell to stop editing the cell.
From the File Menu select File->Reload
Cancel All changes?  Click Yes.
Click in any cell (e.g. A10)
Type in anything randomly e.g. "adflkjsdaflkjsdf".  
Click in any another cell to stop editing the cell.


Actual Results:
The save icon is still a plain disk without the red circle!  There is no visual indication that the document has been changed.

The save icon status is permanently broken at this point.  The only way to get it working again for this document is to close and then reopen the document.


Expected Results:
How to duplicate:
Open an existing .ods document.
Click into any cell (e.g. A4).  
Type in anything randomly e.g. "abcd".  
Click in any another cell to stop editing the cell.
From the File Menu select File->Reload
Cancel All changes?  Click Yes.
Click in any cell (e.g. A10)
Type in anything randomly e.g. "adflkjsdaflkjsdf".  
The save icon will have a red circle to indicate the document has be changed but not saved.




Reproducible: Always


User Profile Reset: No



Additional Info:
Wile Calc is in this state the broken save icon only affects the currently open document.  I.e. if I have another calc document open (that hasn't been reloaded) it's save icon continues to properly shows the red circle "changed and not saved yet" state.

As a user, this gives the impression that Libreoffice may lose my important changes.
Comment 1 m_a_riosv 2022-09-19 20:59:44 UTC
Works for me
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bfb0dbee201a69c26293947c78356f320ff62a0b
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Version: 7.3.6.2 (x64) / LibreOffice Community
Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 2 Rafael Lima 2022-09-19 21:38:52 UTC
What icon theme are you using? This may be related to a specific icon theme.

To see that, go to Tools - Options - View and see which option is selected in Icon Theme (or Icon Style)
Comment 3 QA Administrators 2023-03-20 03:27:04 UTC Comment hidden (obsolete)
Comment 4 ady 2023-03-20 08:49:58 UTC
I am changing the status from NEEDINFO to NEW, in spite of not being the original reporter.

This issue is not just about some icon theme. This is data loss! Not just by some user mistake, but because of Calc.

0. After reloading and performing some change, the "save" icon doesn't change.
1. I know I made a change after reloading, so I click the icon to save.
2. Reload. There is still the warning about loosing data.
3. Since I just saved already, I think "unneeded question" and click "yes".
4. Data loss, because when I clicked the icon in step 1, the data was not really saved!!!

I can also reproduce similar other icons that don't really act. For example, click the icon to wrap text on a cell of file that was opened works OK; but click on it when the file was reloaded and the attribute is not really applied. So, the Wrap Text icon is not showing the change, but in the current situation (file reloaded) the icon is correct, because the attribute is not really applied.

Similarly, the "save" icon is correct, because there was not change registered by Calc. The icon is correctly showing that Calc has no clue that something (content or attribute in cell) has changed, so there is "nothing to save", except there is!

IOW, DATA LOSS.

This might deserve a higher priority or higher importance, even when the data loss might happen on reloaded files only.

The subject of this report might also deserve some adjusting.
Comment 5 ady 2023-03-20 10:51:52 UTC
Additional testing reveals that in LO 7.0.0.3 the same actions I described in comment 4 produced crashes when the file was reloaded. This might point to some reason for these to be (accidentally?) disabled.

In some older version these actions used to work OK. Regression.
Comment 6 Maxim Monastirsky 2023-03-20 11:42:08 UTC
I think this depends on the UI used. I can reproduce this with the Tabbed interface, but not with Standard Toolbars. Many other buttons of the Tabbed interface (e.g. Bold, Paste) are also broken after reload.
Comment 7 ady 2023-03-20 13:52:08 UTC
(In reply to Maxim Monastirsky from comment #6)
> I think this depends on the UI used. I can reproduce this with the Tabbed
> interface, but not with Standard Toolbars. Many other buttons of the Tabbed
> interface (e.g. Bold, Paste) are also broken after reload.

After reloading and performing some change...

I just tested it, and yes, the ST saves and the Save icon changes to show the red corner and it also actually saves.

OTOH, in the Tabbed Toolbar the icon does not change to indicate that there are pending changes to be saved, and it doesn't save either. Same with other buttons, they don't work.

Besides the several failures when using the Tabbed Toolbar (e.g. bug 140557 and its dups / See also), the most important item in this report is the data loss!
Comment 8 ady 2023-03-20 19:03:58 UTC Comment hidden (obsolete)
Comment 9 Heiko Tietze 2023-03-27 12:15:32 UTC
No question from UX side, the save state indication needs to be updated for all controls on reload (and any related actions). The standard toolbar works for me for both, classic and tabbed UI on macOS.
Comment 10 ady 2023-03-27 19:59:19 UTC Comment hidden (obsolete)
Comment 11 Justin L 2023-06-29 16:14:04 UTC

*** This bug has been marked as a duplicate of bug 126006 ***