Created attachment 182558 [details] Adwaita (top, latest as current bug written) vs Sifr (below) The Sifr icon theme was historically an advanced derivative version of the GNOME icon theme which is now known as Adwaita. GNOME UI has evolved a lot, including in this case its icon themes. Currently the symbolic version of Adwaita's icon theme has a rounded look, but still retains its cuteness. Meanwhile Sifr still maintains a look that has sharp corners. Apart from that, in many ways, it seems to me personally that it is not harmonious, tends to be childish and messy. This bug report intends to suggest a change in Sifr, so that it follows the rhythm that is sung by Adwaita.
We can see the change history in Adwaita here https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/commits/master?search=symbolic%3A+round
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/39addcb4de4c3033adfd4155de2a79c7633aaf9a tdf#151071 Revise Sifr to follow upstream It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f0a36babf2ef1384666705697f91e7ff4166f4e4 tdf#151071 Revise Sifr, remove duplicate and missplaced icons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90861cc6f815b3f34edb88d47afed0d1099e72e7 tdf#151071 Revise Sifr, tidy up links.txt, remove duplicate It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/00c5b0ca9264c5440bc70a68c425127ba5a47003 tdf#151071 Revise Sifr, tidy up links.txt, remove already declared icons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'm personally satisfied with the changes, mostly everything looks, if not adwaita-compliant, at least more nice looking. With two exceptions; - At least the icon colors should be compliant to Adwaita icons in order to create good contrast between icons and backgrounds. Colors should be: > For Active Dark: White #ffffff ( 255, 255, 255 ) > For Active White: #323232 ( 50, 50, 50 ) > For Both Inactive White and Dark this should be fine: #969696 ( 150, 150, 150 ) I picked the colors through screenshots of GNOME Settings/Nautilus. And they seem reasonable.
Forgot to mention; some Sifr icons include a second shade of gray. For those secondary shades the colors can be those: > For Sifr Dark (secondary color): #737373 ( 115, 115, 115 ) > For Sifr Light (secondary color): #a0a0a0 ( 160, 160, 160 ) I have to admit that only the first 2 colors are exactly the ones found in libadwaita apps. The other three approximate the "official" colors. I recommend those precise color codes.
(In reply to Galdam Jitsu from comment #6) > I'm personally satisfied with the changes, mostly everything looks, if not > adwaita-compliant, at least more nice looking. With two exceptions; Thanks geeko > - At least the icon colors should be compliant to Adwaita icons in order to > create good contrast between icons and backgrounds. Colors should be: > > > For Active Dark: White #ffffff ( 255, 255, 255 ) complete or pure white color is not design-wise, should be avoided. Here a quote which was quoted in https://graphicdesign.stackexchange.com/questions/25356/why-not-use-pure-black-000-and-pure-white-fff: "Simply put, contrast is the difference between two colors. On a web page, the amount of contrast required varies with different parts of the page. You usually want a high contrast between text and its background color. But too high contrast between design elements might give an unsettled and messy impression. Black and white create the highest contrast possible." > > For Both Inactive White and Dark this should be fine: #969696 ( 150, 150, 150 ) Icon theme have no control against inactive color, it's a question to code part. I don't understand this one
(In reply to Galdam Jitsu from comment #7) > Forgot to mention; some Sifr icons include a second shade of gray. For those > secondary shades the colors can be those: > > > For Sifr Dark (secondary color): #737373 ( 115, 115, 115 ) > > For Sifr Light (secondary color): #a0a0a0 ( 160, 160, 160 ) > They are not grey, rather they have same color code particular to dark/light version but with 35% opacity. You can always check my information by opening images_sifr_svg.zip or images_sifr_dark_svg.zip from the repo, or clone my repo if you want smaller size: https://github.com/rizmut/libreoffice-style-sifr
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ca78fe4dc72a4cd3737e4da9af888783d52285c7 tdf#151071 Revise Sifr including RoK locale icons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a6abe4a33568d87904fd49c734af4726878af421 tdf#151071 Revise Sifr (Sheet, wizard etc) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c2f8a1676c36e3045588e52545fb25062076dae tdf#151071 Revise Sifr (Pivot Table, Table actions, autowizard etc) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1f7b050d83966b51e0b22de9b565bf4ceacdad16 tdf#151071 Revise Sifr (too lazy to mention) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/100dc387ffd7df84199dae51abd9de35440905f1 tdf#151071 Revise Sifr (table & data action) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ebf1ca2b696c800071a8c000a9715fdaa911c15 tdf#151071 Revise Sifr (object align, small icons with cursor, accent style) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7e19bde57c825f361304e9bce1d3929995ee7ddd tdf#151071 Revise Sifr: DB Query, DBReport, Freeze Pane, Go To Page, etc) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dc3a6485b67ca0996803e3799faa76a11cddb46a tdf#151071 Revise Sifr: Legend, Reset Filter, Import Slide) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e86d7b19760e47d2b1a707c2085ed56be2afa4ad tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4a2a94d3f41bfcf13ca96027e0bb266a429a56c7 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/07caa3c6e9b6b554ed0989fb5a3b8aefedeb25a6 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7cf5360ac4e70060e53a34608290cf6af7fa1ca1 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be4c4c3189789c81ac8be9a15ce7e132cdf3b53b tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1754b02e6acd5d0c03bdcf46151d166a07806506 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/286347aec204e062e47842b7d62d734fa8513d79 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a7683a16e98def4198e1f74a93fecdaacbf639e7 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8e8523018d7824aeefe654926c62b2fd49429e41 tdf#151071 Revise Sifr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f486d2220d5b51f422c8feca21c831e1c1d143d7 tdf#151071 Revise Sifr (Impress display view, slide layout & transition) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0f2bec39d5d90ec7f0879e57ff5b23d671bf8489 tdf#151071 Revise Sifr (Update color to follow symbolic Adwaita) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I want to revert the merged change. Especially, correctly Sort ascending ㄱㅎand correctly sort decsendingㅎㄱ (That author doesn't understand Korean Hangul, made a new character that is not in Hangul.) I was strongly busy for a while, so I couldn't review the gerrit link. So, I will check about Korean Hangul icons from next week.
Created attachment 183014 [details] Example of Sort ascending ㄱㅎ and sort decsendingㅎㄱ on MS Excel 2019 Example of Sort ascending ㄱㅎ and sort decsendingㅎㄱ on MS Excel 2019 Look at the example screenshot in MS Excel 2019 and recreate the ascending ㄱㅎ and descending order ㅎㄱ .
Created attachment 183015 [details] Example of reset attributes icon on MS Word 2019 Example of reset attributes icon 가(ga) on MS Word 2019. Look at the example screenshot in MS Excel 2019 and recreate to reset attributes icon 가(ga).
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dba6eb60bcd9f55b49699e767993707ec26a8565 tdf#151071 Sifr fix Korean Sort icons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/93cf1bc5e7495e0e2741451f7b564a6386e9b64d tdf#151071 Revise Sifr to follow upstream (Track Change, Capitalization) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ee7e5aff70e2aefe49e781eb74d3f61d99d857a8 tdf#151071 Revise Sifr to follow upstream It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b32e1cd0496c36c4f6cb783bf8bd21b4ad234738 tdf#151071 Revise Sifr to follow upstream (Navigator) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/66940d33b7098d6709ff83917ae1575c691c54ab tdf#151071 Sifr follow upstream: Form Control, Record, Cell Styles, Shadow It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fix verified with Sifr SVG dark in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Rizal! :)