Bug 151084 - Track Changes: Wrong number of changes in manage changes dialog after deleting a word with comment inside (correct after saving as odt and reload)
Summary: Track Changes: Wrong number of changes in manage changes dialog after deletin...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes Writer-Comments
  Show dependency treegraph
 
Reported: 2022-09-20 13:30 UTC by Telesto
Modified: 2023-01-23 17:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (9.46 KB, application/vnd.oasis.opendocument.text)
2022-09-20 13:30 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-09-20 13:30:00 UTC
Description:
Track Changes: difference in number of changes in manage changes dialog before saving & after save and reload

Steps to Reproduce:
Case ODT
1. Open the attached file
2. Delete the comment
3. Place cursor after "cdba"
4. Press backspace
5. Edit -> track changes -> Manage > 4 entry's
6. Close the dialog
7. Save the file
8. File -> Reload
9. Edit -> track changes -> Manage > 3 entry's

Case DOCX 
1. Open the attached file
2. Delete the comment
3. Place cursor after "cdba"
4. Press backspace
5. Edit -> track changes -> Manage > 4 entry's
6. Close the dialog
7. Save as DOCX
8. File -> Reload
9. Edit -> track changes -> Manage > 1 entry's

Actual Results:
3 Entry's with ODT
1 Entry with DOCX

Expected Results:
I kind of expect the number of changes to be consistent. So or more steps need to be saved/imported. Or those steps should be visible in the manage dialog while editing either 


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc92a4d973086ce8a6a5f75ba0f4d4c9ca05537a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

only a single (merged) entry in all cases with:
Version: 6.4.0.0.beta1+ (x64)
Build ID: e75dd1fc992f168f24d66595265a978071cdd277
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2022-09-20 13:30:25 UTC
Created attachment 182573 [details]
Example file
Comment 2 Dieter 2022-10-08 09:45:06 UTC
I confirm it with

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c3b5eea4304ad6815b491f549fce008a9630c213
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded


4 entries in manage changes
- deletion of "c"
- deletion of "d"
- deletion of comment
- deletion of "ba"

3 entries after save as odt and reload
- deletion of "cd"
- deletion of comment
- deletion of "ba"

1 entry after save as docx and reload

BUT also 3 entries after saving final document of odt case as docx.

So very clear, that 3 entries is expected result and result after step 5 (4 entries is wrong). So I changed bug summary and hope you agree, Telesto.
Comment 3 Stéphane Guillou (stragu) 2023-01-23 16:13:54 UTC
I understand step 4 to be "Press Ctrl + Backspace" in order to delete the whole "cdba" word.

On both Windows 10 and Ubuntu 20.04, with a master build from today, I get
- ODT: 3 entries before and after saving
- DOCX: 3 entries before, 1 entry after (comment delete action is lost) 

So looks like the ODT situation is WORKSFORME, and that DOCX loses the comment delete action, which si already talked about in bug 108791 and bug 105485.
Marking as WFM but please do double-check.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1c638b7ac46d8077994c8483e6becc4a33efd12b
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cd20a17ab703e97191b4e3421527267ef82a704f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 4 Stéphane Guillou (stragu) 2023-01-23 17:15:17 UTC
Hm maybe I'll keep this open, as we still expect a total of 2 actions, not 3:
1. comment deleted
2. word deleted

Good to have consistency, but ideally that single Ctrl + Backspace action should be counted as one event.