Bug 151325 - Show Whitespace doesn't work in this ODT
Summary: Show Whitespace doesn't work in this ODT
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Show/Hide-Whitespace
  Show dependency treegraph
 
Reported: 2022-10-04 12:18 UTC by Timur
Modified: 2022-11-29 08:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2022-10-04 12:18:52 UTC
Open attachment 126378 [details]. 
Since it's 1 page ODT, add some text and page break to make it 3 pages. 
Try to change View-Show Whitespace.

Experienced: doesn't change
Expected: to work 

Repro with 7.5+. With older LO like 6.0, command was disabled on fileopen, which is also NOK in this bug, although better than now.
Comment 1 Dieter 2022-10-19 06:11:22 UTC
I confirm it with

Version: 7.4.1.2 (x64) / LibreOffice Community
Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Tested also in Safe Mode. But as far as I can see, you don't have to add any text or pages. Changing "Show Whitespace" doesn't work with the document as it is.
Comment 2 Aron Budea 2022-11-24 21:29:57 UTC
The help says:

Hiding whitespace is only possible in Single-page view.
https://help.libreoffice.org/latest/lo/text/swriter/01/show_whitespace.html

The document is in Multiple-page view, and the setting works for me after switching to Single-page view. Timur, does that make it work for you?
Comment 3 Dieter 2022-11-25 09:10:25 UTC
Aaron, you're right of course
=> RESOLVED NOTABUG
Comment 4 Aron Budea 2022-11-25 09:25:44 UTC
On a sidenote, the menu item became active with the following commit in 7.0, the fix to bug 124686.

One could argue the menu should be disabled when the function does nothing, and that might still be considered a bug.
Heiko, can you please share your opinion?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=96def0ee391a99ddf042df820db1292b83d0c4fe
author		shameempk <mailtoshameempk@gmail.com>	2020-03-11 12:01:28 +0000
committer	Miklos Vajna <vmiklos@collabora.com>	2020-03-30 09:36:37 +0200

tdf#124686 HideWhiteSpace should be positive Show Whitespace
Comment 5 Dieter 2022-11-25 09:31:34 UTC
(In reply to Aron Budea from comment #4)
> One could argue the menu should be disabled when the function does nothing,
> and that might still be considered a bug.
> Heiko, can you please share your opinion?

I won't call it a regression, because it's the intended behaviour. And if change behaviour again, it won't sslve the problem reported here. But enhancement request in bug 98446 provides a possible solution for this problem.
Comment 6 Heiko Tietze 2022-11-28 15:26:59 UTC
(In reply to Aron Budea from comment #4)
> Heiko, can you please share your opinion?

Do you talk about the main menu "View > [x] Show Whitespace", which works for me, or something else?
Comment 7 Aron Budea 2022-11-28 16:09:43 UTC
(In reply to Heiko Tietze from comment #6)
> Do you talk about the main menu "View > [x] Show Whitespace", which works
> for me, or something else?
Yes, that.

What I see:
1. after opening the file, View -> Show Whitespace is unticked,
2. added two page breaks to get a 3-page document,
3. after ticking View -> Show Whitespace, there's no difference,
4. switched to Single-page View,
5. after unticking View -> Show Whitespace, the 3-page document is shown on one page.

The bug is that step 3 does nothing, either the menu should be disabled when it has no effect, or it should have an effect.

(In reply to Dieter from comment #5)
> I won't call it a regression, because it's the intended behaviour. And if
> change behaviour again, it won't sslve the problem reported here. But
> enhancement request in bug 98446 provides a possible solution for this
> problem.

Fair enough, that seems like a reasonable solution.
Comment 8 Heiko Tietze 2022-11-29 08:36:13 UTC
I see, and of course you can hide white-space only in standard view mode. Either the suggestion at bug 98446 or we disable the command (which in turn would be not so easy to understand).