Bug 151527 - No icons for Fontwork dialog in dark mode
Summary: No icons for Fontwork dialog in dark mode
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: Icon-Themes Icon-Theme-Breeze Icon-Theme-Sifr
  Show dependency treegraph
 
Reported: 2022-10-14 12:35 UTC by Rafael Lima
Modified: 2022-10-17 19:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem (using sifr icons) (24.91 KB, image/png)
2022-10-14 12:35 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-10-14 12:35:34 UTC
Created attachment 183046 [details]
Screenshot of the problem (using sifr icons)

See attached screenshot for more information.

When you open the Fontwork dialog there are no dark variants, so the dialog becomes very hard to see.

Tested with sifr (dark) and breeze (dark) in latest master.

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 7fc96ad09520abea4833ed7410fd3a2d1b63d7b1
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Rafael Lima 2022-10-14 12:36:49 UTC
@Rizal can you please take a look at this one?
Comment 2 Jean-Baptiste Faure 2022-10-16 15:57:03 UTC
(In reply to Rafael Lima from comment #0)
> Created attachment 183046 [details]
> Screenshot of the problem (using sifr icons)
> 
> See attached screenshot for more information.
> 
> When you open the Fontwork dialog there are no dark variants, so the dialog
> becomes very hard to see.

How do you open this dialog ?

Best regards. JBF
Comment 3 Rafael Lima 2022-10-16 18:56:04 UTC
In Writer do the following:

1) Insert a line in the document (Insert - Shape - Line - Line)
2) Double click the line, which will enable the cursor; type some text
3) Now go to Format - Text Box and Shape - Fontwork

This will open the dialog in the screenshot.
Comment 4 Jean-Baptiste Faure 2022-10-16 20:26:29 UTC
(In reply to Rafael Lima from comment #3)
> In Writer do the following:
> 
> 1) Insert a line in the document (Insert - Shape - Line - Line)
> 2) Double click the line, which will enable the cursor; type some text
> 3) Now go to Format - Text Box and Shape - Fontwork
> 
> This will open the dialog in the screenshot.

Thank you. Confirmed with Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: f4e7738112eb4a374186a99953a74a5288bee4b0
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Ubuntu_20.04_x86-64
Calc: threaded

Best regards. JBF
Comment 5 Commit Notification 2022-10-17 14:05:41 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a7ac5f7707f10749a00478af835c9ec212891d1b

tdf#151527 Breeze: Add missing icons in Fontwork dialog

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-10-17 19:47:00 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04778d32b342fe943117a0dfb7b4d35770c5b960

tdf#151527 Sifr: Add missing icons in Fontwork dialog

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.