Bug 151622 - File save PPTX: Embedded object save as icon is incorrect after its opening.
Summary: File save PPTX: Embedded object save as icon is incorrect after its opening.
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:7.5.0
Keywords: filter:pptx
Depends on:
Blocks: PPTX-OLE
  Show dependency treegraph
 
Reported: 2022-10-18 13:08 UTC by NISZ LibreOffice Team
Modified: 2022-11-22 12:24 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Test_odf_file (19.49 KB, application/vnd.oasis.opendocument.presentation)
2022-10-18 13:08 UTC, NISZ LibreOffice Team
Details
Test OLE object docx file (11.78 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2022-10-18 13:09 UTC, NISZ LibreOffice Team
Details
Test pptx file (33.23 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2022-10-18 13:09 UTC, NISZ LibreOffice Team
Details
Picture of the problem (54.42 KB, image/png)
2022-10-18 13:10 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-10-18 13:08:27 UTC
Description:
Insert an OLE object as an icon in Impress and save to PPTX format.
After reloading the file, and clicking on the file and open it then close it the opened window which is the embedded file, after that the OLE object doesn't look like an icon.


Steps to Reproduce:
1. Open Impress
2. Insert -> OLE object -> OLE object
3. Insert OLE Object window -> Create from file 
4. Click on "Display as icon"
5. Search an existing file
6. OK
7. Save as PPTX
8. Reload the pptx file
9. Double click on the OLE object 
10. Close the opened embedded file

Actual Results:
When you open the embedded file and close it the OLE object doesn't looks like an icon after the opening.

Expected Results:
Once opened, the embedded file remains as an icon in pptx


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded
Comment 1 NISZ LibreOffice Team 2022-10-18 13:08:55 UTC
Created attachment 183113 [details]
Test_odf_file
Comment 2 NISZ LibreOffice Team 2022-10-18 13:09:24 UTC
Created attachment 183114 [details]
Test OLE object docx file
Comment 3 NISZ LibreOffice Team 2022-10-18 13:09:51 UTC
Created attachment 183115 [details]
Test pptx file
Comment 4 NISZ LibreOffice Team 2022-10-18 13:10:21 UTC
Created attachment 183116 [details]
Picture of the problem
Comment 5 Commit Notification 2022-11-02 07:04:37 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ea62cacd129f03813d7d3d214bf9aa2ae60bbef4

tdf#151622 PPTX: fix export of show as icon option

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-11-02 08:10:02 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b652ebda7fa4e6c8db2f934bf4c8d2927f5c2332

Revert "tdf#151622 PPTX: fix export of show as icon option"

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-11-14 11:19:36 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b224cc5f3c896d8b0064d5cbadc6fce66c8beb9

Revert "Revert "tdf#151622 PPTX: fix export of show as icon option""

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 NISZ LibreOffice Team 2022-11-22 12:24:26 UTC
Verified in:
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5116d6ad85d804e7b7897bc57a4a4bf9d5bed4f1
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded