Bug 151647 - Sifr: Missing Table/Cell Border Icons
Summary: Sifr: Missing Table/Cell Border Icons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: Icon-Theme-Sifr
  Show dependency treegraph
 
Reported: 2022-10-19 23:59 UTC by Rizal Muttaqin
Modified: 2022-10-20 04:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Image capture showing no borders (36.94 KB, image/png)
2022-10-19 23:59 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2022-10-19 23:59:25 UTC
Created attachment 183153 [details]
Image capture showing no borders

Steps to reproduce:
1. Change icon theme to Sifr
2. Insert a table in Writer
3. Select the table, right click > Table Properties...
4. Select Borders tab

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 73911ed8d35294a9e15771d8aaa1e9121ef10309
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded
Comment 1 Rizal Muttaqin 2022-10-20 00:18:26 UTC
This issue affects Calc also:

1. Right click in a Cell, select Format Cells
2. Click Borders tab
Comment 2 V Stuart Foote 2022-10-20 00:29:23 UTC
Can not confirm. On Windows 10 or on Windows 11 with 7.4.2.3 installed.

With Sifr icon theme selected active os/DE in default Light mode as shown in attachment, the Sifr them shows appropriate icons for each of the line arrangement Presets:  No border, Outer Border Only, Outer border and horizontal lines, Outer border and all inner lines, Outer border without changing inner lines.

If I toggle the os/DE into "Dark" color mode, and select the Sifr (Dark) icon theme, same result of a visible Sifr theme icon for each.
Comment 3 V Stuart Foote 2022-10-20 01:04:17 UTC
(In reply to V Stuart Foote from comment #2)

But I guess they could be small sc fallback.

They're manipulated in
https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/borderpage.ui
https://opengrok.libreoffice.org/xref/core/cui/source/tabpages/border.cxx

but I couldn't figure how the specific icon theme gets applied to check for an icon present or not in the Sifr set(s).
Comment 4 Rizal Muttaqin 2022-10-20 01:14:01 UTC
(In reply to V Stuart Foote from comment #2)
> Can not confirm. On Windows 10 or on Windows 11 with 7.4.2.3 installed.
> 
> With Sifr icon theme selected active os/DE in default Light mode as shown in
> attachment, the Sifr them shows appropriate icons for each of the line
> arrangement Presets:  No border, Outer Border Only, Outer border and
> horizontal lines, Outer border and all inner lines, Outer border without
> changing inner lines.
> 
> If I toggle the os/DE into "Dark" color mode, and select the Sifr (Dark)
> icon theme, same result of a visible Sifr theme icon for each.

I deleted all icon themes other than Sifr. If you have Breeze or Colibre installed, probably the dialog show them
Comment 5 Commit Notification 2022-10-20 03:59:17 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8fd73044cc7e8f3257a8ca56728e56119821046

tdf#151647 Sifr: Table/Cell border icons

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.