Bug 151665 - There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu
Summary: There are no "Deletions in margin" and "Insertions in margin" items in some E...
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: needsUXEval
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2022-10-20 18:50 UTC by Roman Kuznetsov
Modified: 2022-11-11 10:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2022-10-20 18:50:58 UTC
Description:
There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu 

After fix bug 34355 we can show the Track changes by three ways: 
"All changes inline"
"Deletions in margin" 
"Insertions in margin"

You can select one variant from these three using small triangle on Show Track changes button on Track changes toolbar

But I couldn't find these variants in Edit-Track changes submenu. There is only Show item (I think it is equal default "All changes inline" variant) there.

So I suggest add submenu like:

Edit - Track changes - Show -
                               All changes inline
                               Deletions in margin
                               Insertions in margin

Steps to Reproduce:
-

Actual Results:
There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu 

Expected Results:
There are "Deletions in margin" and "Insertions in margin" items in Edit-Track changes submenu 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4d9b83a417bbde8148b67d2ab0abe9f4ae285276
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded
Comment 1 Heiko Tietze 2022-11-03 10:08:17 UTC
"Edit > TC > [x] Show" is an easy-to-use and well-known function. And we have to consider the off situation. If we do something like 
Edit > TC > Show > (o) Off
Edit > TC > Show > ( ) Show all inline
Edit > TC > Show > ( ) Insertion in margin
Edit > TC > Show > ( ) Deletions in margin

it adds a lot of confusion for casual users. My take: keep it simple here and let the inline vs. margin thing be something for the advanced users with access per menu button in the toolbar.

Btw, having another route per tools > options is also not helping.
Comment 2 Heiko Tietze 2022-11-10 09:20:51 UTC
The topic was on the agenda of the design meeting but didn't receive further input.

As commented before adding all options makes the simple on/off switch much more complex. I recommend to not expose the options at the menu and leave it for the toolbar.
Comment 3 Roman Kuznetsov 2022-11-10 10:27:57 UTC
(In reply to Heiko Tietze from comment #2)
> The topic was on the agenda of the design meeting but didn't receive further
> input.
> 
> As commented before adding all options makes the simple on/off switch much
> more complex. I recommend to not expose the options at the menu and leave it
> for the toolbar.

So, what about our HIG then? If I remember right "all functions should be available from main menu"...
Comment 4 Heiko Tietze 2022-11-10 11:57:59 UTC
(In reply to Roman Kuznetsov from comment #3)
> So, what about our HIG then? If I remember right "all functions should be
> available from main menu"...

Exception is the rule. You don't expect Delete to be in the main menu.
Comment 5 Commit Notification 2022-11-11 10:34:35 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/0a4258b67775ee61f6d2f0b9b45b6437c508d338

tdf#151665 Track changes in margins