Description: There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu After fix bug 34355 we can show the Track changes by three ways: "All changes inline" "Deletions in margin" "Insertions in margin" You can select one variant from these three using small triangle on Show Track changes button on Track changes toolbar But I couldn't find these variants in Edit-Track changes submenu. There is only Show item (I think it is equal default "All changes inline" variant) there. So I suggest add submenu like: Edit - Track changes - Show - All changes inline Deletions in margin Insertions in margin Steps to Reproduce: - Actual Results: There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu Expected Results: There are "Deletions in margin" and "Insertions in margin" items in Edit-Track changes submenu Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4d9b83a417bbde8148b67d2ab0abe9f4ae285276 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded
"Edit > TC > [x] Show" is an easy-to-use and well-known function. And we have to consider the off situation. If we do something like Edit > TC > Show > (o) Off Edit > TC > Show > ( ) Show all inline Edit > TC > Show > ( ) Insertion in margin Edit > TC > Show > ( ) Deletions in margin it adds a lot of confusion for casual users. My take: keep it simple here and let the inline vs. margin thing be something for the advanced users with access per menu button in the toolbar. Btw, having another route per tools > options is also not helping.
The topic was on the agenda of the design meeting but didn't receive further input. As commented before adding all options makes the simple on/off switch much more complex. I recommend to not expose the options at the menu and leave it for the toolbar.
(In reply to Heiko Tietze from comment #2) > The topic was on the agenda of the design meeting but didn't receive further > input. > > As commented before adding all options makes the simple on/off switch much > more complex. I recommend to not expose the options at the menu and leave it > for the toolbar. So, what about our HIG then? If I remember right "all functions should be available from main menu"...
(In reply to Roman Kuznetsov from comment #3) > So, what about our HIG then? If I remember right "all functions should be > available from main menu"... Exception is the rule. You don't expect Delete to be in the main menu.
Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/0a4258b67775ee61f6d2f0b9b45b6437c508d338 tdf#151665 Track changes in margins
A usability issue remains here; I was about to file the same bug report, because this is only available in "Tabbed" notebookbar and in "Standard" (traditional) toolbar UI layout modes. The dropdown menu version of the "Show track changes" toolbar button is not available at all in: * "Groupedbar Compact" UI layout * "Tabbed Compact" UI layout * "Single toolbar" UI layout * "Contextual Single" UI layout Heiko, would it make sense to reopen this ticket here, or should it rather be a new bug report in light of these usecases in particular?
(In reply to Jeff Fortin Tam from comment #6) > Heiko, would it make sense to reopen this ticket here, or should it rather > be a new bug report in light of these usecases in particular? Feel free to reopen (and I'll present the topic in the design meeting). But my comment 1 stands: KISS ftw.
OK, reopening for consideration; I don't particularly care whether it's in the toolbar or in the menu, but I believe it ought to be in at least one or the other, instead of none at all (as is currently the case in many of the UI layout choices :)
The request is to add additional options to the main menu. My comment 1 was not objected (see comment 2) so we should keep the main menu simple. Comment 6 is about special flavors of the Notebookbar - we do have a Show Track Changes menu button on the (most popular) Tabbed variant.
As you can surmise, I am indeed advocating for parity of this feature across toolbars flavors, or, as a fallback, parity through the context-specific menu (which, while less in-your-face as the toolboar approach, at least has the "solve that design problem once = solve it in every flavor because they can use the same menus without toolbar buttons layouts constraints" advantage going for it). If LibreOffice offers more than 2 UI layouts, then I don't think users should be penalized for picking the "wrong" UI layout ;)
(In reply to Heiko Tietze from comment #1) > it adds a lot of confusion for casual users. Can't we put these three options in a submenu? May be call it "Change Display Mode" or something? (I might even suggest combining the chekbox and the submenu on a single menu item but I don't think we support that kind of thing.)
Created attachment 205055 [details] Writer - bug 151665 - track changes-overview I'm not quite sure that there is a real use in having those additional options in the view menu. The view menu (number 3 in attached file) is mostly ON/OFF things: Do you want to see it: Yes or No? Such more detailed configuration is better placed in a toolbar for such an option where all controls are combined in one area. This place would _not_ be the menu bar IMHO (number 1 in attached file) as pretty much all options are just doubled in the UI toolbar. I never had the need to fiddle with menu and submenus when I can access the toolbar directly (my access hierarchy: keyboard shortcut > UI toolbars > menu). But removing those menu entries to de-bloat it is maybe to off topic here. IMO a far better solution here be to enable the UI toolbar by default when you activate to track changes (number 2 in attached file) which it currently does not seem to do. I mostly use default settings and I can't remember that I turned off this toolbar at any point in time in the past (doing so would also makes no sense to me right now as the menu bar contains commands that are nowhere else to be found in the UI outside of the menu)
We discussed the topic in the design meeting. Since we have Show (TC) twice on the main menu, once at View > Show TC and Edit > TC > Show, we could easily sacrifice the latter in favor of a 3-option submenu. The question boils down to whether this fine-tuning justifies an entry in the main menu - meaning is frequently adjusted by many users - or is kind of a one-off setting and rarely adjusted by users. And we have not come to an agreement here. Yet, there are still some issues around the feature. For once, the TC toolbar needs to be context sensitive and show up automatically if TC is switched on. And secondly the option/s is/are missing on the other NC variants.