Description: Contents of the Help system is unreadable in browser when Windows is in dark mode (light font on white background). Tested with browsers Firefox and Edge. Steps to Reproduce: 1. Select "Dark" color in Windows Settings, Themes and related settings, Colors 2. Open menu Help-> LibreOffice Help Actual Results: Text contents is unreadable (light font on white background). Expected Results: Text color should be hard coded black or default window background should be used. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.1.2 (x64) / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: bg-BG (bg_BG); UI: en-US Calc: threaded
Created attachment 183240 [details] Unreadable Help contents - light text on white background.
I can't test on Windows as my Win 10 in a virtual machine is unactivated, but if this is the normal behavior, this seems like a really bad decision by Microsoft! Why should Windows dark mode mess with the colours of websites, if the websites have not explicitly configured their CSS to depend on the colour scheme?
Created attachment 183264 [details] Screenshot win10 dark mode. Looks fine for me, with Firefox (screenshot) and with edge (no chrome to test). Maybe something else is changed.
(In reply to m.a.riosv from comment #3) > Created attachment 183264 [details] > Screenshot win10 dark mode. > > Looks fine for me, with Firefox (screenshot) and with edge (no chrome to > test). Maybe something else is changed. @m.a.riosv, I think you are not really in dark mode - the tabs and the borders of your browser are LIGHT - see my attachment for example.
(In reply to scorpiosoft from comment #4) > (In reply to m.a.riosv from comment #3) > > Created attachment 183264 [details] > > Screenshot win10 dark mode. > > > > Looks fine for me, with Firefox (screenshot) and with edge (no chrome to > > test). Maybe something else is changed. > > @m.a.riosv, I think you are not really in dark mode - the tabs and the > borders of your browser are LIGHT - see my attachment for example. Your browser UI is also light, there is no difference.
Created attachment 183265 [details] Help in Firefox in dark mode (In reply to scorpiosoft from comment #4) > (In reply to m.a.riosv from comment #3) > > Created attachment 183264 [details] > > Screenshot win10 dark mode. > @m.a.riosv, I think you are not really in dark mode - the tabs and the > borders of your browser are LIGHT - see my attachment for example. @m.a.riosv, sorry, my mistake - I had attached screenshot from Edge (light theme by default). See this one. By the way - I have NOT tested Help from ver. 7.5
Created attachment 183266 [details] Screenshot about FF in dark mode. Attached screenshot with FF in dark mode (oscuro), with the help window.
(In reply to m.a.riosv from comment #7) > Created attachment 183266 [details] > Screenshot about FF in dark mode. > > Attached screenshot with FF in dark mode (oscuro), with the help window. @m.a.riosv, in report I meant dark mode OF WINDOWS, not of FireFox. I think, the problem is in default color of font (inherited light from Windows), NOT set explicitly to dark in LibreOffice Help.
(In reply to scorpiosoft from comment #8) > I think, the problem is in default color of font (inherited light from > Windows), NOT set explicitly to dark in LibreOffice Help. But this is not supposed to happen. If it happens, it's a bug in Windows itself (or some glitch on your system). It would be completely insane, if this was the normal behaviour.
It was with dark mode in Win10 and FF.
(In reply to Buovjaga from comment #9) > (In reply to scorpiosoft from comment #8) > > I think, the problem is in default color of font (inherited light from > > Windows), NOT set explicitly to dark in LibreOffice Help. > > But this is not supposed to happen. If it happens, it's a bug in Windows > itself (or some glitch on your system). It would be completely insane, if > this was the normal behaviour. If I see right, in styles of the Help font color INDEED is NOT set explicitly, but background IS set - so, in MY opinion, ROOT of the problem is NOT in Windows. If both colors are set explicitly, the Help will NOT depends PARTIALLY on OS setting.
(In reply to m.a.riosv from comment #10) > It was with dark mode in Win10 and FF. If I see right, in styles of the Help font color INDEED is NOT set explicitly, but background IS set - so, in MY opinion, ROOT of the problem is NOT in Windows. If both colors are set explicitly, the Help will NOT depends PARTIALLY on OS setting.
(In reply to scorpiosoft from comment #11) > (In reply to Buovjaga from comment #9) > > (In reply to scorpiosoft from comment #8) > > > I think, the problem is in default color of font (inherited light from > > > Windows), NOT set explicitly to dark in LibreOffice Help. > > > > But this is not supposed to happen. If it happens, it's a bug in Windows > > itself (or some glitch on your system). It would be completely insane, if > > this was the normal behaviour. > > If I see right, in styles of the Help font color INDEED is NOT set > explicitly, but background IS set - so, in MY opinion, ROOT of the problem > is NOT in Windows. If both colors are set explicitly, the Help will NOT > depends PARTIALLY on OS setting. No, the operating system should never alter the website styles unless the website explicitly requests it. See https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme
Shouldn't this be marked as an enhancement?
(In reply to Martin Srebotnjak from comment #14) > Shouldn't this be marked as an enhancement? No, it is possible scorpiosoft is using some Firefox addon that manipulates the style of the page. Scorpiosoft should mention relevant addons.
(In reply to Buovjaga from comment #15) > (In reply to Martin Srebotnjak from comment #14) > > Shouldn't this be marked as an enhancement? > > No, it is possible scorpiosoft is using some Firefox addon that manipulates > the style of the page. Scorpiosoft should mention relevant addons. As I wrote in initial description, the issue is the same in Edge too. The former is absolutely clear (no add-ons, all settings are with default values), the browser is unused at all. It appears to me that no one mention my opinion for the reason for the problem: the background of Help pages is hard coded, but font color is NOT (in the Help pages background is hard coded as "white"). I think if the first one is EXPLICITLY set, the second one MUST be set EXPLICITLY too.
From the screenshot, I see that the help is from the installed help pack. Scorpio, can you please: - see if the online version has the same issue for you: https://help.libreoffice.org/7.4/en-GB/text/shared/05/new_help.html - update to 7.5 and see if you can still reproduce the issue? - share exactly what theme you are using in your Windows settings Thank you!
(In reply to Stéphane Guillou (stragu) from comment #17) > From the screenshot, I see that the help is from the installed help pack. Yes, that's right. > Scorpio, can you please: > - see if the online version has the same issue for you: > https://help.libreoffice.org/7.4/en-GB/text/shared/05/new_help.html Yes, it has the issue > - update to 7.5 and see if you can still reproduce the issue? I have updated already and yes, the issue is reproducible. > - share exactly what theme you are using in your Windows settings I have tried two DARK themes: * Adapta (from DevianArt, https://www.deviantart.com/niivu/art/Adapta-for-Windows-10-675581778 ) * W10 dark graphite ribbon (from DevianArt, https://www.deviantart.com/arsonist1234/art/W10-Dark-Graphite-Ribbon-1903-1909-Dark-Mode-818947842 ) I hope the above info us useful.
Thanks for the info. (In reply to scorpiosoft from comment #18) > I have tried two DARK themes: > * Adapta (from DevianArt, > https://www.deviantart.com/niivu/art/Adapta-for-Windows-10-675581778 ) > * W10 dark graphite ribbon (from DevianArt, > https://www.deviantart.com/arsonist1234/art/W10-Dark-Graphite-Ribbon-1903- > 1909-Dark-Mode-818947842 ) Do you reproduce without any custom theme, only using the stock Windows-provided dark themes? And which accent colour are you using?
(In reply to Stéphane Guillou (stragu) from comment #19) > Thanks for the info. > > (In reply to scorpiosoft from comment #18) > > I have tried two DARK themes: > > * Adapta (from DevianArt,... > > Do you reproduce without any custom theme, only using the stock > Windows-provided dark themes? > And which accent colour are you using? Sorry, but I have NOT found (yet?) any "Windows-provided dark themes" :) When I set Windows to "dark mode" ("Themes and related settings" -> "Color" -> "Dark"), LibreOffice Help is showing CORRECTLY. As a side note only - in that way many app's does NOT change their colors accordingly. By using custom themes they DOES. IMHO, the HTML pages must NOT rely on default font color when page background is set explicitly. If this is not the developers opinion, the issue can be closed.
(In reply to scorpiosoft from comment #20) > (In reply to Stéphane Guillou (stragu) from comment #19) > > Thanks for the info. > > > > (In reply to scorpiosoft from comment #18) > > > I have tried two DARK themes: > > > * Adapta (from DevianArt,... > > > > Do you reproduce without any custom theme, only using the stock > > Windows-provided dark themes? > > And which accent colour are you using? > > Sorry, but I have NOT found (yet?) any "Windows-provided dark themes" :) > When I set Windows to "dark mode" ("Themes and related settings" -> "Color" > -> "Dark"), LibreOffice Help is showing CORRECTLY. You found the Windows-provided dark theme. > As a side note only - in that way many app's does NOT change their colors > accordingly. By using custom themes they DOES. > > IMHO, the HTML pages must NOT rely on default font color when page > background is set explicitly. If this is not the developers opinion, the > issue can be closed. Then it's a problem with those themes you downloaded from DeviantArt, they need to be corrected.
The see also bug 148016 and its dupe bug 153284 are germane. Otherwise this issue when using non-default MS Win10/11 Light/Dark theme support for CSS browser rendering is NOB.