Bug 152029 - Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
Summary: Visually draw attention to in-view bookmark or hyperlink when selecting/hover...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.6.0 target:7.5....
Keywords:
Depends on:
Blocks: Navigator Bookmarks
  Show dependency treegraph
 
Reported: 2022-11-13 22:44 UTC by Eyal Rozenberg
Modified: 2023-12-01 23:43 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Bookmark variants (43.06 KB, image/png)
2022-11-14 08:38 UTC, Heiko Tietze
Details
visually draw attention to in-view bookmark demo1 (998.14 KB, video/x-matroska)
2022-11-27 23:12 UTC, Jim Raykowski
Details
visually draw attention to in-view bookmark demo2 (1.56 MB, video/x-matroska)
2022-11-30 08:22 UTC, Jim Raykowski
Details
visually draw attention to in-view bookmark demo 3 (825.19 KB, video/x-matroska)
2022-12-02 04:43 UTC, Jim Raykowski
Details
mouse over demo (923.15 KB, video/x-matroska)
2022-12-04 00:49 UTC, Jim Raykowski
Details
multi-page mouse over demo (1.67 MB, video/x-matroska)
2022-12-04 02:37 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-11-13 22:44:20 UTC
When the a bookmark is currently in view (is "in the viewport" the right term?), and one selects it in the Navigator pane, there should be some sort of visual indication of this in the rendering of the bookmark. Currently it's just a gray  I-like symbol, never changing. Indication could be:

* Flashing (or perhaps increased then reduced transparency for a more subtle effect)
* Change in weight (e.g. increase then decrease back)
* Change in lightness (from gray to dark grey or black, then back)
* More radical change in color (e.g. change to red and back, or blue and back etc.)
* Change in shape

... or a combination of the above. Or something else.

I suggest we also consider:

1. When the stable-state display of a bookmark in the selected state should differ from the stable-state display of an unselected one (I would say: Yes; and perhaps the mere transition would suffice as a highlight).
2. Similar attention-drawing effect also when hovering over a bookmark, not just when properly selecting it.
Comment 1 Heiko Tietze 2022-11-14 08:37:20 UTC
You can double-click the Navigator item but this is admittedly not the desired behavior. And with View > Field Shadings (Ctrl+F8) off you don't get even the small indicators (a vertical line for single character bookmarks, brackets for longer text, and a rectangle for hiding bookmarks).

The color is taken from Options > Application Colors > Field shadings, so using a different color on-hover is not possible (or we go with the selection color). Flashing is an option, though.

What bothers me is a) what happens when the item is not in view (maybe nothing), and b) we should be consistent and I wonder how we can do the same for images, frames, tables... Jim, what do you think?
Comment 2 Heiko Tietze 2022-11-14 08:38:29 UTC
Created attachment 183578 [details]
Bookmark variants

Taken from the formatted dummy text https://extensions.libreoffice.org/en/extensions/show/132
Comment 3 Eyal Rozenberg 2022-11-14 08:46:36 UTC
(In reply to Heiko Tietze from comment #1)
> And with View > Field Shadings (Ctrl+F8) off you don't get
> even the small indicators (a vertical line for single character bookmarks,
> brackets for longer text, and a rectangle for hiding bookmarks).

Ah, actually, I haven't thought of what I want to ask for in the case of field indications off. Probably the same thing I asked for already, but it's another thing to think about.


> The color is taken from Options > Application Colors > Field shadings, so
> using a different color on-hover is not possible (or we go with the
> selection color). Flashing is an option, though.
> 
> What bothers me is a) what happens when the item is not in view (maybe
> nothing)

Indeed: Nothing.

>, and b) we should be consistent and I wonder how we can do the same
> for images, frames, tables... 

You mean, when they're selected in the navigator? Hmm. Interesting question. The thing is, images and tables are bigger and already very eye-catching. A bookmark is barely noticeable.


By the way: Important use case: You have multiple bookmarks without meaningful names, and you want to know which of them refers to which place in the text. Especially relevant for bookmarks imported/generated from DOCX files.
Comment 4 Jim Raykowski 2022-11-27 22:08:56 UTC
Here is a patch that does the bookmark part of this request:
https://gerrit.libreoffice.org/c/core/+/143357

Basically it creates a selection over a bookmark's start and end position if the start position of the bookmark is in the visible view. Bookmarks having the same start and end position are selected as the start position + 1 character.
Comment 5 Eyal Rozenberg 2022-11-27 22:44:06 UTC
(In reply to Jim Raykowski from comment #4)
> Here is a patch that does the bookmark part of this request:
> https://gerrit.libreoffice.org/c/core/+/143357
> 
> Basically it creates a selection over a bookmark's start and end position if
> the start position of the bookmark is in the visible view. Bookmarks having
> the same start and end position are selected as the start position + 1
> character.

Could I trouble you to post a screenshot of how this looks? I don't think I understand exactly. Also, does this actually select the bookmark, de-selecting an existing selection? I don't think that's a good idea, especially since that functionality is what a double-click does.
Comment 6 Jim Raykowski 2022-11-27 23:12:33 UTC
Created attachment 183838 [details]
visually draw attention to in-view bookmark demo1
Comment 7 V Stuart Foote 2022-11-28 00:24:23 UTC
(In reply to Jim Raykowski from comment #4)
> Here is a patch that does the bookmark part of this request:
> https://gerrit.libreoffice.org/c/core/+/143357
> 
> Basically it creates a selection over a bookmark's start and end position if
> the start position of the bookmark is in the visible view. Bookmarks having
> the same start and end position are selected as the start position + 1
> character.

So requires cursor movement through the SB Navigator in 'Bookmarks' mode, highlighting but not selecting the bookmark as visible on canvas.  Assume an actual click selection on any bookmark in SB would reposition the document viewport to that bookmark dropping any active cursor selection.

So not clear we've got exactly the ask, of a visual indication of each of the bookmarks visible in the viewport activating its object on the Navigator Bookmarks mode. 

But if that is too much, maybe an addition/alternative. Could we more simply flash visible all the bookmarks the current view port, both the document canvas and the SB? 

The change to field shading color (bug 144677) from NPC makes the bookmark on canvas (bug 45589)  a bit hard to spot--the flash of highlight all of them in view might be useful.
Comment 8 Heiko Tietze 2022-11-28 08:56:29 UTC
(In reply to Jim Raykowski from comment #4)
> Here is a patch that does the bookmark part of this request:
> https://gerrit.libreoffice.org/c/core/+/143357

Awesome!
Comment 9 Eyal Rozenberg 2022-11-28 09:29:16 UTC
No, I'm sorry, this is not awesome. I watched the video, and a selection, or even something that is indistinguishable from a selection, wouldn't do. We can already select with a double click. I'm asking for a temporary highlighting - and leaving the current selection alone. This would also be too inconsistent with the fact that selection of a Navigator item under, say, Headings, doesn't select nor show a selection of the heading. The point here, and what sets bookmarks apart from headings, is that given two bookmark names, and two bookmark indicators on the page, you can't know which is which. That's why _gentle_, or subtle, highlighting is appropriate. 

(TBH I wouldn't mind subtle highlighting for other entities but again, not something as strong as a selection.)
Comment 10 Jim Raykowski 2022-11-30 08:22:33 UTC
Created attachment 183906 [details]
visually draw attention to in-view bookmark demo2

Here is a demo of a go at this that doesn't add to cursor selections. Currently the overlay color is hard coded yellow. The period of time the overlay is shown is 1/2 second.
Comment 11 Jim Raykowski 2022-12-02 04:43:31 UTC
Created attachment 183949 [details]
visually draw attention to in-view bookmark demo 3

Demo 3 uses an invert approach to visually draw attention to the in-view bookmark. Less subtle than the transparent color approach shown in demo 2, but works to bring attention to an in-view bookmark that has yellow background and we don't need to decide what color to use.
Comment 12 V Stuart Foote 2022-12-02 16:51:02 UTC
(In reply to Jim Raykowski from comment #11)
> Created attachment 183949 [details]
> visually draw attention to in-view bookmark demo 3
> 
> Demo 3 uses an invert approach to visually draw attention to the in-view
> bookmark. Less subtle than the transparent color approach shown in demo 2,
> but works to bring attention to an in-view bookmark that has yellow
> background and we don't need to decide what color to use.

@Jim, *

Yes, for me the flash with the invert seems more apparent +1

And it would better meet assistive technology support needs. But we might want to adopt use of an AT setting to adjust the time the highlight is visible--'HelpTipSeconds' perhaps?

And still think that a 'one click' flash of all bookmarks in view port would be useful--possibly triggered on entering the Bookmarks mode in the treeview or selecting the mode in the droplist?
Comment 13 Eyal Rozenberg 2022-12-02 18:23:27 UTC
(In reply to Jim Raykowski from comment #11)

Demos 2 and 3 are more to my liking. It's difficult for me to say what exactly should be the duration of the highlighting/inversion. I am also undecided whether the highlighting or the inversion is better. Let others chime in...

However, I would like to suggest one other option regarding the visual style. A bookmark is currently indicated with gray square brackets: [Text]. The highlighting could be the extension, or filling, of the area (/run) between the start and end brackets with the same gray color. Perhaps that might seem less idiosyncratic than a new style of highlight - more like some physical marking that gets unfurled then stowed away, a bit like clotheslines. I'm not saying that I'm sure this is better - just an idea.

Another point to consider is how other applications handle this - particularly w.r.t. finding objects. In Writer, finding something means selecting it. But not all applications share this behavior. In Firefox, for example, selection and find-highlighting are different. Try using both on this webpage, for example. On Linux (and with FF using GTK I think), selection is dark-color background (blue) + white text, find-highlighting is light-color background (green), white text.
Comment 14 Jim Raykowski 2022-12-04 00:49:34 UTC
Created attachment 183981 [details]
mouse over demo

Here is a demo of the mouse over idea. Please notice the short delay before attention is drawn to the bookmark location in the view.
Comment 15 V Stuart Foote 2022-12-04 01:08:34 UTC
(In reply to Jim Raykowski from comment #14)
> Created attachment 183981 [details]
> mouse over demo
> 
> Here is a demo of the mouse over idea. Please notice the short delay before
> attention is drawn to the bookmark location in the view.

Thanks Jim, that initial flash of all bookmarks in current viewport looks useful!

How does it do when zoomed out to show a couple of pages of the canvas?

And, yes the delay 'til flash does help keep it unobtrusive--that was smart.
Comment 16 Jim Raykowski 2022-12-04 02:37:33 UTC
Created attachment 183982 [details]
multi-page mouse over demo

(In reply to V Stuart Foote from comment #15)
> Thanks Jim, that initial flash of all bookmarks in current viewport looks
> useful!
Thanks for the idea! It certainly does seem useful.

> How does it do when zoomed out to show a couple of pages of the canvas?
Please see the attached multi-page mouse over demo

> And, yes the delay 'til flash does help keep it unobtrusive--that was smart.
Unobtrusive is good,

Currently, for the mouse over approach, highlighting in the view remains as long as the mouse is over the bookmark entry. It does not timeout like the entry selection approach.
Comment 17 Jim Raykowski 2022-12-04 06:49:03 UTC
Link to patch that does mouse over approach:
https://gerrit.libreoffice.org/c/core/+/143628
Comment 18 Jim Raykowski 2022-12-04 18:47:08 UTC
Patch for hyperlink(s) mouse over attention approach:
https://gerrit.libreoffice.org/c/core/+/143636
Comment 19 V Stuart Foote 2022-12-04 20:31:28 UTC
(In reply to Jim Raykowski from comment #18)
> Patch for hyperlink(s) mouse over attention approach:
> https://gerrit.libreoffice.org/c/core/+/143636

Cool, including the URLs for hyperlinks in same fashion is a great idea!
Comment 20 Jim Raykowski 2022-12-05 00:37:11 UTC
How about for reference and field content?

For consistency, we could do this for a11 of the content types shown in the Navigator. But, as Eyal commented, "images and tables are bigger and already very eye-catching".
Comment 21 V Stuart Foote 2022-12-05 03:13:22 UTC
(In reply to Jim Raykowski from comment #20)
> How about for reference and field content?
> 
> For consistency, we could do this for a11 of the content types shown in the
> Navigator. But, as Eyal commented, "images and tables are bigger and already
> very eye-catching".

Your call of course for doing it for images and tables, otherwise consistency is good.
Comment 22 Eyal Rozenberg 2022-12-05 09:35:09 UTC
Actually... I'm starting to have second thoughts about the hover behavior. I mean, it's convenient for me when I _want_ it, but people hover their mouse over stuff all the time on the way to someplace else; and sometimes just absent-mindedly. Will people who do not want the highlighting not be distrubed by it? And this is as opposed to single-clicking an item?
Comment 23 V Stuart Foote 2022-12-05 13:49:16 UTC
(In reply to Eyal Rozenberg from comment #22)
> Actually... I'm starting to have second thoughts about the hover behavior. I
> mean, it's convenient for me when I _want_ it, but people hover their mouse
> over stuff all the time on the way to someplace else; and sometimes just
> absent-mindedly. Will people who do not want the highlighting not be
> distrubed by it? And this is as opposed to single-clicking an item?

Can trigger via a mouse-over as now--with a time delay before trigger-- or could possibly adopt an <Alt> keyboard accelerator toggle, dependent on the Navigator "mode" selected.

I'd think that to keep the on canvas flash functional (and simple) we need to avoid a mouse click (l or r) toggle that could steal focus.
Comment 24 Commit Notification 2022-12-06 21:48:02 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3cb654972ba204efb5dd35a44f95c7d509414400

tdf#152029 Visually draw attention to in-view bookmark

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Commit Notification 2022-12-08 08:02:19 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7ed2502b7f67d2f349c5fb58703557cf310e7e14

tdf#152029 Bring hyperlinks to attention in document view

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Commit Notification 2022-12-08 08:03:21 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/329c32d1e9e316f3ba75d38dd4565ea14599ec9a

tdf#152029 Bring refmarks and textfields to attention in document view

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 27 Commit Notification 2022-12-08 08:03:23 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8dbb69bcee477886fab752f9bd158cf54951b827

tdf#152029 Bring headings to attention in document view

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2022-12-08 08:04:26 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/26b64750ea15812de172985b50e6f22c2c71a60d

tdf#152029 Bring tables, frames, images, and ole objects to

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 V Stuart Foote 2022-12-08 16:59:10 UTC
@Jim, *

Got a chance to test drive with Bookmark in view attention feature 3cb654972ba204efb5dd35a44f95c7d509414400

Works well, was testing against the GettingStarted 7.4 guide ODT, where it helped to first focus to the page or two (if in multi-page view mode), but the mouse-over  visual toggle of the bookmarks in the view-port nicely exposes them--even the "no text" bookmarks.

I like it, looking forward to the additional "attention" views. 

=-testing-=
Windows 10 in both Dark and Light color themes

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 52c75986adc2b370eb55ce918ab1db0a95831c83
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 30 Commit Notification 2022-12-09 06:41:03 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/11b87e7601fd24eb290854e9642bf01d0b4592ff

tdf#152029 Bring drawing objects to attention in the document view

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 Commit Notification 2022-12-10 17:34:17 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/080d2d21cb59fd6e81375f15cf17c6cbfc605a77

tdf#152029 related: Prevent crash on nullptr iter_compare

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 32 Commit Notification 2022-12-12 09:04:13 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/b87ee9171b27184b1781c287fd89af3188da9377

tdf#152029 Bring drawing objects to attention in the document view

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 33 Commit Notification 2022-12-12 14:20:57 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b7a51a7cd46e155ad78ac0f9301863d5a1eabd52

tdf#152029 Bring sections to attention in the document view

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 34 Commit Notification 2022-12-13 18:00:37 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/25778012374b2f03cd01303c01d167206515ee71

tdf#152029 Bring sections to attention in the document view

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 35 Commit Notification 2022-12-13 18:29:41 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a2d211359b082db33153e9bc22c2184f2de1131e

tdf#152029 Bring footnotes and endnotes to attention in the document

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 36 Commit Notification 2022-12-14 18:51:28 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/c5d262518d917a7a6a4f9ccac7b74b488f5b2269

tdf#152029 related: Prevent crash on nullptr iter_compare

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 37 Commit Notification 2022-12-15 01:04:05 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bef199febca711c9aa3fd199e8ca525b7d97a04f

tdf#152029 Bring comment fields to attention in the document view

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 38 Commit Notification 2022-12-16 08:46:20 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/ae6191cb386bc6c8bf8227e7121b26a86b556a6f

tdf#152029 Bring footnotes and endnotes to attention in the document

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 39 Commit Notification 2022-12-17 05:08:21 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c6410fc51a89464898622ae3859931f81178a01

tdf#152029 cleanup: Bring content to attention in document view

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 40 Commit Notification 2022-12-18 15:14:08 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/50a5b5580729d6d537a696f7c91f212c8f3b995d

tdf#152029 Bring tox sections to attention in the document view

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 41 Jim Raykowski 2022-12-18 20:48:12 UTC
Hover over is now implemented for all content types. Much thanks to Noel for review of the patches.

Is this enough to mark as resolved or should the flash on select also be done?
Comment 42 V Stuart Foote 2022-12-18 22:03:48 UTC
(In reply to Jim Raykowski from comment #41)
> Hover over is now implemented for all content types. Much thanks to Noel for
> review of the patches.
> 
> Is this enough to mark as resolved or should the flash on select also be
> done?

@Jim, these mouse-over canvas/navigator "attention" features alone are very effective additions to the Sidebar Navigator UI 

Let's close this out cleanly, and put any "canvas flash on click-selection" on a back burner as a new enhancement BZ ticket. Maybe a GSOC topic with hinting/mentorship?
Comment 43 BogdanB 2022-12-19 05:25:12 UTC
Hi, why this bug in the status of New?
Comment 44 Commit Notification 2022-12-20 06:10:29 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/2ef1800e03890609b24883fa7fd970540280905e

tdf#152029 Bring comment fields to attention in the document view

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 45 Commit Notification 2022-12-20 06:10:34 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/18ce4278c37f58887ee830d4f8b2746ed14f20e6

tdf#152029 cleanup: Bring content to attention in document view

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 46 Commit Notification 2022-12-20 06:10:37 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/a89972b681cf041b47b3e059c16f1e1080972a7f

tdf#152029 Bring tox sections to attention in the document view

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 47 Commit Notification 2022-12-21 08:27:59 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5930f928e777ab95ed26619c43fa5ae334685deb

tdf#152029 follow up: Handle content that extends to following pages

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 48 Commit Notification 2022-12-21 14:20:07 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/cd274347896dc88bb137ef8cae87a86d9b977aef

tdf#152029 follow up: Handle content that extends to following pages

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 49 Commit Notification 2022-12-21 22:56:00 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c73354b9f66ba436d933cc6558a38470e00c6ba8

tdf#152029 Headings can also use BringTypesWithFlowFramesToAttention

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 50 Commit Notification 2022-12-22 13:08:12 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/84c2e39007c0ab29f90111d4fe0b24f0b55f7eba

tdf#152029 Headings can also use BringTypesWithFlowFramesToAttention

It will be available in 7.5.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 51 BogdanB 2022-12-29 13:34:17 UTC
I checked comments, sections and headings, and everything is fine in
Version: 7.5.0.1.0+ (X86_64) / LibreOffice Community
Build ID: 1e6e59f874b219d2ff3c8363a69ce7ba6a44bc1c
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded

Just as a note:
It's hard to see for comments that are inserted when the cursor is only in the text, and we have no selection made. When the comment is inserted after some text is selected, the area for text is bigger and easier to see the effect.
Comment 52 BogdanB 2022-12-29 13:43:28 UTC
Also I tested: hyperlink, bookmarks, drawing controls (for example Form - Textbox), tables, frames, images, OLE Object, footnotes, endnotes.

Everything fine.
Comment 53 Stéphane Guillou (stragu) 2023-02-26 21:53:15 UTC
Added to 7.5 release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.5&type=revision&diff=639303&oldid=638502
Comment 54 Commit Notification 2023-09-17 20:39:42 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/80a24870491385ba145757bf517c5f1cf7939017

tdf#152029 Don't include frame area top margin in the bring headings to

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 55 Commit Notification 2023-09-21 16:01:28 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b97f7b6bee733e108d8214d5387b2dc019d93d8f

tdf#152029 Don't include frame area top margin in the bring table to

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 56 Commit Notification 2023-09-22 09:08:49 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bb3a60cfdbed880e482229e0eed08b5e2e7e311b

tdf#152029 Fix bringing a heading to attention brings a section to

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 57 Commit Notification 2023-09-26 00:47:53 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5e9c8d21874eea8cb5adf2ecab1905295af2308f

tdf#152029 Fix sections not brought to attention in master document

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 58 Commit Notification 2023-09-30 19:20:20 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f2b1f30c98a351ec0330db9f131d608c29a3336

tdf#152029 Improve bringing sections to attention

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 59 Commit Notification 2023-10-14 18:39:29 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/18f35dffae44e741ea492ed5304f2d2d9d000f2d

tdf#152029 related: Remove attention overlay on document view change

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 60 Jean-Francois Nifenecker 2023-12-01 22:25:06 UTC
I've discovered this enhancement very recently (for title paragraphs). I appreciate that one can see the paragraph overall size but I find the big black background to be very annoying and conveying a false idea of selection. 

So here're two questions/suggestions:

1. can this behaviour be disabled to get back to the former display? If yes, how?

2. can the black background be changed for some lighter colour? If yes, how can the user do that?

I think the good ol' gray "I" bar/symbol was a great tool, on the condition it can make the total height of the paragraph visible. I do miss it. IMO the new black thing is awful.

Also, this black background conveys a selection idea while nothing is selected. Hitting Ctrl+C when the background is visible selects more than the only paragraph and can lead people to some surprises.
Comment 61 Eyal Rozenberg 2023-12-01 23:43:43 UTC
(In reply to Jean-Francois Nifenecker from comment #60)
> I've discovered this enhancement very recently (for title paragraphs). I
> appreciate that one can see the paragraph overall size but I find the big
> black background to be very annoying and conveying a false idea of
> selection. 

Title paragraphs? Hmm, I don't remember asking for that... and bookmarks are typically zero-width (although the flashing seems to be of a full character).

> 1. can this behaviour be disabled to get back to the former display? If yes,
> how?

Do you want disablement of all of it, or just for things like headings, tables, frames etc?

> I think the good ol' gray "I" bar/symbol was a great tool, on the condition
> it can make the total height of the paragraph visible. I do miss it. IMO the
> new black thing is awful.

The problem with it is that it was extremely easy to miss. But it's not as though a black highlight was my initial idea.