Bug 152070 - Import failure: The background parameters do not set up the same way as in Powerpoint
Summary: Import failure: The background parameters do not set up the same way as in Po...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Tibor Nagy
URL:
Whiteboard: target:7.6.0 target:7.5.0.0.beta2 tar...
Keywords: filter:pptx
Depends on:
Blocks: PPTX-Images
  Show dependency treegraph
 
Reported: 2022-11-16 13:40 UTC by NISZ LibreOffice Team
Modified: 2023-09-01 12:42 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
File for testingh the bug (986.36 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2022-11-16 13:41 UTC, NISZ LibreOffice Team
Details
comparison between LO (top left), OnlyOffice (top right), Google Slides viewer (bottom left) and editor (bottom right) (1.93 MB, image/png)
2022-11-16 15:37 UTC, Stéphane Guillou (stragu)
Details
The example file in PP2016 and LO 7.5master (1.03 MB, image/png)
2022-11-27 22:50 UTC, Gabor Kelemen (allotropia)
Details
The example file after fixing manually the values (1.04 MB, image/png)
2022-11-27 22:54 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-11-16 13:40:21 UTC
Description:
When I open a pptx file which created in PowerPoint and it has a background slide with Tiling Position and background size modification.
Then the opened pptx doesn't look like the same as in PowerPoint.


Steps to Reproduce:
1. Open the attached file in LO

Actual Results:
The slide background doesn't look like in PowerPoint.
Because the background parameters don't set up the same way as PowerPoint.

Expected Results:
The background same as in PowerPoint. So the background parameters have the same amount like in PowerPoint.



Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3c0be5564afe1b9cc843a49aba88b72af74c43ab
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded
Comment 1 NISZ LibreOffice Team 2022-11-16 13:41:08 UTC
Created attachment 183627 [details]
File for testingh the bug
Comment 2 Stéphane Guillou (stragu) 2022-11-16 15:37:09 UTC
Created attachment 183629 [details]
comparison between LO (top left), OnlyOffice (top right), Google Slides viewer (bottom left) and editor (bottom right)

What does it look like in MSO for you? This is it compared between LO, OnlyOffice and Google Slides.
Comment 3 Gabor Kelemen (allotropia) 2022-11-27 22:50:13 UTC
Created attachment 183836 [details]
The example file in PP2016 and LO 7.5master

In 
Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 3b0b9fcb80242abcedc01eb388a57b1016916353
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

The X an Y offsets are incorrectly read:
- In PP they are defined as 130 pt X and 142,5 pt Y
- In Impress these are imported as 3% and 6%.
The goat image is not shifted from the left and top enough, so we have 2.5 rows of it instead of 2 and almost 3 columns instead of 2.5-ish.

How to change between points and percentages?
Changing the Impress units in Properties, it seems like we have and original image with 383,50 pt width and 255,63 pt height.
The PP offset of 130 pt is about 34% of the 383,50 pt and the 142,5 pt is about 57% of the 255,63 pt. Manually setting these values reproduces the same(-ish) layout as in PP.
Comment 4 Gabor Kelemen (allotropia) 2022-11-27 22:54:06 UTC
Created attachment 183837 [details]
The example file after fixing manually the values

Can we say the bug is about correcting the XY Offset import?

I'm not sure about the effect of the "Scale X/Y: 10%" values effect.

Side note: If you open the Slide Properties dialog of this file and press OK without changing anything on the Background - Image tab, the Width and Height values are suddenly multiplied by 10. Another issue...
Comment 5 Commit Notification 2022-12-19 12:12:32 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b12e38c1ccb388e62e35d856d4a575e1724a10e9

tdf#152070 PPTX import: fix offset of tile background image

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-12-20 08:49:20 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/63baa8c2450e2333fa343f8ddedad5f5908234e6

tdf#152070 PPTX import: fix offset of tile background image

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2022-12-21 10:31:20 UTC
Verified in:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d948d5c7edbbfd29a77b97a5101aa43917e5ec2
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded
Comment 8 Commit Notification 2023-08-30 10:14:47 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4c2ad6cc750a850dd32e5ae3aceb184ccc54fb5

Follow-up to tdf#152070 sd: fix unit test of tile background

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-09-01 12:42:28 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/8c92ca1287c127cb9ce23d75dead5ae18035b9bf

Follow-up to tdf#152070 sd: fix unit test of tile background

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.