Description: After installation of the LanguageTool extension it is not possible to add words to a dictionary from RMB context menu if 2 or more dictionaries are present and active in LO. Steps to Reproduce: 1. Install LangageTool and restart LO 2. Create additional dictionary to have 2 or more 3. Type random word/letters and try adding them to any of the dictionaries from RMB context menu Actual Results: The word is not added to a dictionary. Expected Results: A word is added to a dictionary. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: pl-PL (pl_PL); UI: en-US Calc: CL
I could not reproduce with: Version: 7.4.2.3 / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (en_AU.UTF-8); UI: en-US Calc: threaded - I activated LanguageTool as per https://languagetool.org/insights/post/product-libreoffice/#how-to-enable-languagetool-on-libreoffice - Created a new dictionary in Tools > Options > Language settings > Writing aids > User-defined dictionaries - I was able to add words to any of my custom dictionaries from the right-click context menu when something was detected as misspelled. I tested with up to two extra dictionaries on top of the "standard.dic" one. Are your steps different in any way?
(In reply to Stéphane Guillou (stragu) from comment #1) > I tested with up to two extra dictionaries on top of the "standard.dic" one. > Are your steps different in any way? The bug is related to LanguageTool extension (v5.9.1 and lower) so you have to install the extension, not to activate the remote solution: https://extensions.libreoffice.org/en/extensions/show/languagetool. LT team is aware of the issue (reported in Oct). In their opinion this is LO bug and they came up with a workaround for future LT 6.0: https://github.com/languagetool-org/languagetool/issues/7298. With the remote solution I'm experiencing yet another issue that words are added to any dictionary but are not recognized afterwards but this is something for another bug report.
[Automated Action] NeedInfo-To-Unconfirmed
What's the difference to your bug 151508? => NEEDINFO
Ah, sorry. 151508 can be closed as a flawed duplicate of sorts. Back then I didn't realize that the issue is connected to having multiple dictionaries (and there is no way to edit the initial entry). Please close 151508 and keep 152110. Thanks!
*** Bug 151508 has been marked as a duplicate of this bug. ***
Mert, any opinion on this one?
LanguageTool workaround introduced in version 6.0 works so far. The drawback is that now all dictionaries are displayed under "Add to Dictionary" context menu, that is other languages than the one selected for current document/text and additional dictionaries that were not visible previously.
Looking at two comments from the LT extension bug tracker[1][2]: > "I think that the problem started with 7.4.0 release where RMB context menus for synonyms and adding to a dictionary were missing. The menus are back now but RMB add to dictionary does not work when there are 2+ dictionaries present and the LanguageTool is installed." [...] With the reply: > Yes, it's a LO bug. It occurs when more than one dictionary is used. [...] I tested with version 5.9.1 of the LT extension. - In LO version 7.3.7.2, adding a word to standard.dic does make the spellcheck underling disappear. - In LO version 7.4.4.2, adding a word to standard.dic fails to include it. Adding it via the spellcheck dialog does work. So it does seem the issue is in LO, but I can't reproduce without the extension installed. I tried adding two custom dictionaries but I couldn't reproduce. What is particular about this extension that it reveals the buggy behaviour? [1]: https://github.com/languagetool-org/languagetool/issues/7298#issuecomment-1320472306 [2]: https://github.com/languagetool-org/languagetool/issues/7298#issuecomment-1320874418 Versions: Repro in: Version: 7.3.7.2 / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Not repro in: Version: 7.4.4.2 / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
I believe this one can be closed. The workaround works. It's not very elegant as the other dictionaries are still visible but at least it works fine.
Thanks Marcin. It is indeed resolved in LT 6.0 and above, but I'm wondering if this might become a problem further down the line... If it helps for anyone wanting to look into it, this is the LT workaround by Fred Kruse: https://github.com/languagetool-org/languagetool/commit/bdf0dd47177dc877d489b661296898b25ba83d8c I've looked into when it started, using the linux-64-releases bibisect repository and the LT extension version 5.9.1: libreoffice-7.4.0.0.alpha1 is the first one affected. I'll try to get to a precise commit next.
Bibisected with linux-64-7.4 repo, English Dictionary 2024.02.01 and LT 5.9.1 to first bad build [90bf995886394ca0da189b5b61a35659ada696e7] which points to: commit afa35742a4633db31b6d6c72cf45741506e9edfb author Caolán McNamara Sat Dec 11 21:09:39 2021 +0000 committer Caolán McNamara Sun Dec 12 13:35:00 2021 +0100 prefer more css::awt::XPopupMenu api Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692 Caolán, same culprit as for bug 157258. Can you please have a look?
Created attachment 193396 [details] recording I'm a bit confused, I went back to language tool 5.6 and installed it in todays (gtk3+linux) trunk version. And did as seen in this recording. Is the problem visible here and I'm missing it, or do I need to do something different?
given that bug #157258 was bisected to the same commit, perhaps the new fix for that also fixes this?
Tested effect of patch 7f7a7cf0eca793a9efb8456f96ccfece07f6f9d9 with linux-64-bibisect repo (build [99f6480f5b2229c203d2d8de9f502f674da6105e]), with LT 5.9.1 and English dictionaries 20240401, it is indeed that commit that also fixes this. Thanks Caolán!
*** Bug 160237 has been marked as a duplicate of this bug. ***