Bug 152158 - Paragraph's negative indent lost after generating Zotero bibliography (since LO 7.4)
Summary: Paragraph's negative indent lost after generating Zotero bibliography (since ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.1.2 release
Hardware: All All
: medium normal
Assignee: Vasily Melenchuk (CIB)
URL:
Whiteboard: target:7.6.0 target:7.5.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Bibliography Paragraph-Indent
  Show dependency treegraph
 
Reported: 2022-11-21 15:14 UTC by John
Modified: 2024-02-07 04:39 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Test document - original without Zotero bibliography (44.11 KB, application/vnd.oasis.opendocument.text)
2022-11-21 15:14 UTC, John
Details
Document with Zotero bibliogaphy generated (44.00 KB, application/vnd.oasis.opendocument.text)
2022-11-21 15:16 UTC, John
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John 2022-11-21 15:14:57 UTC
Created attachment 183700 [details]
Test document - original without Zotero bibliography

Following update from LO 7.3 to 7.4, a curious change began to appear in LibreOffice writer documents whereby the formatting was changed and a tab inserted. This follows on from generating a bibliography using Zotero.

Test 1.odt is template I use a lot. In the section at the bottom of page 1 headed Documents Reviewed I have inserted some lorem ipsum to show that formatting - a kind of reversed hanging paragraph.

In 7.4 after generating a Zotero bibliography (test 2.doc), this formatting is altered in 7.4 but is unchanged in 7.3.

I don't know if this is a regression or an intended change which renders LO 7.4 partially incompatible with Zotero.
Comment 1 John 2022-11-21 15:16:11 UTC
Created attachment 183701 [details]
Document with Zotero bibliogaphy generated
Comment 2 Stéphane Guillou (stragu) 2022-11-25 10:19:05 UTC
Thanks John!

Reproduced in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded

and

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: deb7bc82de19ea8e20c767fdf21f9ba4feb5e9f0
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But not in:

Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded

It's as if inserting the Bibliography removes the paragraph's negative first line indenting to 0 cm (but still shows -0.7 cm in Format > Paragraph > Indents & Spacing > Indent > First line).
Comment 3 Stéphane Guillou (stragu) 2022-11-25 11:18:33 UTC
Bibisected to:
 faeda2f58063d879eb04de2da80ebed99b080d59 is the first bad commit
commit faeda2f58063d879eb04de2da80ebed99b080d59
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Aug 3 22:14:41 2022 +0200

    source 49b432d2c42000a561494c82fa56646424f3d288

 instdir/program/libswlo.so           | Bin 23152616 -> 23152640 bytes
 instdir/program/libwriterfilterlo.so | Bin 3501728 -> 3501728 bytes
 instdir/program/setuprc              |   2 +-
 instdir/program/versionrc            |   2 +-
 4 files changed, 2 insertions(+), 2 deletions(-)

Which points to:

commit 49b432d2c42000a561494c82fa56646424f3d288
author	Vasily Melenchuk <vasily.melenchuk@cib.de>	Thu May 26 12:05:58 2022 +0300
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	Wed Aug 03 21:56:29 2022 +0200
tree a6b03be5c072ec02c091951eedc03ca414e47405
parent ea753b9c35616efa203dd6eddc524b54b198768a [diff]

tdf#148360: sw: do not ignore list label followed by even if numbering is empty.

Vasily, could you please have a look?
Comment 4 John 2023-01-25 12:36:33 UTC
I see that this is still present in 7.5.0.2. Is there any prospect of a fix?
Comment 5 Vasily Melenchuk (CIB) 2023-04-27 12:01:51 UTC
As I see from these test documents, generated version suddenly got NoNumberingShowFollowBy=true compatibility option for MS Word documents and thus Writer starts to display "follow by" symbols for lists.

I'm not sure how Zotero bibliography does work, but probably reason is the same as in tdf#151974: copy/pasting of Rich Text fragments.
Comment 6 Vasily Melenchuk (CIB) 2023-05-04 07:15:52 UTC
John or Stéphane, can you verify this bug is fixed or still remains with fresh master?

I hope that since tdf#151974 is fixed this one is also fixed.
Comment 7 Stéphane Guillou (stragu) 2023-05-04 13:04:09 UTC
(In reply to Vasily Melenchuk (CIB) from comment #6)
> John or Stéphane, can you verify this bug is fixed or still remains with
> fresh master?
> 
> I hope that since tdf#151974 is fixed this one is also fixed.

Yes, I can confirm that it is now fixed in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 83b1f6b58a30bdb589e9ce73deef39f021aebde1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Using Zotero 6.0.26.

I will +1 the cherrypick for 7.5.

Vasily, can you set to Resolved - Fixed?

Thanks Vasily and John!
Comment 8 Vasily Melenchuk (CIB) 2023-05-04 13:07:56 UTC
Nice, this is what I was assuming, but since I did not run the Zotero  bibliography stuff was not able to ensure that it is actually fixed.
Comment 9 Stéphane Guillou (stragu) 2023-05-04 13:20:46 UTC
Marking as verified. Cheers!