Created attachment 183876 [details] indent markers and tabStop in DarkMode Indent markers are almost invisible in DarkMode. They looked better in ver. 7.3.4.2.
Please retest with nightly master against 7.5 and provide the os/DE you are working in.
Created attachment 183893 [details] indent_marker_7.5 This seems to have been fixed on 7.5.0
tested with Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 360b5861fb46353e7a6b9f5abf13339cd719a8df CPU threads: 8; OS: Mac OS X 10.15.7; UI render: Skia/Metal; VCL: osx Locale: en-US (en_FR.UTF-8); UI: en-US Calc: threaded
(In reply to dhina from comment #2) > Created attachment 183893 [details] > indent_marker_7.5 > > This seems to have been fixed on 7.5.0 Really? I don't see any indent marker in attachment 183893 [details]. And they are barely visible in W11 DarkDev.png, attached. Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 5b18eebc2c95321ce7e6edf10f4df81557382a48 CPU threads: 4; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: en-CA (en_CA); UI: en-US Calc: CL threaded "Experimental features"enabled Windows 11
Created attachment 183901 [details] tabStops and indent markers in DarkMode; barely visible
The active toolbar elements (B, U) should have a darker (green?) background. Attachment #183901 [details]
Hmm, kind of subjective. In truth the indent markers and the tab stops are perfectly readable. The default black on white/black on gray for traditional os/DE 'Light' color theme is toggled for the os/DE 'Dark' color theme. The tics, tab marks and margin settings become simple White on black marks. They are readable. Could they have higher contrast? Sure. And could the ruler bar have better contrast to background? Sure. Would require refactoring of the ruler object to pick up additional theme color(s).
Created attachment 183905 [details] Win10 os/DE in dark color mode, default LibreOffice "automatic" color scheme vs. LibreOffice Dark color scheme with fixed colors So Windows, and macOS benefit from the kludged fixed color 'LibreOffice Dark' color scheme shown here on Windows 10 in os/DE dark color mode. In current master against 7.5.0 the default white on black UI toggle is on top. On bottom is same install with the 'LibreOffice Dark' color scheme enabled, showing the altered fixed color for Document background and Application background which though constrained are visually more appealing. Without major rework of the Application Colors frame work to more granularly define the UI not clear more can be done for Windows and macOS.
(In reply to V Stuart Foote from comment #7) > In truth the indent markers and the tab stops are perfectly readable. ● Honestly? > The tics, tab marks and margin settings become simple White on black marks. ● ‘White on black’ would be good; but they really are dark-grey on black
(In reply to TorrAB from comment #9) > (In reply to V Stuart Foote from comment #7) > > > In truth the indent markers and the tab stops are perfectly readable. > ● Honestly? I think it depends of the screen brightness and people's eyes. Above 30% brightness on my laptop, I can see them enough. But I think they should be visible even for low-brightness and then I agree the contrast between them and their background should be increased.
@Caolán, see any *simple* solution here?
I think the specific color at issue here is vcl's "DarkShadowColor"
Created attachment 183952 [details] macOS before
Created attachment 183953 [details] macOS after proposed change with this patch https://gerrit.libreoffice.org/c/core/+/143573
I see a plausible setting on windows to get something meaningful from the theme
Created attachment 183955 [details] windows before change
Created attachment 183956 [details] windows after proposed change with patch at https://gerrit.libreoffice.org/c/core/+/143594
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1e222575a3b637398b5b2d8e3172f12538ff34e3 Related: tdf#152284 use a different macOS DarkShadow It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/fa98397842f42a9741f1e6b110d7feebec994e3d Resolves: tdf#152284 pull Shadow and DarkShadow from theme It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8d66d1f270b1f3fdb76d749fa92189d669ea436d Resolves: tdf#152284 pull Shadow and DarkShadow from theme It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 183988 [details] old above and new below showing increased ruler element contrast upper clip from 20221201 nightly Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ce60a3dd4dbff0dcb5b82c9053ae5d90f8ac929d CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded below clip from 20221204 nightly Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: c50cf1883af26daebdfc9d796ced3c20c222f43b CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded