Bug 152378 - Accessibility check: text formatting issue detected for line with no characters
Summary: Accessibility check: text formatting issue detected for line with no characters
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords: accessibility
Depends on:
Blocks: a11y, Accessibility Accessibility-Check
  Show dependency tree / graph
 
Reported: 2022-12-04 23:08 UTC by Stéphane Guillou (stragu)
Modified: 2023-06-01 12:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
document to test (10.93 KB, application/vnd.oasis.opendocument.text)
2022-12-04 23:08 UTC, Stéphane Guillou (stragu) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2022-12-04 23:08:13 UTC 
Created attachment 183990 [details]
document to test

Steps:

1. Open attachment
2. Tools > Accessibility check
3. Click on second "Go to issue" button for "text formatting conveys additional meaning"

Results:
Not text is selected, but cursor goes to second, empty line of document even though there are no characters.

Expected:
Even though writing in that second line would take the same formatting as the first line, it should not be flagged when it has no characters.

Version:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a41c82407bbb73a4d87070326485ec4b4e954a65
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2022-12-05 11:21:50 UTC 
Samuel or Paris, you might be interested?

Also on Windows:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: bfe33d42a2381bce194cc6fe15b830902f7c8443
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded
Comment 2 Paris Oplopoios 2022-12-05 13:24:56 UTC 
(In reply to Stéphane Guillou (stragu) from comment #1)
> Samuel or Paris, you might be interested?
> 
> Also on Windows:
> 
> Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
> Build ID: bfe33d42a2381bce194cc6fe15b830902f7c8443
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: en-GB (en_GB); UI: en-GB
> Calc: threaded

Reproduced, submitted a patch here: https://gerrit.libreoffice.org/c/core/+/143673
Comment 3 Stéphane Guillou (stragu) 2022-12-07 13:55:06 UTC 
Reproduced by Paris
Comment 4 Commit Notification 2022-12-21 13:33:52 UTC 
offtkp committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be405c3f1843a381e951fcc63e4cc9d76002e73d

tdf#152378 a11y: Don't trigger check for empty highlighted text

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Gabor Kelemen (allotropia) 2023-06-01 12:00:33 UTC 
Confirming that above commit fixed the issue.