Bug 152455 - Strings not translatable in paste special dialog
Summary: Strings not translatable in paste special dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.6.0 target:7.5.0.0.beta2 tar...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-10 13:12 UTC by Jean-Baptiste Faure
Modified: 2022-12-11 10:24 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Paste special dialog with untranslated buttons (56.54 KB, image/png)
2022-12-10 13:15 UTC, Jean-Baptiste Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2022-12-10 13:12:53 UTC
Description:
In the paste special dialog from Calc, the three buttons at the bottom of the dialog (Help, Cancel, OK) are not translated in French although weblate says that the UI translation is complete. So it seems that the corresponding strings are missing the tag translatable. In that case, the bug should be visible in all translations.

Steps to Reproduce:
1.Open a new empty spreadsheet with a French version of Calc
2.type something in A1
3.select A1
4.Menu Edition > Collage spécial > Collage spécial or Ctrl+Shift+V

Actual Results:
The Paste special dialog popup
Buttons Help, Cancel and OK are not translated


Expected Results:
Instead of "Help" we should see "Aide" ans instead of "Cancel" we should see "Annuler".
NdT: in the French version I always keep OK for OK, but I do not know what other language teams do.


Reproducible: Always


User Profile Reset: No

Additional Info:
Weblate says that the translations of UI 7.4, 7.3 and 7.2 are complete.
I do not reproduce the problem in 7.3
Reproducible also in 7.5 beta1 and master, but there the translation of the UI is not complete.
Comment 1 Jean-Baptiste Faure 2022-12-10 13:15:24 UTC
Created attachment 184082 [details]
Paste special dialog with untranslated buttons
Comment 2 Julien Nabet 2022-12-10 17:53:39 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 3 Julien Nabet 2022-12-10 17:53:49 UTC
I gave a try with https://gerrit.libreoffice.org/c/core/+/143908
Comment 4 Commit Notification 2022-12-10 18:51:28 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a12cf7902d8139e8a7a9d30dd9a9360a05411b8c

tdf#152455: Strings not translatable in paste special dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Jean-Baptiste Faure 2022-12-10 20:39:02 UTC
(In reply to Julien Nabet from comment #3)
> I gave a try with https://gerrit.libreoffice.org/c/core/+/143908

That fixed the problem for me on the master (7.6). How does it works without new translation in weblate? Does your change instruct the dialog to use standard translation from the OS?

Please could you backport your fix to 7.5 and 7.4?

Best regards.
JBF
Comment 6 Julien Nabet 2022-12-10 20:52:37 UTC
(In reply to Jean-Baptiste Faure from comment #5)
> (In reply to Julien Nabet from comment #3)
> > I gave a try with https://gerrit.libreoffice.org/c/core/+/143908
> 
> That fixed the problem for me on the master (7.6). How does it works without
> new translation in weblate? Does your change instruct the dialog to use
> standard translation from the OS?
I must recognize I don't know, I just compared code with other cases (git grep -n -3 'GtkButton" id="cancel"'|grep Cancel) and tested if the patch worked locally.

Searching about "stock" in cgit, I found some info in
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d5d905b480c2a9b1db982f2867e87b5c230d1ab9

> 
> Please could you backport your fix to 7.5 and 7.4?
About 7.5, there's already a patch here just waiting for Jenkins validation now:
https://gerrit.libreoffice.org/c/core/+/143924

For 7.4, I've just submitted the backport for review here:
https://gerrit.libreoffice.org/c/core/+/143926
Comment 7 Commit Notification 2022-12-10 21:24:44 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/206e80960e4607e5bcde09db3ce511d18c9b2428

tdf#152455: Strings not translatable in paste special dialog

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Jean-Baptiste Faure 2022-12-10 21:54:56 UTC
(In reply to Commit Notification from comment #7)
> Julien Nabet committed a patch related to this issue.
> It has been pushed to "libreoffice-7-5":
> [...]
> Affected users are encouraged to test the fix and report feedback.

Thank you very much Julien for this patch. It fixes the problem for LO 7.5 beta.

Best regards.
JBF
Comment 9 Commit Notification 2022-12-11 10:24:37 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/563180953f72d2cffb1d81365d88fb330278d4b0

tdf#152455: Strings not translatable in paste special dialog

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.