Bug 152514 - Save icon in old high contrast theme extension disappears after any changes
Summary: Save icon in old high contrast theme extension disappears after any changes
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: High-Contrast
  Show dependency treegraph
 
Reported: 2022-12-15 04:13 UTC by Artur Wdo
Modified: 2022-12-28 22:29 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
issue (119.63 KB, image/jpeg)
2022-12-16 21:35 UTC, Artur Wdo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Artur Wdo 2022-12-15 04:13:33 UTC
Description:
Save icon on hicontrast theme disappears after any changes.
Come back after save sheet.

Steps to Reproduce:
1.Set hicontrast icons theme
2.Make any changes is any cell
3.

Actual Results:
1.Set hicontrast icons theme
2.Make any changes is any cell

Expected Results:
Save icon on top bar in left corner disappears.


Reproducible: Always


User Profile Reset: No

Additional Info:
-
Comment 1 Stéphane Guillou (stragu) 2022-12-15 06:31:02 UTC
Hi Artur

I could not reproduce in:

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

- Which icon theme exactly are you using?
- Are you using the Windows high contrast setting?
- Please copy and paste here the info in Help > About LibreOffice
Comment 2 Artur Wdo 2022-12-15 21:43:17 UTC
Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: pl-PL (pl_PL); UI: pl-PL
Calc: CL

I using high contrast setting in Windows.

I uninstall and install LO on default settings.

When I using normal theme in windows I can change icons theme in LO but when I using high contrast in Windows I can't change icon theme in LO. If I choose something LO every time change setting on Sifr(Dark).

I found my own solution. I downloaded hicontrast theme in menu View in LO and delete all default theme in C:\Program Files\LibreOffice\share\config.

After this modification I can useing hicontrast icon on high contrast setting in Windows but after any changes in any cell icon Save disappeared. After sheet  Saved icon come back.

The problem is that can't change icon theme other than Sift(Dark) when useing high contrast setting in Windows. Even my solution not fully working because after changes Save icon  disappeared.
Comment 3 QA Administrators 2022-12-16 03:19:36 UTC Comment hidden (obsolete)
Comment 4 Stéphane Guillou (stragu) 2022-12-16 06:48:57 UTC
So you are using this specific theme?
https://extensions.libreoffice.org/en/extensions/show/high-contrast-icon-theme

- Please attach a screenshot to show the issue.
- There were many improvements for dark mode and high contrast in the upcoming 7.5 release. It would be great if you could test it to see if you still reproduce the issue: https://dev-builds.libreoffice.org/daily/master/current.html

But I'm wondering if the issue lies in the old icon theme extension and not in LO...
Comment 5 Artur Wdo 2022-12-16 21:35:51 UTC
Created attachment 184200 [details]
issue

In alpha version behavior is the same.
Comment 6 Artur Wdo 2022-12-16 21:50:53 UTC
In OpenOffice is work fine. Before changes icon is dark and after any changes icon become blue.
Comment 7 QA Administrators 2022-12-17 03:19:44 UTC Comment hidden (obsolete)
Comment 8 Stéphane Guillou (stragu) 2022-12-19 19:45:05 UTC
As a workaround, in version 7.5 or 7.6, could you please see if "Tools > Options > LibreOffice > Accessibility > Options for high contrast appearance > High contrast > Disable" allows you to pick an icon set and not have it changed automatically?

I haven't been able to make the extension work in these recent versions though.
Comment 9 V Stuart Foote 2022-12-19 22:25:18 UTC
When a Windows os/DE signals high contrast, LibreOffice is hardcoded to toggle into HighContrat mode--meaning explicit use of the Sifr icon set.

The "HighContrast" icon theme of the extension, does in fact work--but the os/DE must not flag it is in a HighContrast mode.

The default Sifr, and now Sifr Dark, are considered the best UI for HighContrast support. If something else is needed, don't enable the canned win32s high contrast and use a UWP theme, light or dark -- LibreOffice is doing a better job now at 7.5 and master against 7.6
Comment 10 Artur Wdo 2022-12-20 09:38:31 UTC
OK I wanted try proposed solution but before it I see that on 7.6 changes icons is possible on evry modes "Auto,Enabled and disabled". I don't know whe on first time after start is not worked maybe reason is that I deleted default themes and downloaded only optional themes. I have many work but when I will have time I will install 7.6 again and try again on default settings.


I found new problem but I don't know how I can repete it.
On one sheet when I want set conditional formatting in one cell after set many random cells changes view not only in modyfied cell.
Problem was on 7.4 on 7.6 I not trying. I made the same operation in OpenOffice and the problem did not occur.
Comment 11 Stéphane Guillou (stragu) 2022-12-28 22:29:05 UTC
(In reply to Artur Wdo from comment #10)
> I found new problem but I don't know how I can repete it.
> On one sheet when I want set conditional formatting in one cell after set
> many random cells changes view not only in modyfied cell.
> Problem was on 7.4 on 7.6 I not trying. I made the same operation in
> OpenOffice and the problem did not occur.

Please open a new bug report if you can't find an existing one for this issue. Thank you!