Bug 152545 - Connectors line spacing problem
Summary: Connectors line spacing problem
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Tibor Nagy
URL:
Whiteboard: target:7.6.0 target:7.5.2
Keywords: bibisected, bisected, regression
: 153103 (view as bug list)
Depends on:
Blocks: Connectors PPTX-Shapes
  Show dependency treegraph
 
Reported: 2022-12-16 12:58 UTC by NISZ LibreOffice Team
Modified: 2023-03-08 19:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample file (19.70 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2022-12-16 12:59 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem (75.71 KB, image/png)
2022-12-16 13:00 UTC, NISZ LibreOffice Team
Details
Unit test document (36.06 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-02-15 11:34 UTC, László Németh
Details
screenshot: test doc in MSO 365 (26.14 KB, image/png)
2023-02-15 11:35 UTC, László Németh
Details
screenshot: test doc in LO 6.4 (27.50 KB, image/png)
2023-02-15 11:35 UTC, László Németh
Details
test doc in LO master (HEAD: 2b8170c885c14e46d6bc3e2a3686f80d52f021d3) (27.18 KB, image/png)
2023-02-15 11:36 UTC, László Németh
Details
test doc in LO master with proposed patch (https://gerrit.libreoffice.org/c/core/+/146162/7/) (27.43 KB, image/png)
2023-02-15 11:38 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-12-16 12:58:12 UTC
Description:
When I create a connector in PPTX and open it in Libreoffice, the MSO default value of 0.63 line space 
changes to 0 in Libreoffice.


Steps to Reproduce:
1.Open the attached file in LO


Actual Results:
The line changes will change.

Expected Results:
The line changes are not changed.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b46020c262045aed0beace4708565235c2523cc
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded
Comment 1 NISZ LibreOffice Team 2022-12-16 12:59:31 UTC
Created attachment 184182 [details]
Sample file
Comment 2 NISZ LibreOffice Team 2022-12-16 13:00:26 UTC
Created attachment 184183 [details]
Screenshot of the problem
Comment 3 raal 2022-12-16 19:50:19 UTC
Works in Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.1
Calc: threaded

broken in Version: 7.5.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 89188837f60d83a901b2c43f73d30e1957920f50
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 4 raal 2022-12-16 19:56:11 UTC
This seems to have begun at the below commit.
Adding Cc: to László Németh; Could you possibly take a look at this one?
Thanks
 3b1e6d7cd7c153358b0793caa2da016590f607cc is the first bad commit
commit 3b1e6d7cd7c153358b0793caa2da016590f607cc
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Thu Oct 27 20:29:32 2022 +0200

    source eec48130271188cab63665acedbabf1ff5e850a2

https://gerrit.libreoffice.org/c/core/+/141723
Comment 5 László Németh 2023-02-15 11:34:56 UTC
Created attachment 185373 [details]
Unit test document
Comment 6 László Németh 2023-02-15 11:35:24 UTC
Created attachment 185374 [details]
screenshot: test doc in MSO 365
Comment 7 László Németh 2023-02-15 11:35:43 UTC
Created attachment 185375 [details]
screenshot: test doc in LO 6.4
Comment 8 László Németh 2023-02-15 11:36:31 UTC
Created attachment 185376 [details]
test doc in LO master (HEAD: 2b8170c885c14e46d6bc3e2a3686f80d52f021d3)
Comment 9 László Németh 2023-02-15 11:38:11 UTC
Created attachment 185377 [details]
test doc in LO master with proposed patch (https://gerrit.libreoffice.org/c/core/+/146162/7/)
Comment 10 László Németh 2023-02-15 11:39:52 UTC
Note: it seems, the unit test document was loaded by LO 6.4, like MSO 365 does, but not as the recent master with and without the proposed patch.
Comment 11 Commit Notification 2023-02-17 20:02:29 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a2c32afcae257e797ad69ab2346bbe3b6a2fa8ae

tdf#149756 tdf#152545 PPTX import: position of standard connector - part2

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Tibor Nagy 2023-02-20 08:28:25 UTC
*** Bug 153103 has been marked as a duplicate of this bug. ***
Comment 13 NISZ LibreOffice Team 2023-02-21 07:46:58 UTC
VERIFIED IN:
Version: 7.3.7.2.n1 (x64)
Build ID: 2e299289cf8e9e0c4f8a1f8da9a460eabd24cf7b
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 14 Commit Notification 2023-03-08 19:17:32 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/5308d68a7cc0a4b38216438150adba2ac62e2bbe

tdf#149756 tdf#152545 PPTX import: position of standard connector - part2

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.