Bug 152559 - Skia - LibreOffice Draw crashed when I zoom in the view of a diagram
Summary: Skia - LibreOffice Draw crashed when I zoom in the view of a diagram
Status: RESOLVED DUPLICATE of bug 151627
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.6.0 target:7.5.1 target:7.4.6
Keywords:
Depends on:
Blocks: Skia
  Show dependency treegraph
 
Reported: 2022-12-16 21:06 UTC by robomurphy98
Modified: 2023-02-07 09:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
When I resize the pages panel (27.33 KB, image/png)
2022-12-16 21:06 UTC, robomurphy98
Details
Skia.log (153 bytes, text/plain)
2022-12-17 11:31 UTC, robomurphy98
Details
GraphicsTest (2.03 KB, text/plain)
2022-12-17 11:32 UTC, robomurphy98
Details
Video showing the problem (2.24 MB, video/mp4)
2022-12-17 19:49 UTC, robomurphy98
Details
In LO Draw (632.77 KB, video/mp4)
2022-12-17 19:52 UTC, robomurphy98
Details

Note You need to log in before you can comment on or make changes to this bug.
Description robomurphy98 2022-12-16 21:06:04 UTC
Description:
Good evening everyone, I have Skia enabled in LibreOffice and I started to make a small entity relationship diagram. Before starting the document I made the pages panel smaller to have a better view and I began to draw.

Everything was going well but it was to enlarge the view of the drawing with the mouse the view and in this... crash. It's not the first time this has happened to me, there are other times that just changing the size of the page panels also crashes.

Steps to Reproduce:
1.Open LibreOffice Draw
2.Change the size of pages panel
3.Zoom in the drawing

Actual Results:
Crash

Expected Results:
Not crash


Reproducible: Sometimes


User Profile Reset: Yes

Additional Info:
Sometimes just changing the page panel size crashes, in Impress it once happened to me.
Comment 1 robomurphy98 2022-12-16 21:06:44 UTC
Created attachment 184199 [details]
When I resize the pages panel
Comment 2 robomurphy98 2022-12-16 21:16:58 UTC
It can test fine when "playing around" by resizing the panel, zooming in and out of the drawing view, or changing the page orientation.
Comment 3 Julien Nabet 2022-12-17 09:46:39 UTC
Could you apply https://wiki.documentfoundation.org/QA/FirstSteps#Graphics-related_issues_.28_Skia_.29 ? (check you got last graphic driver and if you still reproduce the crash provide <user profile>/cache/skia.log)
Comment 4 robomurphy98 2022-12-17 11:31:52 UTC
Created attachment 184206 [details]
Skia.log
Comment 5 robomurphy98 2022-12-17 11:32:28 UTC
Created attachment 184207 [details]
GraphicsTest
Comment 6 robomurphy98 2022-12-17 11:33:10 UTC
I upload it. I think it has to do with Bug 151627.
Comment 7 Julien Nabet 2022-12-17 12:20:19 UTC
https://gerrit.libreoffice.org/c/core/+/144377
Comment 8 robomurphy98 2022-12-17 13:09:06 UTC
It also crashes me when I select a group of objects and resize them.
Comment 9 Commit Notification 2022-12-17 13:14:02 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f7b94d7ffd785470962e73408f6fd7f7728f8ec5

tdf#151627 + tdf#152559: blacklist Nvidia device id="0x1402"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Julien Nabet 2022-12-17 13:17:19 UTC
backport for 7.5: https://gerrit.libreoffice.org/c/core/+/144367
for 7.4: https://gerrit.libreoffice.org/c/core/+/144368

Since it's not a real fix but just a workaround, let's rather put NOTOURBUG.
Comment 11 robomurphy98 2022-12-17 18:48:44 UTC
Thanks Julien!
Comment 12 robomurphy98 2022-12-17 19:49:12 UTC
Created attachment 184213 [details]
Video showing the problem
Comment 13 robomurphy98 2022-12-17 19:52:19 UTC
Created attachment 184214 [details]
In LO Draw
Comment 14 Julien Nabet 2022-12-18 11:31:22 UTC
V Stuart: do you think we should reopen this one too?
Comment 15 V Stuart Foote 2022-12-18 18:04:38 UTC
Going to duplicate this to bug 151627, the crash only occurs with Skia Vulkan rendering (not clear how common and for which devices) but it appears the issue is in how Skia libs calculate the resize of the frame elements for the Slidsorter--erasing and redraw the resized rectangles of the preview.

Skia raster mode doesn't crash, but both Skia raster and Skia Vulkan rendering seem to suffer the same implementation error with the layout glitch in the sd Slidesorter (Draw & Impress).

And the GDI+ rendering does not manifest the visual glitch at all.

We could find that the denylist handling for the nVidia 0x1402 device is not necessary if it otherwise behaves with Vulkan rendering.

*** This bug has been marked as a duplicate of bug 151627 ***
Comment 16 Commit Notification 2023-02-07 09:37:46 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/01dc36e9296f8b9ee5966360dbf53c0a48373880

tdf#151627 + tdf#152559: blacklist Nvidia device id="0x1402"

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2023-02-07 09:37:51 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/5bce4cbe19a5c5fc7fd7d7d682951826a93e4cad

tdf#151627 + tdf#152559: blacklist Nvidia device id="0x1402"

It will be available in 7.4.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.