Description: UI: Hamburger menu looks like gray square in start center with macOS dark mode Steps to Reproduce: 1. Launch LibreOffice start center with dark mode enabled Same issue in writer around the sidebar. hamburger menu an close sidebar button barely visible The A in the styles deck button icon is also not inverted Actual Results: Gray square in right corner Expected Results: Visible lines on hamburger menu Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 8635c9aa8c6f1078a9e220076d5a08daf30077e8 CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded
Created attachment 184353 [details] Screenshot Bold/underline/Italic button need more contrast too
Created attachment 185064 [details] Start Center hamburger icon background too dark Confirming: Start Center hamburger icon background too dark resulting in contrast too low. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652 CPU threads: 8; OS: Mac OS X 13.2; UI render: Skia/Metal; VCL: osx Locale: en-US (en_DE.UTF-8); UI: en-US Calc: threaded @Telesto: can you please file a separate bug for the issue with Sukapura icon set in dark mode in regards to the one issue per bug policy.
The icon theme shown under: tools, options, view, theme is "Automatic (Breeze (dark))" right ? If so, we're talking about the icon of icon_themes/breeze_dark/sfx2/res/menu.png added with tdf#149494 AFAICS the gray background is the color of the button, which is the usual mac button color, rather than the icon itself
Colibre Dark, but makes no difference. There is a bit more context to this discussion: On macOS there are two colors for buttons (or rather icons to interact with). - Inactive: dark grey (the color used for the bar the hamburger icon is located at in start center) - Active: lighter grey (this should ever only show on mouse hover to distinguish what element of UI the user is interacting with) Now LibreOffice uses the hover color to always display and does not change on hover. Both is not ideal. I think the way to resolve this, since the colors are what is to be expected form macOS, to increase the size of the hamburger menu icon so that its visibility is improved. What do you think, Caolán?
Created attachment 185070 [details] mac icons - left icon mouse hover
Created attachment 186795 [details] 2023-04-19 main build with breeze Revisited this in 2023-04-19 main build with breeze (see screenshot). @Telesto: Would the thicker lines in the top right hamburger menu in start center work for you? It has much better visibility.
Created attachment 186799 [details] Screenshot Hmm, I used a non-dark icon theme. Seems fine with Dark Colibre SVG. The question: does the icon theme automatically adapt to dark mode icons?
By now it does. There were different fixes made to follow system settings as best as possible - automatically switching light | dark icon theme was one of those. However this is only applied if you select Settings > View > Icon Theme > Automatic. Your last screenshot shows a different dropdown. Maybe we should keep this issue here limited to the start center dropdown? Reading your initial report, the issue is specifically the lines in the start center hamburger menu. The visibility of those is fine in the screenshot with breeze dark (2023-04-19 main build with breeze): https://bug-attachments.documentfoundation.org/attachment.cgi?id=186795 When testing keep in mind, Start Center is not instantly updated so make sure to restart LibreOffice. Since for breeze the lines have great visibility in both dark and light icon theme, I was wondering if adapting that dropdown style to other icon themes, which may still have poor visibility (like the very thin lines of your initial screenshot.
@Telesto: is this still a problem? Using Settings > View > Appearance > Mode > System (set to dark mode) and Icon Theme > Theme to Automatic (Sukapuara (dark)) this looks fine to my eyes. Please re-open if I am mistaken. The screenshot you posted does not seem to be from start center but writer or another component since a ruler UI is visible. Or am I seeing that in a wrong way?