Bug 152929 - Sparkline ignore "High points" color when all values are negative
Summary: Sparkline ignore "High points" color when all values are negative
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All Linux (All)
: medium minor
Assignee: Julien Nabet
URL:
Whiteboard: target:24.8.0 target:24.2.0.0.beta2 t...
Keywords: implementationError
Depends on:
Blocks: Sparklines
  Show dependency treegraph
 
Reported: 2023-01-08 16:05 UTC by Grobe
Modified: 2023-12-15 07:41 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document that have two independent rows with numbers and sparkline (10.75 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-01-08 16:05 UTC, Grobe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grobe 2023-01-08 16:05:11 UTC
Created attachment 184525 [details]
Sample document that have two independent rows with numbers and sparkline

See attached spreadsheet.

In sparkline group editor, the "High points" is set to a black-like color.

However, it seems that the visible output on screen, that setting is ignored.
Instead of the bar representing the highest value (all negative, so the one that i closest to zero must be regarded as "High  value") being black (or any color given) - it just remains the same color as for sparkline series.
Comment 1 Buovjaga 2023-03-21 13:08:20 UTC
Confirmed

Arch Linux 64-bit, X11
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 660f73385562314e01abb4cef9d443b0c0f42b06
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 21 March 2023
Comment 2 Julien Nabet 2023-12-13 21:22:15 UTC
https://gerrit.libreoffice.org/c/core/+/160719
Comment 3 Commit Notification 2023-12-14 00:40:59 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2fd2c247f7f62f9ae6826c4f1b9065a50313217

tdf#152929: Sparkline ignore "High points" color when all values are negative

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2023-12-14 07:55:06 UTC
Patch for 24.2: https://gerrit.libreoffice.org/c/core/+/160701
Patch for 7.6 branch waiting for review here:
https://gerrit.libreoffice.org/c/core/+/160702
Comment 5 Commit Notification 2023-12-14 10:02:14 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/691876554f6acbe9665a391fe78e476b049dffdb

tdf#152929: Sparkline ignore "High points" color when all values are negative

It will be available in 24.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-12-15 07:41:50 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/01b3529052059f37f1e87e827982d03ce22744b0

tdf#152929: Sparkline ignore "High points" color when all values are negative

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.