Bug 153115 - Deleted tracked information re-inserted after undo of text to table & Assertion failed: (!pLayout->HasMergedParas() || pNd->GetRedlineMergeFlag() != SwNode::Merge::Hidden), function InsertCnt_, file frmtool.cxx, line 1977.
Summary: Deleted tracked information re-inserted after undo of text to table & Asserti...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.0.2 target:7...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Crash-Assert Table
  Show dependency tree / graph
 
Reported: 2023-01-19 21:38 UTC by Telesto
Modified: 2023-07-31 20:17 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Sample (1.22 MB, application/vnd.oasis.opendocument.text)
2023-01-19 21:38 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-01-19 21:38:25 UTC 
Description:
Deleted tracked information re-inserted after undo of text to table

Steps to Reproduce:
1. Open the attached file (based on attachment at bug 147938)
2. Select the content of the red table.. 
3. Table -> Convert -> Text to table
4. CTRL+Z (2x)
5. CTRL+Z (2x) -> now image is missing

Actual Results:
A) Multiple undo steps
B) Text marked deleted reappears
C) Result doesn't match file on file open

Expected Results:
Undo behaving as expected


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2023-01-19 21:38:34 UTC 
Created attachment 184786 [details]
Sample
Comment 2 Stéphane Guillou (stragu) 2023-01-20 10:24:47 UTC 
Repro with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And same since:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Extra step of weirdness:
6. Ctrl + Y all the way to the end: image duplicated, then both images disappear.

7.0 hangs with high memory and CPU usage on Text to Table action.

Version: 7.0.6.2
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 3 csyu.279 2023-02-16 02:55:07 UTC 
I think the regression was introduced here but I want to note two things that happened while I was bibisecting: 

1) the header separated from rest of the document, making it two pages instead of one 
2) the red line surrounding the table disappeared

https://git.libreoffice.org/core/+/471212d464f54054f7419ef1890267d0def852d9%5E%21

commit 471212d464f54054f7419ef1890267d0def852d9	[log]
author	Michael Stahl <Michael.Stahl@cib.de>	Tue Sep 04 18:55:13 2018
committer	Michael Stahl <Michael.Stahl@cib.de>	Wed Sep 19 10:18:30 2018
tree 16b90833fc4f410f2d3a8fc6601cf492f0fcfda7
parent 12a841e1f102ff7f47a7281120fe777bf440d2fd [diff]

Bibisected with: bibisect-win32-6.3

Adding Cc: to Michael Stahl
Comment 4 Commit Notification 2023-07-19 18:04:14 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd20d9512aa4f9fbe39fce48b3c49cdb13cca6e6

tdf#153115 sw: SwDoc::TextToTable(), first remove all redlines

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-07-19 18:06:17 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba99cc9d9cf781d9b3888e1cf5becd95bb9fc6d2

tdf#153115 sw: fix yet another FindPrvNxtFrameNode() issue

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Stahl (allotropia) 2023-07-19 18:07:16 UTC 
fixed  on master
Comment 7 Commit Notification 2023-07-25 18:51:56 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/c69f4a34c65572fbfe01298d90cb0aa6c7afb4de

tdf#153115 sw: fix yet another FindPrvNxtFrameNode() issue

It will be available in 7.6.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-07-31 20:17:40 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/809e7f777aa58d38f6aca6105b1659a09d22579c

tdf#153115 sw: SwDoc::TextToTable(), first remove all redlines

It will be available in 7.5.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-07-31 20:17:43 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/0eea257cfc084903e4b20e923b06ac2bdd17a4e8

tdf#153115 sw: SwDoc::TextToTable(), first remove all redlines

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.