Bug 153121 - Open comment inside slide stays above other windows
Summary: Open comment inside slide stays above other windows
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: ImpressDraw-Comments
  Show dependency treegraph
 
Reported: 2023-01-20 09:26 UTC by Petronel MALUTAN
Modified: 2023-10-16 14:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Libre slide bug (230.17 KB, image/png)
2023-01-23 10:10 UTC, Petronel MALUTAN
Details
Visual reproducing (679.86 KB, video/webm)
2023-01-25 09:28 UTC, Petronel MALUTAN
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petronel MALUTAN 2023-01-20 09:26:08 UTC
Description:
When minimize the LibreOffice, comment remain on top of other UBUNTU 22 windows

Steps to Reproduce:
1. Create a comment inside a slide and see is open.
2. Minimize LibreOffice
3. Comment window remain open on top of all Ubuntu windows

Actual Results:
Comment window remain open

Expected Results:
the comment window minimize with its parent (LibreOffice)


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment window remain open
Comment 1 Stéphane Guillou (stragu) 2023-01-20 10:08:50 UTC
I can't reproduce with Ubuntu 20.04 with GNOME 3.36.8 with Wayland:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Can you please share the info from Help > About LibreOffice?
Is this about Impress only?
Comment 2 Petronel MALUTAN 2023-01-23 10:10:34 UTC
Created attachment 184837 [details]
Libre slide bug
Comment 3 QA Administrators 2023-01-24 03:20:26 UTC Comment hidden (obsolete)
Comment 4 Petronel MALUTAN 2023-01-25 09:28:44 UTC
Created attachment 184902 [details]
Visual reproducing

in reply to cannot reproduce, please see the video!
Comment 5 raal 2023-01-25 17:19:06 UTC
I can repro with Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.1
Calc: threaded

and Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b9159aa9073318c6892787d721b8cd732525972
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

X11

No repro Version: 6.1.0.0.alpha1+
Build ID: 3a801799536e6870f2fb111b1cc00b9575a35a39
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group
Comment 6 Stéphane Guillou (stragu) 2023-01-26 10:24:52 UTC
I can now reproduce with GEN VCL, thank you!

No repro in:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Repro in:

Version: 7.2.7.2 / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In 7.1 and before, switching windows would close the comment. Maybe a fix to keep the comment open for editing despite switching focus?
Comment 7 Stéphane Guillou (stragu) 2023-01-26 10:41:33 UTC
Bibisected with linux-64-7.2 repo to first bad commit 37ea7447c68f57b716fa099642dbeee9eb8d3b60 which points to core commit:

commit d4ed266849b558b041acb740a18bd81fa39bc582	[log]
author	Miklos Vajna <vmiklos@collabora.com>	Mon Mar 29 20:57:07 2021 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	Tue Mar 30 09:03:42 2021 +0200
tree cd0fc8ba91c425a965c03ceae65fc4ba1884acc3
parent a247d2f896d7fcb30f35cf95f69e32534a475fba [diff]
tdf#133350 vcl focus loss: fix unwanted cancel of non-menu popup
Change-Id: Ida503d0c13dc5a96287bfa31b6c2ce9d4a53e940
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113326

Miklos, can you please have a look?

As expected, same in Draw.
Comment 8 Miklos Vajna 2023-10-16 07:07:20 UTC
This never really worked properly, it's a bug in how the popup feature is implemented, I guess. The timeline I know is like this:

- this was originally broken, then commit f21d2b48bd68424a96aa6cd5572e368208378291 (tdf#121723 vcl: leave popup mode on focus loss of toplevel windows, 2018-11-26) changed things, so it looked like this works
- then commit d4ed266849b558b041acb740a18bd81fa39bc582 (tdf#133350 vcl focus loss: fix unwanted cancel of non-menu popup, 2021-03-29) noticed that this breaks things and partially reverted the "fix"

So this only "worked" while it introduced bug 133350, it never really worked in a clean way.

It's still a bug, it makes sense to fix this, but I would not consider this as a true regression. Adjusting keywords accordingly.
Comment 9 Stéphane Guillou (stragu) 2023-10-16 14:22:51 UTC
(In reply to Miklos Vajna from comment #8)
> - this was originally broken

Ah yes, I can reproduce in OOo 3.3. However, to add to the timeline: in my tests with the linux-64-releases bibisect repo, it would not persist above other windows since libreoffice-5.1.1.1, so something in https://wiki.documentfoundation.org/Releases/5.1.1/RC1 must have changed it for the better, before it popped back up in 7.2.