Bug 153400 - Formatting change remains after undoing rejecting changes
Summary: Formatting change remains after undoing rejecting changes
Status: RESOLVED DUPLICATE of bug 150674
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, regression
Depends on:
Blocks: Track-Changes-TextFormatting
  Show dependency treegraph
Reported: 2023-02-05 21:33 UTC by Telesto
Modified: 2023-02-20 15:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-02-05 21:33:22 UTC
Different font size after undo rejecting changes

Steps to Reproduce:
1. Open attachment 179678 [details]
3. Change Font Size to 16
4. Edit -> Track Changes -> Manage -> Reject on by one
5. Close the dialog
6. CTRL+Z everything

Actual Results:
Text with green highlighting being Font Size 12

Expected Results:
Font Size 10

Reproducible: Always

User Profile Reset: No

Additional Info:
Version: (X86_64) / LibreOffice Community
Build ID: d8ae6d1388f28c405c4de2dfe93dbfe2d8acd470
CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2023-02-19 22:36:25 UTC
Reproduced, but green highlight has font size 16 (not 12).

Version: / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Regression, as not reproduced in:

Version: / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Back in 7.2, change in font size appeared as one single change in the Manage dialog.
Comment 2 Stéphane Guillou (stragu) 2023-02-20 15:17:17 UTC
Some more details about the behaviour:

- It is not only related to size, it looks like it's any formatting.
- One everything is undone, we can redo once + undo once to restore the original formatting.

Bibisected with linux-64-7.3 repo to following range:


First bad commit I could identify is c36da188cc7c9d89c331deb6326f045b6e9f0ad9, but it is a fix for the rest of the range's crash on any change to text formatting. (bug 144304)

This regression seems to be correlated with when tracked changes started recording one change per paragraph instead of one single action (which I think is a bug in itself, creates track changes noise).

In the range, this commit draws the attention (others are related to tracked table changes):

commit 97440778670d6b471d8165eb9f86def08e1b8602
author	László Németh <nemeth@numbertext.org>	Tue Aug 24 14:26:57 2021 +0200
committer	László Németh <nemeth@numbertext.org>	Mon Aug 30 10:47:33 2021 +0200
tree adc1cb3dc08ca0dcf73498dd6952ae0a6b33ebdb
parent 89e8786f932793a9aadc7d8a7d2eec4fa2a081c4
tdf#144173 sw track changes: keep format of hints
When a text has multiple character formatting settings
enabled and a new one is applied with tracked changes,
only one of the former settings is restored upon rejecting
the changes.
Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892
"tdf#143918 sw: fix reject of multiple changes".
Change-Id: I6f3fb52dbd536efaf084b1fc5b8032658353af91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121012

László, what do you think?
Comment 3 Stéphane Guillou (stragu) 2023-02-20 15:19:57 UTC
Uh, looks like an exact dupe of your bug 150674, Telesto.

*** This bug has been marked as a duplicate of bug 150674 ***