Bug 153416 - Some buttons are white-on-white on macOS
Summary: Some buttons are white-on-white on macOS
Status: RESOLVED DUPLICATE of bug 152486
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All macOS (All)
: high normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
: 153594 (view as bug list)
Depends on:
Blocks: macOS-UI-polish
  Show dependency treegraph
 
Reported: 2023-02-06 17:21 UTC by Ken Shirriff
Modified: 2023-03-16 12:51 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
A screenshot showing the button problem (93.81 KB, image/jpeg)
2023-02-06 17:21 UTC, Ken Shirriff
Details
Screenshot 1(3) – Start Center – Document Preview (746.74 KB, image/png)
2023-02-20 20:44 UTC, Sierk Bornemann
Details
Screenshot 2(3) – Start Center – Document Preview (750.58 KB, image/png)
2023-02-20 20:45 UTC, Sierk Bornemann
Details
Screenshot 3(3) – Start Center – Document Preview (751.06 KB, image/png)
2023-02-20 20:45 UTC, Sierk Bornemann
Details
page properties dialog using dark mode after a while (178.60 KB, image/png)
2023-03-14 10:53 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Shirriff 2023-02-06 17:21:19 UTC
Created attachment 185158 [details]
A screenshot showing the button problem
Comment 1 Ken Shirriff 2023-02-06 17:25:45 UTC
Sometimes buttons show up unreadable as white-on-white. The screenshot shows the Release Notes button as a white oval.

I have seen this occasionally on earlier versions. Often the "Save Document" dialog will show the "Don't Save" and "Cancel" buttons but the "Save" button is white-on-white. So this seems to be associated with highlighted buttons.

Repeatability: it happens often enough that I decided to file a bug, but I can't make it happen on demand.

I'm not doing anything strange with my display or themes that might make this happen.
Comment 2 Ken Shirriff 2023-02-06 18:10:34 UTC
The Release Notes button is white-on-white in Safe Mode too, by the way.
Comment 3 Stéphane Guillou (stragu) 2023-02-20 19:22:55 UTC
I haven't managed to reproduce the issue with:

    Version: 7.4.5.1 / LibreOffice Community
    Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
    CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
    Locale: en-US (en_US.UTF-8); UI: en-US
    Calc: threaded


    Version: 7.5.0.3 (X86_64) / LibreOffice Community
    Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
    CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
    Locale: en-US (en_US.UTF-8); UI: en-US
    Calc: threaded

- Do you use dark or light theme in macOS?
- Did you change the user interface / customise the toolbars?
- Can you please paste here the information copied from LibreOffice > About LibreOffice
Comment 4 Sierk Bornemann 2023-02-20 20:40:26 UTC Comment hidden (off-topic)
Comment 5 Sierk Bornemann 2023-02-20 20:43:06 UTC Comment hidden (off-topic)
Comment 6 Sierk Bornemann 2023-02-20 20:44:19 UTC Comment hidden (off-topic)
Comment 7 Sierk Bornemann 2023-02-20 20:45:07 UTC Comment hidden (off-topic)
Comment 8 Sierk Bornemann 2023-02-20 20:45:43 UTC Comment hidden (off-topic)
Comment 9 Sierk Bornemann 2023-02-20 20:48:16 UTC Comment hidden (off-topic)
Comment 10 Ken Shirriff 2023-02-20 22:55:24 UTC
Stéphane, I'm using light mode in macOS. I haven't done any customization of toolbars beyond maybe enabling some of them. The problem happens in Safe Mode too, which I think bypasses customization?

Version information:
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Mac OS X 13.0.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 11 Stéphane Guillou (stragu) 2023-03-03 14:55:57 UTC
Thank you Ken, I can now reproduce the issue as seen in attachment 185158 [details] when macOS is in light mode, for the Release Notes banner.

    Version: 7.5.0.3 (X86_64) / LibreOffice Community
    Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
    CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
    Locale: en-US (en_US.UTF-8); UI: en-US
    Calc: threaded

Sierk, I would recommend opening a new ticket about the issue you are seeing in the start centre, because they are quite different (this issue in light mode, your issue in dark mode), and therefore unlikely to be fixed in one go. You can still link to this issue from there.
Thank you!
Comment 12 Sierk Bornemann 2023-03-03 16:28:03 UTC
(In reply to Stéphane Guillou (stragu) from comment #11)

> Sierk, I would recommend opening a new ticket about the issue you are seeing
> in the start centre, because they are quite different (this issue in light
> mode, your issue in dark mode), and therefore unlikely to be fixed in one
> go. You can still link to this issue from there.
> Thank you!

Done. See new bug #153943.
Comment 13 Stéphane Guillou (stragu) 2023-03-05 00:32:05 UTC
*** Bug 153594 has been marked as a duplicate of this bug. ***
Comment 14 steve 2023-03-14 10:51:32 UTC
*** Bug 153949 has been marked as a duplicate of this bug. ***
Comment 15 steve 2023-03-14 10:53:02 UTC
Not limited to light mode.

https://bugs.documentfoundation.org/show_bug.cgi?id=153949 reports this problem for dark mode dialog buttons and I can confirm also running into this problem using dark mode.

Upping priority, since the buttons become unreadable and by that unusable. The easy workaround is to restart LibreOffice, but that is not really convenient.
Comment 16 steve 2023-03-14 10:53:53 UTC
Created attachment 185951 [details]
page properties dialog using dark mode after a while
Comment 17 Stéphane Guillou (stragu) 2023-03-14 12:58:49 UTC
Caolán and Patrick, what are your thoughts on this one?
Seems to affect both the banner and some dialogs.
Note that duplicate bug 153949 and attachment 185951 [details] might be triggered when the OS theme switches automatically depending on time of day, whereas OP and comment 11 are in OS light mode.
Comment 18 Caolán McNamara 2023-03-14 16:10:40 UTC
I think there's a mix of different things in here, the original one in comment #1, and comment #11 is a button in an infobar and that looks like a duplicate of bug #152486

It's certainly plausible there some "Auto" related problem wrt comment #16 and buttons in normal dialogs, doesn't happen for me if I manually toggle the system from dark to light while it is open, but maybe there is some notification we miss if Auto is enabled and that triggers. I wonder if there is a way to control the "Auto" so that can be freely tested at any time rather than waiting for sunrise :-)
Comment 19 steve 2023-03-14 19:11:06 UTC
Stragu and Caolán: thanks for chiming in here.

I agree with Caolán's assessment of this here being a dupe of https://bugs.documentfoundation.org/show_bug.cgi?id=152486 i.e. white on white button in notification banner.

In turn that means https://bugs.documentfoundation.org/show_bug.cgi?id=153949 is a different problem. Removed duplicate from that so that we can use it to track the remaining problem with white on white buttons in dialogs.

Hope this was the right thing to move forward with a sane bug structure.

*** This bug has been marked as a duplicate of bug 152486 ***
Comment 20 Patrick (volunteer) 2023-03-14 19:26:42 UTC
(In reply to Caolán McNamara from comment #18)
> It's certainly plausible there some "Auto" related problem wrt comment #16
> and buttons in normal dialogs, doesn't happen for me if I manually toggle
> the system from dark to light while it is open, but maybe there is some
> notification we miss if Auto is enabled and that triggers. I wonder if there
> is a way to control the "Auto" so that can be freely tested at any time
> rather than waiting for sunrise :-)

I think that my fix in the following patch may possible be a fix for comment #16:

https://gerrit.libreoffice.org/c/core/+/148570

LibreOffice uses macOS' HITheme functions to draw native buttons, comboboxes, listboxes, etc. It seems that HITheme doesn't always properly sense that the window's dark/light mode setting has changed so I added code to forcefully update the data/light mode setting when a window becomes the focus window.

I never did find a notification for "auto" dark/light mode in my NeoOffice work but I am curious if the above patch will fix this bug. The patch should already be in the LibreOffice 7.6 (master) nightly build if you want to try my fix.
Comment 21 Caolán McNamara 2023-03-14 20:01:36 UTC
ah yes, forgot about that recent change, provides some hope.