Bug 153566 - Windows Dark mode: toolbar context menus have light-on-light header
Summary: Windows Dark mode: toolbar context menus have light-on-light header
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.2 target:7.5.1
Keywords: topicUI
Depends on:
Blocks:
 
Reported: 2023-02-12 14:02 UTC by Mike Kaganski
Modified: 2023-02-22 10:35 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of toolbar context menu on Windows in dark mode (42.62 KB, image/png)
2023-02-12 14:02 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2023-02-12 14:02:28 UTC
Created attachment 185333 [details]
Screenshot of toolbar context menu on Windows in dark mode

As the screenshot shows, toolbars' context menus have light backgrounds and light font in headers (the topmost items showing the toolbar name).
Comment 1 V Stuart Foote 2023-02-12 18:46:50 UTC
Confirmed. Seems the Toolbar Context menus have a title bar element with a different background; foreground Text and bounding outline correctly toggle fg color response but the backing remains light -- fixed color? or a missed element for theme response?
 
with 20230211 build on Windows in os/DE Dark mode color theme and LO mode in Automatic

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9788a565b3241d1bd62394b9e29c322361d05f80
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

and also in with just the theme detection

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 2 Caolán McNamara 2023-02-12 20:17:30 UTC
seems to use the menubar background color for such "title" entries in a menu
Comment 3 Commit Notification 2023-02-12 21:31:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2dded7d07ac818da920644a595b7e9331458e70d

Resolves: tdf#153566 set darkmode menubar background color

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2023-02-12 21:32:13 UTC
done in trunk, backport to 7-5 in gerrit
Comment 5 Commit Notification 2023-02-12 23:15:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/aa6e42c4a46104115947625edb9d7eb34c418758

Resolves: tdf#153566 set darkmode menubar background color

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-02-22 10:35:24 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5-1":

https://git.libreoffice.org/core/commit/303dacdbf3a66c148ee1ec0d6b7a8bead03faa3e

Resolves: tdf#153566 set darkmode menubar background color

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.