Bug 153609 - Elementary's Book Preview icon not distinct enough to Two Pages Preview
Summary: Elementary's Book Preview icon not distinct enough to Two Pages Preview
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: lowest enhancement
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords:
Depends on:
Blocks: Writer-Toolbar-PrintPreview Icon-Theme-Elementary
  Show dependency treegraph
 
Reported: 2023-02-14 09:34 UTC by Stéphane Guillou (stragu)
Modified: 2023-03-16 17:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Highlighted icons in LO 7.6, Elementary icons, GNOME dark mode (6.17 KB, image/png)
2023-02-14 09:36 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-02-14 09:34:24 UTC
Steps:
1. Open LO Writer
2. Make sure Tools > Options > LibreOffice > View > Icon Theme is set to "Elementary"
3. File > Print Preview

Results:
In the toolbar, "Book Preview" only differs from "Two Page Preview" by the spacing between the pages, whereas all other icon themes make them more distinct by using folded corners.

Expected:
Visual that makes the difference in function more obvious.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4a0d671706306661c4a5072ce4769dc47bc65f71
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Was already the case in:

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group
Comment 1 Stéphane Guillou (stragu) 2023-02-14 09:36:45 UTC
Created attachment 185363 [details]
Highlighted icons in LO 7.6, Elementary icons, GNOME dark mode
Comment 2 Rizal Muttaqin 2023-03-09 06:57:36 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Created attachment 185363 [details]
> Highlighted icons in LO 7.6, Elementary icons, GNOME dark mode

Oh yes I kind of agree since elementary use non-folded paper as the representation. Do you think the icons should have folded part?
Comment 3 Stéphane Guillou (stragu) 2023-03-09 09:28:59 UTC
(In reply to Rizal Muttaqin from comment #2)
> Oh yes I kind of agree since elementary use non-folded paper as the
> representation. Do you think the icons should have folded part?

I don't feel like my design opinions should have much weight :D
but since you ask me... if you want to avoid the folds, how about something that looks more obviously like an open book, accentuating the book's spine? While keeping it consistent with other book icons in the icon set, like the one for .uno:AddressBookSource (not sure if there are others)

(please remember to mark the bug as new if you agree the icon needs to be improved)
Comment 4 Commit Notification 2023-03-13 05:45:00 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/982b550541cc68670cad222e921fd62a4c1f232c

elementary: tdf#153609 Update Book Preview in Page Preview

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-03-16 03:42:52 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/ab4d92ae4bf78d0af68d8e1dbf7b035c2b90eb73

elementary: tdf#153609 Update Book Preview in Page Preview

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Stéphane Guillou (stragu) 2023-03-16 16:00:41 UTC
Looks good Rizal, I'd say mark it as fixed unless you've got follow-up commits :)

Thank you!

Verified in:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 44837a12d12be3e525fa48b37c3dd2553cc97d94
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded