Bug 153628 - Spellcheck now does not work v7.5.0.3 X86_64
Summary: Spellcheck now does not work v7.5.0.3 X86_64
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisectNotNeeded, regression
: 153931 (view as bug list)
Depends on:
Blocks: Spell-Checking-Dialog
  Show dependency treegraph
 
Reported: 2023-02-15 06:14 UTC by John Glennie
Modified: 2024-11-03 22:55 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
writer document of snips (42.79 KB, image/jpeg)
2023-02-15 06:18 UTC, John Glennie
Details
Writer - latest Beta abc failure - continued (35.66 KB, application/vnd.oasis.opendocument.text)
2023-02-18 00:42 UTC, John Glennie
Details
reply re Bug 153628 (65.49 KB, image/jpeg)
2023-03-08 00:07 UTC, John Glennie
Details
version tests OK (14.11 KB, image/jpeg)
2023-03-29 02:07 UTC, John Glennie
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Glennie 2023-02-15 06:14:06 UTC
Description:
Spell check a document.
Open abc and cannot progress as options not available.
Previously worked without any issues!

Steps to Reproduce:
1.Spell check and immediately cannot progress
2.
3.

Actual Results:
Followed Safe mode start and the problem still exists.

Expected Results:
he problem still exists


Reproducible: Always


User Profile Reset: Yes

Additional Info:
I have snips in a file but no file upload seems to be available??
Comment 1 John Glennie 2023-02-15 06:18:23 UTC
Created attachment 185372 [details]
writer document of snips

spellcheck fails to operate
Comment 2 Stéphane Guillou (stragu) 2023-02-15 12:23:49 UTC
Thank you for your report, John.
I am pretty confident this has already been fixed for version 7.5.1. Can you please test a master version to confirm? Here: https://dev-builds.libreoffice.org/daily/master/current.html

Thank you!

*** This bug has been marked as a duplicate of bug 152738 ***
Comment 3 John Glennie 2023-02-17 16:19:07 UTC
Hi
I downloaded Win-x86_64@tb77-TDF	2023-02-16 03:28:54	

The result is exactly the same as with the earlier version.
The spell check locks on the first paragraph and the ignore etc tabs are not functional.

Essentially spell check does not work at all.

:)
John
Comment 4 John Glennie 2023-02-18 00:42:33 UTC
Created attachment 185454 [details]
Writer - latest Beta abc failure - continued

language is English (australian)

I also 'tested' abc on a number of other documents.
Some odt and some docx.
The issue appears on almost all.  !

Let me know if you would like more examples.
:)
John
Comment 5 Stéphane Guillou (stragu) 2023-02-28 15:34:24 UTC
I've used your attachment 185454 [details] and could use the spellcheck using versions 7.5.1 and 7.6 alpha0+, on both Windows and Linux, using the Australian English spellcheck.
The only word that was caught was "viridian". I could use all the dialog's buttons.

- Can you please test in Safe Mode? Help > Restart in Safe Mode.
- Please paste here the full information from Help > About LibreOffice.

Thank you!
Comment 6 Stéphane Guillou (stragu) 2023-03-04 10:14:24 UTC
Setting back to unconfirmed, it might be that bug 152738 wasn't completely fixed. Will mention it there.
Please share the information from Help > About LibreOffice.
Comment 7 Xisco Faulí 2023-03-06 11:46:18 UTC
(In reply to John Glennie from comment #3)
> Hi
> I downloaded Win-x86_64@tb77-TDF	2023-02-16 03:28:54	
> 
> The result is exactly the same as with the earlier version.
> The spell check locks on the first paragraph and the ignore etc tabs are not
> functional.
> 
> Essentially spell check does not work at all.
> 
> :)
> John

Could you please paste the information from Help - About LibreOffice ?
Comment 8 Stéphane Guillou (stragu) 2023-03-07 21:56:49 UTC
(In reply to Stéphane Guillou (stragu) from comment #5)
> - Can you please test in Safe Mode? Help > Restart in Safe Mode.

Sorry, just realised you did test in safe mode.

I tested some more and reported in bug 153931 that I can see some buggy behaviour with the dialog stuck in ignore / resume loops, and concluding the spellcheck prematurely. Is that what you mean by "spell check locks on the first paragraph and the ignore etc tabs are not functional", John ?
Or do you see something different?

It would be great if you could provide precise steps to reproduce the issue with the document you provided.
Comment 9 John Glennie 2023-03-08 00:07:13 UTC
Created attachment 185826 [details]
reply re Bug 153628
Comment 10 John Glennie 2023-03-08 00:08:42 UTC
> I tested some more and reported in bug 153931 that I can see some buggy
> behaviour with the 
dialog stuck in ignore / resume loops
, and concluding the
> spellcheck prematurely. Is that what you mean by "spell check locks on the
> first paragraph and the ignore etc tabs are not functional", John ?
> Or do you see something different?

Yes. That is it exactly.
Not necessarily the first paragraph but early.
Looks like it hits a sentence [that could have a context type error] and stops on that.
Not on a specific word.
Close is the only way out. Ignore is not available.

12th short paragraph stop below on page 1. [316 words in]
Comment 11 Stéphane Guillou (stragu) 2023-03-16 09:30:28 UTC
*** Bug 153931 has been marked as a duplicate of this bug. ***
Comment 12 Stéphane Guillou (stragu) 2023-03-16 09:32:31 UTC
Confirmed.

Copied steps from duplicate's comment https://bugs.documentfoundation.org/show_bug.cgi?id=153931#c6 :

1. Open attachment 185825 [details]
2. Start spellcheck (F7), language is English (USA) (I have the green tick)
3. Click "Ignore Once" for "outdented", it ignores successfully. Also click "Ignore once" for "Gravatar".

Result: stuck in an "Ignore once" -> "Resume" loop.

Issue is inconsistent. Other behaviours witnessed:
- Dialog reports that spellcheck is completed even though many more words remain underlined as misspelled
- Spellcheck goes through the whole process without any issue. I can't figure out why I can't reliably reproduce.

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 13 Stéphane Guillou (stragu) 2023-03-23 15:41:13 UTC
László, following your work on bug 152738, any idea what might be happening here?
Comment 14 Commit Notification 2023-03-25 10:08:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/873ec89d20f7a6a8d6d9003d159eb68053c626ff

Related: tdf#153628 too many "Activate" calls with gtk

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 László Németh 2023-03-27 16:09:26 UTC
Proposed fix: https://gerrit.libreoffice.org/c/core/+/149633
Comment 16 Commit Notification 2023-03-28 07:30:48 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bb97bfe3168916ec54404a35f1f0d66d8c06c50d

tdf#153628 sw: fix locked spell checking in spelling dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Stéphane Guillou (stragu) 2023-03-28 09:00:18 UTC
Thank you for looking into it, László!
Unfortunately, I can not reproduce this elusive issue anymore, so can't test the fix... Maybe you have more consistent steps?

John and Mike, please test a master build that contains this fix (in a day or so) and report back if spellcheck works as expected : https://dev-builds.libreoffice.org/daily/master/current.html

Thank you!
Comment 18 László Németh 2023-03-28 09:39:04 UTC
(In reply to Stéphane Guillou (stragu) from comment #17)
> Thank you for looking into it, László!
> Unfortunately, I can not reproduce this elusive issue anymore, so can't test
> the fix... Maybe you have more consistent steps?
> 
> John and Mike, please test a master build that contains this fix (in a day
> or so) and report back if spellcheck works as expected :
> https://dev-builds.libreoffice.org/daily/master/current.html
> 
> Thank you!

Likely not only the spelling dictionary, but the Lightproof English module must be enabled. My patch only reverts the problematic part of the commit, which resulted the regression. In my build it solved the problem, so with Caolán's patch, likely for the others.
Comment 19 László Németh 2023-03-28 09:40:22 UTC
@Stéphane et al.: and thanks for your feedback!
Comment 20 Commit Notification 2023-03-28 11:16:11 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/8d2bf27c3f683e313fea37f8399b4b0be0d16df8

tdf#153628 sw: fix locked spell checking in spelling dialog

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 John Glennie 2023-03-29 02:07:55 UTC
Created attachment 186273 [details]
version tests OK
Comment 22 John Glennie 2023-03-29 02:08:33 UTC
Spellcheck bug now resolved as tests OK
Comment 23 Stéphane Guillou (stragu) 2023-03-29 08:11:34 UTC
(In reply to John Glennie from comment #21)
> Created attachment 186273 [details]
> version tests OK

The version you used does not include the fixes by Caolán and László, so it looks you also have trouble reproducing the issue.
Comment 24 Commit Notification 2023-04-07 16:43:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/92eb41911a080733c5139570096a7e629e6707f4

Related: tdf#153628 too many "Activate" calls with gtk

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 John Glennie 2024-11-03 22:55:52 UTC
system
11th Gen Intel(R) Core(TM) i5-11400 @ 2.60GHz   2.59 GHz
16.0 GB (15.9 GB usable)
64-bit operating system, x64-based processor

Windows 11 Home
23H2
06-‎Oct-‎22
22631.4391
Windows Feature Experience Pack 1000.22700.1047.0