Bug 153656 - Font preview uses black font color in dark mode
Summary: Font preview uses black font color in dark mode
Status: RESOLVED DUPLICATE of bug 153088
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dark-Mode
  Show dependency treegraph
 
Reported: 2023-02-16 06:59 UTC by Faisal
Modified: 2023-02-17 10:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Faisal 2023-02-16 06:59:22 UTC
Description:
Font preview in the paragraph style dialog uses black as font color, which is not visible when dark mode is enabled.

Steps to Reproduce:
1. Modify a paragraph style to open the paragraph style dialog
2. Navigate to the "Font" tab

Actual Results:
Font preview box has text printed in black color

Expected Results:
Text in the font preview box should use the dark mode default text color, which is white


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2023-02-16 11:46:50 UTC
I can't reproduce with Windows 10's dark mode and:

Version: 7.5.0.3 (x86) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

What exactly are the dark mode settings you use? Could you please also provide a screenshot?
Comment 2 V Stuart Foote 2023-02-16 14:10:25 UTC
Confirmed 
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

but only with Tools -> Application -> Colors color scheme set to 'LibreOffice Dark' where 'Document background' is LO "Dark Gray 3" and 'Font color' is "Automatic" but shows black.

Then editing the Paragraph Styles dialog where the 'Font' tab preview does show  WYSIWYG black 'Automatic' font color setting but the "Dark Gray 3" color for the 'Document background'-- so black text on dark canvas.

However it has been fixed already, and correctly toggles to the 'Light' fg color on Trunk against 7.6. 

The PS Font preview gets the same handling as the document canvas and now follows the same fg/bg logic. Including when the Application color's 'Document background' is set to other than 'Automatic'.

I don't know if it has been backported for 7.5.1.2 release or a 7.5.2.0 build.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c3bd52f81bf733a0b9b0560794a54b2ac1e0f444
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 V Stuart Foote 2023-02-16 14:45:55 UTC
Just verified the preview on the PS dialog's Font panel will correctly follow fg/bg logic for the 7.5.1 release.

So => WFM

Version: 7.5.1.1 (X86_64) / LibreOffice Community
Build ID: bd819218336a5be54a11b986ea4dd2db2efb120e
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 4 Stéphane Guillou (stragu) 2023-02-17 10:14:00 UTC
Thanks Stuart.
Verified fixed on Linux too:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b52117c0be97c45824d2897657084f8ac7e9bf42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I checked in the bibisect repo linux-64-7.5 and it is indeed Caolán who fixed it with commit fa62e63d6b75aac80dd23520351de11c5a0c9ea4. As such, marking as a duplicate of bug 153088.

*** This bug has been marked as a duplicate of bug 153088 ***