Bug 153660 - Single Undo should remove all diagonal borders created with Toolbar>Borders
Summary: Single Undo should remove all diagonal borders created with Toolbar>Borders
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.3 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
: 158748 (view as bug list)
Depends on:
Blocks: Cell-Border
  Show dependency treegraph
 
Reported: 2023-02-16 09:33 UTC by Timur
Modified: 2023-12-18 11:11 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2023-02-16 09:33:34 UTC
From bug 143919 diagonal borders are accessible in Toolbar>Borders.
There's Undo problem here:
Open a new calc sheet
Mark some cells
Apply borders to the cells: Criss-Cross Border
Undo once to remove the borders - Borders are half removed (wrong behavior)
Undo once more - Border are fully removed

If diagonal borders are created via Format-Cells-Borders, Undo pressed once removes them properly. 
If diagonal borders are created via Toolbar>Borders, Undo should removed them with a single click.
Comment 1 Stéphane Guillou (stragu) 2023-03-05 22:26:47 UTC
Thanks Timur.

With criss-cross, sometimes even two undo actions are not enough and some diagonal "borders" remain with no undo action left.

With "diagonal up" and "diagonal down", only one undo action is available, and sometimes it removes everything, sometimes only a part, sometimes nothing.

Tested with both the toolbar and the sidebar.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: feda414f8b70f50a9f6745d2ce8828316d4711cd
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 ady 2023-03-06 01:07:21 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> With criss-cross, sometimes even two undo actions are not enough and some
> diagonal "borders" remain with no undo action left.
> 
> With "diagonal up" and "diagonal down", only one undo action is available,
> and sometimes it removes everything, sometimes only a part, sometimes
> nothing.

As noted in bug 153644 comment 3, the behavior varies, depending on:
* how many adjacent cells are selected, and on
* whether you perform the action by using the toolbar icon or instead by using the full cell format dialog, and on
* which exact of diagonals are initially applied (i.e. both vs. "one" only vs "the second" only).
Comment 3 Timur 2023-12-18 11:11:10 UTC
*** Bug 158748 has been marked as a duplicate of this bug. ***