Bug 153722 - Rename "chapter style" category into "Document Structure" and add headings
Summary: Rename "chapter style" category into "Document Structure" and add headings
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Kira Tubo
URL:
Whiteboard: target:7.6.0 target:25.2.0
Keywords: difficultyMedium, easyHack, skillDesign, topicDesign
Depends on: Clarify-Chapter-Heading-Outline-Level
Blocks: Sidebar-Styles-Filter
  Show dependency treegraph
 
Reported: 2023-02-19 03:44 UTC by sdc.blanco
Modified: 2024-08-28 19:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of "Text Styles" category (25.41 KB, image/png)
2023-02-19 03:44 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-02-19 03:44:07 UTC
Created attachment 185468 [details]
screenshot of "Text Styles" category

Open Styles deck.
Use category select dropdown box (at bottom), select

1.  "Chapter Styles"

Actual: Appendix
        Subtitle
        Title

Expected:  ??  

2.  "Text Styles"

Actual: see attachment.

Some observations.

1. "Chapter" seems an unfortunate choice for three PS with outline level "Text Body"  (could not find any mention of "chapter styles" in BZ)

2. For "Text Styles", seems unfortunate to have Heading N mixed with the other PS.

3. Maybe "Outline Styles" or "Book Styles" or "Document Styles" (as possible categories) would inspire a better selection.

Initial motivation of ticket:  To change the word "Chapter" in this dialog.

Subsequent motivation: to ask UXEval to consider whether some improvements are needed in relation to these two categories.
Comment 1 sdc.blanco 2023-02-20 00:31:37 UTC
According to [1]:

"Chapter Styles    Displays formatting styles for headings."

[1] https://help.libreoffice.org/7.6/en-US/text/swriter/01/05130000.html

This description does not correspond so well with the actual behavior of the Styles filter.

"Text Styles" are not mentioned in help as a style group.

=> documentation needs to be addressed as well
Comment 2 Heiko Tietze 2023-02-20 07:47:47 UTC
"Outline Styles" sounds reasonable considering the latest activities. Alternatively "Document Structure" for all headings plus the current "chapter style" (suspect that average user understand the idea behind chapter/outline vs text style).
Comment 3 sdc.blanco 2023-02-20 21:41:40 UTC
(In reply to Heiko Tietze from comment #2)
> "Outline Styles" sounds reasonable considering the latest activities.
"Outline" is ambiguous. I only use "outline level".

> Alternatively "Document Structure" for all headings plus the current
> "chapter style" 
"Document Structure" is good.

The current grouping in Text Styles looks like an implementation error. 

Once the Headings are removed from Text Styles, the "logic" of what remains is clear enough.

In sum, the request looks like:

1.  Rename "Chapter Styles" to "Document Structure"
2.  Move "Heading" and "Heading [1-10]" PS from "Text Styles" to "Document Structure"

Maybe an EasyHack?
Comment 4 Heiko Tietze 2023-02-21 09:40:33 UTC
(In reply to sdc.blanco from comment #3)
> 1.  Rename "Chapter Styles" to "Document Structure"
sw/inc/app.hrc: { NC_("RID_PARAGRAPHSTYLEFAMILY", "Chapter Styles")... (just the text in brackets)

> 2.  Move "Heading" and "Heading [1-10]" PS from "Text Styles" to "Document
> Structure"
sw/source/core/doc/DocumentStylePoolManager.cxx (would try to move headings from STR_POOLCOLL_TEXT_ARY into STR_POOLCOLL_DOC_ARY)
Comment 5 Commit Notification 2023-02-22 11:23:37 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fce44263b6b59a720dfebb1643430339dc3959f6

(partial) tdf#153722  "Chapter Styles" -> "Document structure"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-02-27 04:04:05 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/22b85af46f3eacc6abd45be4e78d13079851e55c

tdf#153722  "Chapter Styles" -> "Document Structure"
Comment 7 Commit Notification 2024-08-26 08:38:26 UTC
Kira Tubo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1fefb68a916918620f0bad7c879ff805c416bec4

tdf#153722 Move Headings from "Text Styles" to "Document Structure"

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Kira Tubo 2024-08-28 05:12:03 UTC
This should now be fully completed per Comment 5 and Comment 7, so marking as RESOLVED.
Comment 9 Buovjaga 2024-08-28 09:34:16 UTC
(In reply to Commit Notification from comment #7)
> Kira Tubo committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> 1fefb68a916918620f0bad7c879ff805c416bec4
> 
> tdf#153722 Move Headings from "Text Styles" to "Document Structure"
> 
> It will be available in 25.2.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

I checked help and there does not seem to be any need to adjust the content after this change.
Comment 10 Kira Tubo 2024-08-28 19:41:24 UTC
(In reply to Buovjaga from comment #9)
> 
> I checked help and there does not seem to be any need to adjust the content
> after this change.

Great, thanks for checking!