Bug 154042 - account for initial vertical offset when opening Sheet with multiline exposed
Summary: account for initial vertical offset when opening Sheet with multiline exposed
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.2 target:7.4.7
Keywords:
: 155928 (view as bug list)
Depends on:
Blocks: Calc-Formula-Bar
  Show dependency treegraph
 
Reported: 2023-03-07 14:33 UTC by V Stuart Foote
Modified: 2023-06-19 14:07 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
2023-03-07 nightly opening sample doc saved with expanded Formula bar (591.61 KB, image/gif)
2023-03-07 14:33 UTC, V Stuart Foote
Details
sample ODS saved with Formula Bar expanded (8.75 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-03-07 14:35 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2023-03-07 14:33:35 UTC
Created attachment 185818 [details]
2023-03-07 nightly opening sample doc saved with expanded Formula bar

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 55360ba58f33f3f45c83decce092c43d25c4e48c
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

with https://gerrit.libreoffice.org/c/core/+/148069 applied

Opening a document saved with the Formula bar already expanded continues the issue of mispositioned frame.  Displaced downward, clipped on bottom edge. Toggle the Formula bar from multiline to single line and back resolves.

But should open correctly positioned.
Comment 1 V Stuart Foote 2023-03-07 14:35:22 UTC
Created attachment 185819 [details]
sample ODS saved with Formula Bar expanded
Comment 2 Commit Notification 2023-03-07 20:37:37 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cc6fe41b051722ab73a44c7aa00b9101ae0284ca

tdf#154042 Use an initial height of one row for toolbar layout

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2023-03-07 20:39:03 UTC
That works for me, without affecting bug 99708, in trunk. Backports to 7-5 and 7-4 in gerrit.
Comment 4 Commit Notification 2023-03-07 20:43:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/d5a97bbafe02b7d51bb5a6f609acc25f03c8469d

tdf#154042 Use an initial height of one row for toolbar layout

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-03-07 20:44:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/0c1c25a97dff15ace8e9fe1fe91ab1de8adaa41b

tdf#154042 Use an initial height of one row for toolbar layout

It will be available in 7.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 V Stuart Foote 2023-03-09 05:12:35 UTC
Expanded Formula bar is positioned to top edge now on opening, and the value for "FormulaBarHeight" recorded to archive is honored.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a179f6c91692076e7e17babf4890638caa398384
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 7 Mike Kaganski 2023-06-19 14:07:58 UTC
*** Bug 155928 has been marked as a duplicate of this bug. ***