Bug 154162 - Keep ratio setting not included when undoing
Summary: Keep ratio setting not included when undoing
Status: RESOLVED DUPLICATE of bug 143340
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency tree / graph
 
Reported: 2023-03-13 15:06 UTC by Telesto
Modified: 2023-11-05 06:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-03-13 15:06:59 UTC 
Description:
Keep ratio setting isn't included in excluded from Undo

Steps to Reproduce:
1. Open attachment 185930 [details]
2. Select the image and press F4
3. Position and size Tab
4. Check the Keep Ratio checkbox
5. Check the Relative to checkbox for width
6. Press OK
7. Press CTRL+Z
8. Press F4 -> Notice Keep Ratio still being checked

Actual Results:
Undo doesn't undo 'Keep Ratio'

Expected Results:
Undo should include 'Keep Ratio'


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 BogdanB 2023-03-15 09:57:46 UTC 
Confirmed with
Version: 7.5.2.1 (X86_64) / LibreOffice Community
Build ID: e8bf3b441b8370f8440b0339fd9490765a8d57ca
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded
Comment 2 Telesto 2023-03-15 11:20:28 UTC 
@Heiko
Can this be presented as easyHack? There are in theory dozens of examples. OTOH the undo code isn't the easiest in the world, I guess
Comment 3 Heiko Tietze 2023-03-15 11:33:15 UTC 
(In reply to Telesto from comment #2)
> Can this be presented as easyHack?

No idea, maybe Hossein can help with code pointers.
Comment 4 Kira Tubo 2023-11-05 06:36:13 UTC 

*** This bug has been marked as a duplicate of bug 143340 ***