Bug 154237 - UI: When dark theme is selected the closing cross is hard to see
Summary: UI: When dark theme is selected the closing cross is hard to see
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.6.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 125217
Blocks: LibreOffice-Themes
  Show dependency treegraph
 
Reported: 2023-03-17 10:09 UTC by lol
Modified: 2023-03-27 14:18 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Closing cross when dark theme is selected (42.68 KB, image/jpeg)
2023-03-17 10:09 UTC, lol
Details
Closing cross when dark theme is selected (25.66 KB, image/png)
2023-03-25 17:12 UTC, lol
Details
Closing X follows toggle of os/DE color theme automatic detection -- System (64.95 KB, image/png)
2023-03-27 13:59 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2023-03-17 10:09:17 UTC
Created attachment 186021 [details]
Closing cross when dark theme is selected

When the dark theme is selected, the font colour of the menu bar change to white. But for the closing cross, the font colour change not to white. It is still black and hard to see.

1. Open one random file.
2. Change the theme (Tools - Options... - LibreOffice - Personalisation) to dark theme.
3. The font colour of the menu bar change to white, but not for the closing cross (See attached picture).

Occurs in 

Version: 7.4.6.2 (x86) / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

and

Version: 7.4.6.2 (x64) / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2023-03-17 22:28:51 UTC
Please test version 7.5.1.2, which includes a switch in Tools > Options > LibreOffice > View.
Changing that "appearance mode" to "Dark" should solve your issue (and should make the dark Personnalisation Theme obsolete).
Let us know if that works.
Comment 2 lol 2023-03-18 08:19:53 UTC
If I change the "appearance mode" to "Dark" the cross remains at black.


Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2023-03-24 20:59:57 UTC
With Personnalisation set to use the "Dark" theme and View > Appearance mode set to "Dark", the cross is white for me.

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ja-JP (en_GB); UI: en-GB
Calc: threaded

Can you please share another screenshot, and test in Safe Mode again?
Comment 4 lol 2023-03-25 17:12:23 UTC
Created attachment 186218 [details]
Closing cross when dark theme is selected

Here you are. Started LO in Safe Mode. 

Theme dark and appearance dark, cross remains at black.

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 5 Stéphane Guillou (stragu) 2023-03-27 12:08:45 UTC
Thank you for the screenshot.

Stuart, can you see this?
Comment 6 V Stuart Foote 2023-03-27 13:59:47 UTC
Created attachment 186246 [details]
Closing X follows toggle of os/DE color theme automatic detection -- System

(In reply to Stéphane Guillou (stragu) from comment #5)
> Thank you for the screenshot.
> 
> Stuart, can you see this?

Yes. But only if the very broken "Personalization" theme is enabled --and-- Tools -> Options -> View  Appearance is *toggled* from System <-> Dark <-> Light without restarting LO. 

Simply closing module back to Start Center does not fully reset. With the restart the mix of Personalization and os/DE theme mode behaves.

Then no issue with 7.5.1.2 and with master against 7.6.0 as in the clip.

My take is => WF (it is not a bug against os/DE color theme support) and finish stripping out the current Personalization crap as for bug 125217
Comment 7 Stéphane Guillou (stragu) 2023-03-27 14:18:11 UTC
I agree with Stuart here. Personalization themes will eventually be retired / replaced, and are very unlikely to see improvements. The "dark theme" personalization in particular is now obsolete given the improved OS dark mode support across platforms.

Please use exclusively the OS dark theme and the options in Options > LibreOffice > View. If you still reproduce issues in these conditions with LibreOffice 7.5, please feel free to report them in a separate report.